Re: [Bridge] [PATCH net] net: bridge: mcast: Do not allow users to set IGMP counter/timer to zero

2021-10-20 Thread Hangbin Liu
On Wed, Oct 20, 2021 at 08:19:37AM -0700, Stephen Hemminger wrote: > > On Tue, Oct 19, 2021 at 07:09:42PM +0300, Nikolay Aleksandrov wrote: > > > > I started this patch when I saw there is not limit for setting > > > > multicast_membership_interval to 0, which will cause bridge remove the > > > > m

Re: [Bridge] [PATCH net] net: bridge: mcast: Do not allow users to set IGMP counter/timer to zero

2021-10-20 Thread Stephen Hemminger
On Wed, 20 Oct 2021 09:02:01 +0800 Hangbin Liu wrote: > On Tue, Oct 19, 2021 at 07:09:42PM +0300, Nikolay Aleksandrov wrote: > > > I started this patch when I saw there is not limit for setting > > > multicast_membership_interval to 0, which will cause bridge remove the > > > mdb directly after a

Re: [Bridge] [PATCH net] net: bridge: mcast: Do not allow users to set IGMP counter/timer to zero

2021-10-19 Thread Hangbin Liu
On Tue, Oct 19, 2021 at 07:09:42PM +0300, Nikolay Aleksandrov wrote: > > I started this patch when I saw there is not limit for setting > > multicast_membership_interval to 0, which will cause bridge remove the > > mdb directly after adding. Do you think this is a problem. > > > > And what about o

Re: [Bridge] [PATCH net] net: bridge: mcast: Do not allow users to set IGMP counter/timer to zero

2021-10-19 Thread Nikolay Aleksandrov via Bridge
On 19/10/2021 08:43, Hangbin Liu wrote: > Hi Nikolay, > > On Mon, Oct 18, 2021 at 01:28:14PM +0300, Nikolay Aleksandrov wrote: >> On 18/10/2021 11:26, Hangbin Liu wrote: >>> There is no meaning to set an IGMP counter/timer to 0. Or it will cause >>> unexpected behavior. E.g. if set multicast_membe

Re: [Bridge] [PATCH net] net: bridge: mcast: Do not allow users to set IGMP counter/timer to zero

2021-10-18 Thread Hangbin Liu
Hi Nikolay, On Mon, Oct 18, 2021 at 01:28:14PM +0300, Nikolay Aleksandrov wrote: > On 18/10/2021 11:26, Hangbin Liu wrote: > > There is no meaning to set an IGMP counter/timer to 0. Or it will cause > > unexpected behavior. E.g. if set multicast_membership_interval to 0, > > bridge will remove the

Re: [Bridge] [PATCH net] net: bridge: mcast: Do not allow users to set IGMP counter/timer to zero

2021-10-18 Thread Nikolay Aleksandrov via Bridge
On 18/10/2021 11:26, Hangbin Liu wrote: > There is no meaning to set an IGMP counter/timer to 0. Or it will cause > unexpected behavior. E.g. if set multicast_membership_interval to 0, > bridge will remove the mdb immediately after adding. > > Fixes: 79b859f573d6 ("bridge: netlink: add support for

[Bridge] [PATCH net] net: bridge: mcast: Do not allow users to set IGMP counter/timer to zero

2021-10-18 Thread Hangbin Liu
There is no meaning to set an IGMP counter/timer to 0. Or it will cause unexpected behavior. E.g. if set multicast_membership_interval to 0, bridge will remove the mdb immediately after adding. Fixes: 79b859f573d6 ("bridge: netlink: add support for multicast_last_member_count") Fixes: b89e6babad4