Re: [Bridge] [RFC PATCH v2] net: fold dev_disable_lro() into netdev_fix_features()

2011-05-12 Thread Stephen Hemminger
On Thu, 12 May 2011 17:29:07 +0100 Ben Hutchings wrote: > > dev->priv_flags |= IFF_BRIDGE_PORT; > > > > - dev_disable_lro(dev); > > - > > list_add_rcu(&p->list, &br->port_list); > > > > - netdev_update_features(br->dev); > > + netdev_change_features(dev); > > > > spin_lock

Re: [Bridge] [RFC PATCH v2] net: fold dev_disable_lro() into netdev_fix_features()

2011-05-12 Thread Michał Mirosław
On Thu, May 12, 2011 at 05:29:07PM +0100, Ben Hutchings wrote: > On Thu, 2011-05-12 at 18:06 +0200, Michał Mirosław wrote: > > This implements checks for forwarding mode in netdev_fix_features() using > > dev->priv_flags bits. As a side effect, after device is no longer > > forwarding it gets LRO b

Re: [Bridge] [RFC PATCH v2] net: fold dev_disable_lro() into netdev_fix_features()

2011-05-12 Thread Ben Hutchings
On Thu, 2011-05-12 at 18:06 +0200, Michał Mirosław wrote: > This implements checks for forwarding mode in netdev_fix_features() using > dev->priv_flags bits. As a side effect, after device is no longer > forwarding it gets LRO back. This also means that user is not allowed to > enable LRO after dev

[Bridge] [RFC PATCH v2] net: fold dev_disable_lro() into netdev_fix_features()

2011-05-12 Thread Michał Mirosław
This implements checks for forwarding mode in netdev_fix_features() using dev->priv_flags bits. As a side effect, after device is no longer forwarding it gets LRO back. This also means that user is not allowed to enable LRO after device is put to forwarding mode. This patch depends on removal of d