Re: [Bridge] [RFC net-next 6/9] net: dsa: Forward offloading

2021-05-05 Thread Vladimir Oltean
On Wed, May 05, 2021 at 11:01:09AM +0200, Tobias Waldekranz wrote: > On Wed, May 05, 2021 at 02:04, Vladimir Oltean wrote: > > On Wed, May 05, 2021 at 12:12:15AM +0200, Tobias Waldekranz wrote: > >> > and you create a dependency between the tagger and the switch driver > >> > which was supposed by

Re: [Bridge] [RFC net-next 6/9] net: dsa: Forward offloading

2021-05-05 Thread Tobias Waldekranz
On Wed, May 05, 2021 at 02:04, Vladimir Oltean wrote: > On Wed, May 05, 2021 at 12:12:15AM +0200, Tobias Waldekranz wrote: >> > and you create a dependency between the tagger and the switch driver >> > which was supposed by design to not exist. >> >> Sure, but _why_ should it not exist? Many fiel

Re: [Bridge] [RFC net-next 6/9] net: dsa: Forward offloading

2021-05-04 Thread Vladimir Oltean
On Wed, May 05, 2021 at 12:12:15AM +0200, Tobias Waldekranz wrote: > > and you create a dependency between the tagger and the switch driver > > which was supposed by design to not exist. > > Sure, but _why_ should it not exist? Many fields in the tag can only be > correctly generated/interpreted i

Re: [Bridge] [RFC net-next 6/9] net: dsa: Forward offloading

2021-05-04 Thread Tobias Waldekranz
On Tue, May 04, 2021 at 23:58, Vladimir Oltean wrote: > On Tue, May 04, 2021 at 10:07:14PM +0200, Tobias Waldekranz wrote: >> On Tue, May 04, 2021 at 18:21, Vladimir Oltean wrote: >> > On Tue, May 04, 2021 at 04:44:31PM +0200, Tobias Waldekranz wrote: >> >> On Tue, Apr 27, 2021 at 13:17, Vladimir

Re: [Bridge] [RFC net-next 6/9] net: dsa: Forward offloading

2021-05-04 Thread Tobias Waldekranz
On Tue, May 04, 2021 at 22:33, Andrew Lunn wrote: >> There is really no need to recompute the static parts of the tags on >> each skb. It would mean moving some knowledge of the tagging format to >> the driver. But that boundary is pretty artificial for >> mv88e6xxx. tag_dsa has no use outside of

Re: [Bridge] [RFC net-next 6/9] net: dsa: Forward offloading

2021-05-04 Thread Andrew Lunn
> There is really no need to recompute the static parts of the tags on > each skb. It would mean moving some knowledge of the tagging format to > the driver. But that boundary is pretty artificial for > mv88e6xxx. tag_dsa has no use outside of mv88e6xxx, and mv88e6xxx does > not work with any other

Re: [Bridge] [RFC net-next 6/9] net: dsa: Forward offloading

2021-05-04 Thread Vladimir Oltean
On Tue, May 04, 2021 at 10:07:14PM +0200, Tobias Waldekranz wrote: > On Tue, May 04, 2021 at 18:21, Vladimir Oltean wrote: > > On Tue, May 04, 2021 at 04:44:31PM +0200, Tobias Waldekranz wrote: > >> On Tue, Apr 27, 2021 at 13:17, Vladimir Oltean wrote: > >> > On Mon, Apr 26, 2021 at 07:04:08PM +0

Re: [Bridge] [RFC net-next 6/9] net: dsa: Forward offloading

2021-05-04 Thread Tobias Waldekranz
On Tue, May 04, 2021 at 18:21, Vladimir Oltean wrote: > On Tue, May 04, 2021 at 04:44:31PM +0200, Tobias Waldekranz wrote: >> On Tue, Apr 27, 2021 at 13:17, Vladimir Oltean wrote: >> > On Mon, Apr 26, 2021 at 07:04:08PM +0200, Tobias Waldekranz wrote: >> >> Allow DSA drivers to support forward of

Re: [Bridge] [RFC net-next 6/9] net: dsa: Forward offloading

2021-05-04 Thread Vladimir Oltean
On Tue, May 04, 2021 at 04:44:31PM +0200, Tobias Waldekranz wrote: > On Tue, Apr 27, 2021 at 13:17, Vladimir Oltean wrote: > > On Mon, Apr 26, 2021 at 07:04:08PM +0200, Tobias Waldekranz wrote: > >> Allow DSA drivers to support forward offloading from a bridge by: > >> > >> - Passing calls to .nd

Re: [Bridge] [RFC net-next 6/9] net: dsa: Forward offloading

2021-05-04 Thread Tobias Waldekranz
On Tue, Apr 27, 2021 at 13:17, Vladimir Oltean wrote: > On Mon, Apr 26, 2021 at 07:04:08PM +0200, Tobias Waldekranz wrote: >> Allow DSA drivers to support forward offloading from a bridge by: >> >> - Passing calls to .ndo_dfwd_{add,del}_station to the drivers. >> >> - Recording the subordinate d

Re: [Bridge] [RFC net-next 6/9] net: dsa: Forward offloading

2021-04-27 Thread Vladimir Oltean
On Mon, Apr 26, 2021 at 07:04:08PM +0200, Tobias Waldekranz wrote: > Allow DSA drivers to support forward offloading from a bridge by: > > - Passing calls to .ndo_dfwd_{add,del}_station to the drivers. > > - Recording the subordinate device of offloaded skbs in the control > buffer so that the

[Bridge] [RFC net-next 6/9] net: dsa: Forward offloading

2021-04-27 Thread Tobias Waldekranz
Allow DSA drivers to support forward offloading from a bridge by: - Passing calls to .ndo_dfwd_{add,del}_station to the drivers. - Recording the subordinate device of offloaded skbs in the control buffer so that the tagger can take the appropriate action. Signed-off-by: Tobias Waldekranz ---