Re: [Bridge] build breakage due to br_multicast.c referencing ipv6_dev_get_saddr()

2011-03-22 Thread Linus Lüssing
> One unrelated other observation with this change of yours: > daddr is an input argument to ipv6_dev_get_saddr(), yet > it gets initialized only after the function was called. Is that > really correct? Hmm, that wasn't intentional. I tested that again and so far I still always got the right source

Re: [Bridge] build breakage due to br_multicast.c referencing ipv6_dev_get_saddr()

2011-03-17 Thread Brian Haley
On 03/17/2011 03:57 AM, Jan Beulich wrote: On 16.03.11 at 18:34, Brian Haley wrote: >> On 03/16/2011 08:34 AM, Jan Beulich wrote: >>> With BRIDGE=y and IPV6=m commit >>> fe29ec41aaa51902aebd63658dfb04fe6fea8be5 ("bridge: Use IPv6 >>> link-local address for multicast listener queries") causes

Re: [Bridge] build breakage due to br_multicast.c referencing ipv6_dev_get_saddr()

2011-03-17 Thread Brian Haley
On 03/16/2011 08:34 AM, Jan Beulich wrote: > With BRIDGE=y and IPV6=m commit > fe29ec41aaa51902aebd63658dfb04fe6fea8be5 ("bridge: Use IPv6 > link-local address for multicast listener queries") causes the build to > break. > > Similary, even if both are =m, but ipv6.ko got blacklisted (as is > happ

Re: [Bridge] build breakage due to br_multicast.c referencing ipv6_dev_get_saddr()

2011-03-17 Thread David Miller
From: "Jan Beulich" Date: Thu, 17 Mar 2011 08:01:42 + On 16.03.11 at 16:24, Stephen Hemminger > wrote: >> On Wed, 16 Mar 2011 12:34:19 + >> "Jan Beulich" wrote: >> >>> With BRIDGE=y and IPV6=m commit >>> fe29ec41aaa51902aebd63658dfb04fe6fea8be5 ("bridge: Use IPv6 >>> link-local ad

Re: [Bridge] build breakage due to br_multicast.c referencing ipv6_dev_get_saddr()

2011-03-17 Thread Eric Dumazet
Le jeudi 17 mars 2011 à 08:01 +, Jan Beulich a écrit : > >>> On 16.03.11 at 16:24, Stephen Hemminger > wrote: > > On Wed, 16 Mar 2011 12:34:19 + > > "Jan Beulich" wrote: > > > >> With BRIDGE=y and IPV6=m commit > >> fe29ec41aaa51902aebd63658dfb04fe6fea8be5 ("bridge: Use IPv6 > >> link-lo

Re: [Bridge] build breakage due to br_multicast.c referencing ipv6_dev_get_saddr()

2011-03-17 Thread Jan Beulich
>>> On 16.03.11 at 16:24, Stephen Hemminger wrote: > On Wed, 16 Mar 2011 12:34:19 + > "Jan Beulich" wrote: > >> With BRIDGE=y and IPV6=m commit >> fe29ec41aaa51902aebd63658dfb04fe6fea8be5 ("bridge: Use IPv6 >> link-local address for multicast listener queries") causes the build to >> break.

Re: [Bridge] build breakage due to br_multicast.c referencing ipv6_dev_get_saddr()

2011-03-17 Thread Jan Beulich
>>> On 16.03.11 at 18:34, Brian Haley wrote: > On 03/16/2011 08:34 AM, Jan Beulich wrote: >> With BRIDGE=y and IPV6=m commit >> fe29ec41aaa51902aebd63658dfb04fe6fea8be5 ("bridge: Use IPv6 >> link-local address for multicast listener queries") causes the build to >> break. >> >> Similary, even if

Re: [Bridge] build breakage due to br_multicast.c referencing ipv6_dev_get_saddr()

2011-03-17 Thread Jan Beulich
>>> On 16.03.11 at 18:49, David Miller wrote: > From: Stephen Hemminger > Date: Wed, 16 Mar 2011 08:24:41 -0700 > >> On Wed, 16 Mar 2011 12:34:19 + >> "Jan Beulich" wrote: >> >>> With BRIDGE=y and IPV6=m commit >>> fe29ec41aaa51902aebd63658dfb04fe6fea8be5 ("bridge: Use IPv6 >>> link-local

Re: [Bridge] build breakage due to br_multicast.c referencing ipv6_dev_get_saddr()

2011-03-16 Thread David Miller
From: "Jan Beulich" Date: Wed, 16 Mar 2011 12:34:19 + > With BRIDGE=y and IPV6=m commit > fe29ec41aaa51902aebd63658dfb04fe6fea8be5 ("bridge: Use IPv6 > link-local address for multicast listener queries") causes the build to > break. Fixed by: commit dcbcdf22f500ac6e4ec06485341024739b9dc241

Re: [Bridge] build breakage due to br_multicast.c referencing ipv6_dev_get_saddr()

2011-03-16 Thread David Miller
From: Stephen Hemminger Date: Wed, 16 Mar 2011 08:24:41 -0700 > On Wed, 16 Mar 2011 12:34:19 + > "Jan Beulich" wrote: > >> With BRIDGE=y and IPV6=m commit >> fe29ec41aaa51902aebd63658dfb04fe6fea8be5 ("bridge: Use IPv6 >> link-local address for multicast listener queries") causes the build t

Re: [Bridge] build breakage due to br_multicast.c referencing ipv6_dev_get_saddr()

2011-03-16 Thread Stephen Hemminger
On Wed, 16 Mar 2011 12:34:19 + "Jan Beulich" wrote: > With BRIDGE=y and IPV6=m commit > fe29ec41aaa51902aebd63658dfb04fe6fea8be5 ("bridge: Use IPv6 > link-local address for multicast listener queries") causes the build to > break. I have no problem building with 2.6.38 and BRIDGE=y and IPV6=

Re: [Bridge] build breakage due to br_multicast.c referencing ipv6_dev_get_saddr()

2011-03-16 Thread Stephen Hemminger
On Wed, 16 Mar 2011 12:34:19 + "Jan Beulich" wrote: > With BRIDGE=y and IPV6=m commit > fe29ec41aaa51902aebd63658dfb04fe6fea8be5 ("bridge: Use IPv6 > link-local address for multicast listener queries") causes the build to > break. Rather than continue with the config games, lets just make th

[Bridge] build breakage due to br_multicast.c referencing ipv6_dev_get_saddr()

2011-03-16 Thread Jan Beulich
With BRIDGE=y and IPV6=m commit fe29ec41aaa51902aebd63658dfb04fe6fea8be5 ("bridge: Use IPv6 link-local address for multicast listener queries") causes the build to break. Similary, even if both are =m, but ipv6.ko got blacklisted (as is happening in various SuSE distros when disabling IPv6), there