tl;dr summary is to mark as closed or needing work more quickly. ;)
The longer version:
It's been a week and a couple days and we seem to have settled into a little rhythm. Nice work to everyone that has been helping accept task claims quickly! We are having a bit of a persistent backlog getting completed tasks reviewed, so that's an area we can work on streamlining. Towards that, I have three observations:
1) don't hesitate to give them more time if they need it
2) don't hesitate to return a task that has ANY problem
a) REQUIRE code be submitted a patch, point them to http://brlcad.org/wiki/Patches
b) REQUIRE code have proper indentation/style/etc, point them to HACKING
3) don't worry about committing and testing...
Test that patches apply cleanly, but there's no need to commit it at the same time. I'm going to go through every single completed task anyways to make sure they are all appropriately accredited, committed, documented, and tested. Plus, I'm going to add more tasks to test some of the changes already submitted (especially for the LIBRT volume, area, centroid tasks), so some of the remaining work can be offloaded onto other students.
I found *myself* delaying a review because with all the other replies that needed to be sent, I didn't have time to apply the patch, verify it worked, document the changes, and respond to the student. That's all ultimately needed, but not for reviewing since 75% of the time the task will need work.
Basically, if the only thing stopping you from closing the task is a run-time test to verify it works, then it's okay to close the task and we'll get someone else to prove it works (unless you're really dubious just by reading the source, e.g., wrong equations). It's okay to be critical that the submission/patch/write-up style be pristine since that's a cleanup cost we'd be accepting.
So far, we've gotten all comments migrated, all man pages converted, all xml validated, a slew of compilation logs with cleanup work identified, the start of migrating our entire website infrastructure to new hardware, and much more. Several months of work! The completed task count is now up to 58, too many to itemize. :-)
------------------------------------------------------------------------------ LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial Remotely access PCs and mobile devices and provide instant support Improve your efficiency, and focus on delivering more value-add services Discover what IT Professionals Know. Rescue delivers http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________ BRL-CAD Developer mailing list brlcad-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/brlcad-devel
