hi mentors!

ICV has been implemented in view.c (is perfectly fine) and viewedge.c
during old revisions.

*Introduction*

As per the discussion on IRC regarding ICV structures, file information is
removed from the current definitions.

ICV functions previously had these type of usage

icv_save_open() /* Alocates memory opens file, has a filename as one of the
argument */
------writepixel/add pixel---------
icv_save_close()

The current definition will do it in the following way

icv_image_create() // allocates memory as per the number of channel, width
and height.
---------operations read/write etc.-------
icv_image_save() //saves the image as per the filename and data in icv
image struct


***Issue*

In view_edge.c as per the following revision icv_save_open is removed.

---------------------------------------------------------------------------------------------------
r50507 | starseeker | 2012-05-11 05:13:50 +0530 (Fri, 11 May 2012) | 1 line

man image_save_open is already called by do.c:795, resulting in a failure
to open the file when viewedge.c attempts to call it again.  Difference
looks to be ICV_IMAGE_AUTO_NO_PIX vs ICV_IMAGE_AUTO between the two calls -
looking at fileformat.c:278 the only difference is the icv_image_save_open
command will not default to returning a pix file if it doesn't recognize
the image format via extension.  Unless there is a good reason for rtedge
to be a special case, this behavior should probably be consistent across
the rt commands one way or the other.
---------------------------------------------------------------------------------------------------

Also it has usage of icv_save_close() at L:849 in function view_end() Which
in the current version requires filename. and format.

Although I have never used raytracer. But I am not sure if this will be
needed here because opening(creating) and closing(saving) are done in
rt/do.c

I dug the code source further and found icv_save_open only in rt/do.c at
L:781 (among the codes in rt).  Which uses framename (outputfile). If the
above function is needed I could make the framename variable a global
variable and use that in viewedge.c

Also suggest mechanism to test rt.

Cheers!

-- 
*--
Mohit Daga*
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
BRL-CAD Developer mailing list
brlcad-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/brlcad-devel

Reply via email to