Re: [brlcad-devel] style change

2013-10-25 Thread Christopher Sean Morrison
On Oct 23, 2013, at 6:37 AM, Daniel Roßberg wrote: > I would like to have a CMake variable to switch it off. I'm afraid > MSVC needs another day to compile with this check because of slow file > operations. Thanks to Cliff, a style validation option now exists. It would be good to know exactl

Re: [brlcad-devel] style change

2013-10-23 Thread Clifford Yapp
On Wed, Oct 23, 2013 at 6:37 AM, Daniel Roßberg wrote: >> I propose in advance of GCI that we establish style enforcement as part of >> the build so that we don't have to personally discuss / explain style >> issues. Basically, we'd integrate a style check that would run during >> compilation. I

Re: [brlcad-devel] style change

2013-10-23 Thread Daniel Roßberg
> I propose in advance of GCI that we establish style enforcement as part of > the build so that we don't have to personally discuss / explain style > issues. Basically, we'd integrate a style check that would run during > compilation. If a file fails our style check, it results in a compilation

Re: [brlcad-devel] style change

2013-10-22 Thread Christopher Sean Morrison
On Oct 22, 2013, at 10:27 PM, Clifford Yapp wrote: > This has considerable appeal - what technical approach did you have in mind? Basically just running a lintian program (probably astyle) during non-release compilation. If it doesn't pass, report and halt the build. Most likely easiestly ho

Re: [brlcad-devel] style change

2013-10-22 Thread Clifford Yapp
On Tue, Oct 22, 2013 at 10:27 PM, Clifford Yapp wrote: > On Tue, Oct 22, 2013 at 9:06 PM, Christopher Sean Morrison > wrote: >> >> I propose in advance of GCI that we establish style enforcement as part of >> the build so that we don't have to personally discuss / explain style >> issues. Basica

Re: [brlcad-devel] style change

2013-10-22 Thread Clifford Yapp
On Tue, Oct 22, 2013 at 9:06 PM, Christopher Sean Morrison wrote: > > I propose in advance of GCI that we establish style enforcement as part of > the build so that we don't have to personally discuss / explain style > issues. Basically, we'd integrate a style check that would run during > compil

[brlcad-devel] style change

2013-10-22 Thread Christopher Sean Morrison
I propose in advance of GCI that we establish style enforcement as part of the build so that we don't have to personally discuss / explain style issues. Basically, we'd integrate a style check that would run during compilation. If a file fails our style check, it results in a compilation erro