[
https://bro-tracker.atlassian.net/browse/BIT-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=17105#comment-17105
]
Robin Sommer commented on BIT-1215:
---
I haven't looked at the code yet but if there's hard
I haven't looked at the code yet but if there's hard line length
limit in there, that's a problem. bro-cut shouldn't care how long
lines are.
___
bro-dev mailing list
bro-dev@bro.org
http://mailman.icsi.berkeley.edu/mailman/listinfo/bro-dev
We are going to make it configurable and default to like a 1000KB line.
Otherwise, you add a check to see if you need to reallocate memory for every
line processed, which seems inefficient for edge cases. Letting the user
override the default is a good compromise though.
On Jul 10, 2014, at
[
https://bro-tracker.atlassian.net/browse/BIT-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=17107#comment-17107
]
Justin Azoff commented on BIT-1215:
---
I think start with 1M and realloc 2x as needed is the
[
https://bro-tracker.atlassian.net/browse/BIT-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=17106#comment-17106
]
Adam Slagell commented on BIT-1215:
---
We are going to make it configurable and default to like
[
https://bro-tracker.atlassian.net/browse/BIT-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=17108#comment-17108
]
Robin Sommer commented on BIT-1215:
---
Yes. Maybe a bit less than 2x, exponential grows
Johanna Amann created BIT-1217:
--
Summary: Documentation: include type for vectors
Key: BIT-1217
URL: https://bro-tracker.atlassian.net/browse/BIT-1217
Project: Bro Issue Tracker
Issue Type:
On Thu, Jul 10, 2014 at 17:27 -0500, you wrote:
I think start with 1M and realloc 2x as needed is the way to go after
all.
Yes. Maybe a bit less than 2x, exponential grows quickly. :)
I think the only thing to do would be to add an absolute max line
length of 64M or something to handle
[
https://bro-tracker.atlassian.net/browse/BIT-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Siwek updated BIT-1217:
---
Resolution: Fixed
Status: Closed (was: Open)
Documentation: include type for vectors
