[Bro-Dev] [JIRA] (BIT-1268) Crash when tracing script execution (invalid argument to script method?)

2014-10-02 Thread gclark (JIRA)
[ https://bro-tracker.atlassian.net/browse/BIT-1268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gclark updated BIT-1268: Summary: Crash when tracing script execution (invalid argument to script method?) (was: Crash when tracing output)

[Bro-Dev] [JIRA] (BIT-1268) Crash when tracing output

2014-10-02 Thread gclark (JIRA)
gclark created BIT-1268: --- Summary: Crash when tracing output Key: BIT-1268 URL: https://bro-tracker.atlassian.net/browse/BIT-1268 Project: Bro Issue Tracker Issue Type: Problem Components: Br

Re: [Bro-Dev] Pktsrc prefix separator (Re: [JIRA] (BIT-1267) packet source prefix separator in node.cfg breaks broctl)

2014-10-02 Thread Seth Hall
On Oct 2, 2014, at 6:23 PM, Robin Sommer wrote: > On Thu, Oct 02, 2014 at 11:14 -0500, you wrote: > >> How about a double colon: netmap::eth0 > > I like that actually. Me too! Looks like a namespace. :) .Seth -- Seth Hall International Computer Science Institute (Bro) because everyone

Re: [Bro-Dev] Pktsrc prefix separator (Re: [JIRA] (BIT-1267) packet source prefix separator in node.cfg breaks broctl)

2014-10-02 Thread Robin Sommer
On Thu, Oct 02, 2014 at 11:14 -0500, you wrote: > How about a double colon: netmap::eth0 I like that actually. Robin -- Robin Sommer * Phone +1 (510) 722-6541 * ro...@icir.org ICSI/LBNL* Fax +1 (510) 666-2956 * www.icir.org/robin ___ br

[Bro-Dev] [JIRA] (BIT-1266) PktSrc rewrite introduces packet drops

2014-10-02 Thread Robin Sommer (JIRA)
[ https://bro-tracker.atlassian.net/browse/BIT-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robin Sommer updated BIT-1266: -- Resolution: Fixed Status: Closed (was: Open) > PktSrc rewrite introduces packet drops > --

Re: [Bro-Dev] [Bro-Commits] [git/bro] topic/jsiwek/pktsrc-idle: Fix packet sources being treated as idle when a packet is available. (31b7e98)

2014-10-02 Thread Robin Sommer
(I had mixed up the cases in my mail :) On Thu, Oct 02, 2014 at 19:41 +, Jonathan Siwek wrote: > Yeah, if it reports itself as idle while a packet was just retrieved, then > whether or not it’s actually a candidate to be Process()’d can depend on the > result of a subsequent select() — seem

Re: [Bro-Dev] [Bro-Commits] [git/bro] topic/jsiwek/pktsrc-idle: Fix packet sources being treated as idle when a packet is available. (31b7e98)

2014-10-02 Thread Siwek, Jon
Yeah, if it reports itself as idle while a packet was just retrieved, then whether or not it’s actually a candidate to be Process()’d can depend on the result of a subsequent select() — seems problematic :) - Jon On Oct 2, 2014, at 2:34 PM, Robin Sommer wrote: > Never mind, I see that's there

Re: [Bro-Dev] [Bro-Commits] [git/bro] topic/jsiwek/pktsrc-idle: Fix packet sources being treated as idle when a packet is available. (31b7e98)

2014-10-02 Thread Robin Sommer
Never mind, I see that's there already. Robin On Thu, Oct 02, 2014 at 11:48 -0700, I wrote: > > > On Thu, Oct 02, 2014 at 11:25 -0700, Jonathan Siwek wrote: > > > + SetIdle(false); > > The 2.1 code was also doing the opposite: setting to true if we have a > packet. Not immediately

[Bro-Dev] [JIRA] (BIT-1266) PktSrc rewrite introduces packet drops

2014-10-02 Thread Robin Sommer (JIRA)
[ https://bro-tracker.atlassian.net/browse/BIT-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18224#comment-18224 ] Robin Sommer commented on BIT-1266: --- I'll go ahead and merge this in. > PktSrc rewrite intro

Re: [Bro-Dev] [Bro-Commits] [git/bro] topic/jsiwek/pktsrc-idle: Fix packet sources being treated as idle when a packet is available. (31b7e98)

2014-10-02 Thread Robin Sommer
On Thu, Oct 02, 2014 at 11:25 -0700, Jonathan Siwek wrote: > + SetIdle(false); The 2.1 code was also doing the opposite: setting to true if we have a packet. Not immediately sure if that's necessary. Robin -- Robin Sommer * Phone +1 (510) 722-6541 * ro...@icir.org ICSI/LBNL

[Bro-Dev] [JIRA] (BIT-1266) PktSrc rewrite introduces packet drops

2014-10-02 Thread Jon Siwek (JIRA)
[ https://bro-tracker.atlassian.net/browse/BIT-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18223#comment-18223 ] Jon Siwek commented on BIT-1266: He confirmed off-list to me that the patch in topic/jsiwek/pkt

Re: [Bro-Dev] Pktsrc prefix separator (Re: [JIRA] (BIT-1267) packet source prefix separator in node.cfg breaks broctl)

2014-10-02 Thread Daniel Thayer
On 10/02/2014 11:10 AM, Robin Sommer wrote: > > > On Thu, Oct 02, 2014 at 10:56 -0500, you wrote: > >> Is it expected that someone will want to do something >> like this: bro -i netmap:eth0 -i pcap:eth1 > > I wouldn't call it "expected", but I don't want to rule it out either. > I see the plugin

Re: [Bro-Dev] Pktsrc prefix separator (Re: [JIRA] (BIT-1267) packet source prefix separator in node.cfg breaks broctl)

2014-10-02 Thread Robin Sommer
On Thu, Oct 02, 2014 at 10:56 -0500, you wrote: > Is it expected that someone will want to do something > like this: bro -i netmap:eth0 -i pcap:eth1 I wouldn't call it "expected", but I don't want to rule it out either. I see the plugin through which an interface gets routed as a property of

Re: [Bro-Dev] Pktsrc prefix separator (Re: [JIRA] (BIT-1267) packet source prefix separator in node.cfg breaks broctl)

2014-10-02 Thread Daniel Thayer
On 10/02/2014 10:45 AM, Robin Sommer wrote: > (Taking this to bro-dev for discussion.) > > On Wed, Oct 01, 2014 at 22:31 -0500, Daniel wrote for > https://bro-tracker.atlassian.net/browse/BIT-1267: > >> Using a different class (instead of SafeConfigParser) from the >> ConfigParser module seems to f

[Bro-Dev] Pktsrc prefix separator (Re: [JIRA] (BIT-1267) packet source prefix separator in node.cfg breaks broctl)

2014-10-02 Thread Robin Sommer
(Taking this to bro-dev for discussion.) On Wed, Oct 01, 2014 at 22:31 -0500, Daniel wrote for https://bro-tracker.atlassian.net/browse/BIT-1267: > Using a different class (instead of SafeConfigParser) from the > ConfigParser module seems to fix the problem. Seems I hit another prefix separator

[Bro-Dev] [JIRA] (BIT-1266) PktSrc rewrite introduces packet drops

2014-10-02 Thread Robin Sommer (JIRA)
[ https://bro-tracker.atlassian.net/browse/BIT-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18222#comment-18222 ] Robin Sommer commented on BIT-1266: --- Good catch, indeed. The old code did that, and from a

Re: [Bro-Dev] [JIRA] (BIT-1266) PktSrc rewrite introduces packet drops

2014-10-02 Thread Robin Sommer
> Oh, and another difference I think is that PktSrc isn't doing a > SetIdle(false) when a packet is available? Good catch, indeed. The old code did that, and from a quick look it seems that got lost now. I'll lock more closely in a bit. ___ bro-dev mai