Re: [Bro-Dev] attributes & named types

2018-11-03 Thread Vern Paxson
H I've looked into this and there are some subtle issues. First, I tried to make this work using TypeType's like I had sketched, and it turns out to be a mess. Too many points where a decision has to be made whether to access the base type (what the named type points to) rather than the TypeT

Re: [Bro-Dev] attributes & named types

2018-11-03 Thread Vlad Grigorescu
To better understand the existing behavior, here's the commit that introduced this (specifically with regards to conn_id): https://github.com/bro/bro/commit/38a1aa5a346d10de32f9b40e0869cdb48a98974b > The &log keyword now operates as discussed: > > - When associated with individual record field

Re: [Bro-Dev] attributes & named types

2018-11-03 Thread Vern Paxson
Thanks for the pointers & thoughts! A quick question, more in a bit: > To better understand the existing behavior, here's the commit that > introduced this (specifically with regards to conn_id): > https://github.com/bro/bro/commit/38a1aa5a346d10de32f9b40e0869cdb48a98974b > ... > > Note that

Re: [Bro-Dev] attributes & named types

2018-11-03 Thread Vlad Grigorescu
On Sat, Nov 3, 2018 at 9:14 PM Vern Paxson wrote: > Thanks for the pointers & thoughts! A quick question, more in a bit: > > > To better understand the existing behavior, here's the commit that > > introduced this (specifically with regards to conn_id): > > > https://github.com/bro/bro/commit/38