[
https://bro-tracker.atlassian.net/browse/BIT-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robin Sommer updated BIT-1270:
--
Resolution: Merged (was: Fixed)
Status: Closed (was: Merge Request)
[
https://bro-tracker.atlassian.net/browse/BIT-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
gclark updated BIT-1270:
Status: Merge Request (was: Open)
topic/gilbert/plugin-api-tweak
--
[
https://bro-tracker.atlassian.net/browse/BIT-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=19800#comment-19800
]
gclark commented on BIT-1270:
-
Merged master into my branch. This includes changes to modify hook
[
https://bro-tracker.atlassian.net/browse/BIT-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=19800#comment-19800
]
gclark edited comment on BIT-1270 at 2/22/15 11:38 PM:
---
Merged master
So one thing to keep in mind is that not many people will ever write
code using this; it's just for function hooks, and I imagine their use
will be limited. I'm personaly still leaning towards the pair, but
it's not a big deal, the main point was the pass-by-value, and I'm
fine either way. If we
On Mon, Oct 20, 2014 at 08:05 -0700, I wrote:
like ValOrNull (better ideas appreciated :).
Maybe OptionalVal.
Robin
--
Robin Sommer * ICSI/LBNL * ro...@icir.org * www.icir.org/robin
___
bro-dev mailing list
bro-dev@bro.org
On Oct 20, 2014, at 10:05 AM, Robin Sommer ro...@icir.org wrote:
So one thing to keep in mind is that not many people will ever write
code using this; it's just for function hooks, and I imagine their use
will be limited. I'm personaly still leaning towards the pair, but
it's not a big
[
https://bro-tracker.atlassian.net/browse/BIT-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=18408#comment-18408
]
Robin Sommer commented on BIT-1270:
---
Yes, passing by value is the main part. Though still,
[
https://bro-tracker.atlassian.net/browse/BIT-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=18410#comment-18410
]
Jon Siwek commented on BIT-1270:
Whether to pass by value and whether to use ValWrapper vs.
Yeah, I think we're in agreement that pass-by-value would be a better
method here.
To be honest, I'm not sure if expecting a user to return a
std::pairbool, Val* from a plugin function hook is more or less
obvious than an explicit wrapper. One thing that makes this a little
less obvious to
On Oct 17, 2014, at 1:34 PM, Gilbert Clark gc355...@ohio.edu wrote:
To be honest, I'm not sure if expecting a user to return a
std::pairbool, Val* from a plugin function hook is more or less
obvious than an explicit wrapper. One thing that makes this a little
less obvious to me is that
[
https://bro-tracker.atlassian.net/browse/BIT-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robin Sommer updated BIT-1270:
--
Status: Open (was: Merge Request)
topic/gilbert/plugin-api-tweak
--
[
https://bro-tracker.atlassian.net/browse/BIT-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=18300#comment-18300
]
Robin Sommer commented on BIT-1270:
---
A few comments:
- instead if using a separate wrapper
[
https://bro-tracker.atlassian.net/browse/BIT-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=18301#comment-18301
]
gclark commented on BIT-1270:
-
* Only bad thing about a tuple is that the members would no longer
[
https://bro-tracker.atlassian.net/browse/BIT-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
gclark updated BIT-1270:
Status: Merge Request (was: Open)
topic/gilbert/plugin-api-tweak
--
15 matches
Mail list logo
