Re: [Bro-Dev] Testing and Docs for Packages

2017-01-20 Thread Johanna Amann
On Tue, Jan 17, 2017 at 04:01:19AM +, Siwek, Jon wrote: > > I actually think it would be neat to do this isolated, especially given > > that this enables testing before installing. > > Not sure I follow. Can you explain further? Sorry - what I meant is that the tests can run before the

Re: [Bro-Dev] Testing and Docs for Packages

2017-01-20 Thread Robin Sommer
On Thu, Jan 19, 2017 at 17:38 +, you wrote: > 1) separate testing environment for each package > 2) single testing environment for all packages > Neither seems great. I guess I plan to do (1) since it is easier on > package authors and less likely to waste users time looking into >

Re: [Bro-Dev] Testing and Docs for Packages

2017-01-19 Thread Siwek, Jon
> On Jan 18, 2017, at 10:28 AM, Robin Sommer wrote: > > I also think it would be quite useful to test packages before > installing them Maybe I’m not so much questioning whether to run tests before or after installation, but rather if the testing sandbox should include

Re: [Bro-Dev] Testing and Docs for Packages

2017-01-18 Thread Robin Sommer
I also think it would be quite useful to test packages before installing them, that gives a chance to catch problems before changing anything (including things like: missing/broken/wrong dependencies; lack of something OS-specific the package needs (say, it's a Linux-only plugin); generally things

Re: [Bro-Dev] Testing and Docs for Packages

2017-01-16 Thread Siwek, Jon
>> 1) Add `bro-pkg test ` command. > > Might it also make sense to just run the test on installation, before the > package is actually installed, to see if it works on the environment of > the user? Yes, I like that idea. (I’d also want a flag or config option to opt-out of that behavior). >

Re: [Bro-Dev] Testing and Docs for Packages

2017-01-16 Thread Jan Grashöfer
> Yes, seems useful. I’d do it like: > > 1) Add `bro-pkg test ` command. > 2) Add “test_command” field to bro-pkg.meta > > The “test_command” is more general than “test_dir" — the command could just > `cd test_dir` if needed and there’s no other reason bro-pkg needs to know the > dir where

Re: [Bro-Dev] Testing and Docs for Packages

2017-01-16 Thread Siwek, Jon
> On Jan 15, 2017, at 4:49 PM, Jan Grashöfer wrote: > > In general I think, making test cases available for users of a package > could be quite helpful. Further, I think we have also already mentioned > the possibility of compatibility checking regarding the installed

[Bro-Dev] Testing and Docs for Packages

2017-01-15 Thread Jan Grashöfer
Hi all, building some small packages and playing around with a package for the af_packet plugin (https://github.com/J-Gras/bro-af_packet-plugin), I came across a question: How to deal with testing? For the intel-extensions package (https://github.com/J-Gras/intel-extensions) I adapted some