Re: regression in autoconf-2.62 vs. 2.61

2008-07-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Stepan Kasal on 6/18/2008 10:17 AM: [wow - a month in my inbox] | | I tried to write something, and I ended up with a different version. | I have also removed a trivial example; IMHO, it does not belong to | this node and I guess the in

Re: regression in autoconf-2.62 vs. 2.61

2008-06-19 Thread Ralf Wildenhues
* Stepan Kasal wrote on Thu, Jun 19, 2008 at 05:12:56AM CEST: > On Wed, Jun 18, 2008 at 09:13:00PM +0200, Ralf Wildenhues wrote: > > > Pay attention that @samp{#undef} is in the first column, and there is > > > +nothing after @samp{HAVE_UNISTD_H}, not even white space. > > > > FWIW, the current c

Re: regression in autoconf-2.62 vs. 2.61

2008-06-18 Thread Stepan Kasal
Hello Ralf, On Wed, Jun 18, 2008 at 09:13:00PM +0200, Ralf Wildenhues wrote: > > Pay attention that @samp{#undef} is in the first column, and there is > > +nothing after @samp{HAVE_UNISTD_H}, not even white space. > > FWIW, the current code works fine with white space before '#' and > between it

Re: regression in autoconf-2.62 vs. 2.61

2008-06-18 Thread Ralf Wildenhues
Hi Stepan, * Stepan Kasal wrote on Wed, Jun 18, 2008 at 06:17:01PM CEST: > --- a/doc/autoconf.texi > +++ b/doc/autoconf.texi > @@ -3095,28 +3094,40 @@ commented out (in case the system predefines that > symbol). > @end example > > Pay attention that @samp{#undef} is in the first column, and

Re: regression in autoconf-2.62 vs. 2.61

2008-06-18 Thread Stepan Kasal
Hello Eric, On Tue, Jun 17, 2008 at 09:20:52PM -0600, Eric Blake wrote: > | `` > | Generally speaking, all #define and #undef directives in the header > | template may be modified by config.status, under some circumstances. > | Consequently, if you need to define or undefine a symbol under some >

Re: regression in autoconf-2.62 vs. 2.61

2008-06-17 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Stepan Kasal on 6/5/2008 10:28 AM: | Hello, Hi Stepan, Ralf, | | I'd like to propose a solution, please speak up if you are not | satisfied with it. (If we reach an agreement, I'm willing to prepare | a patch later.) Well, now that Ra

Re: regression in autoconf-2.62 vs. 2.61

2008-06-16 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Ralf Wildenhues on 6/16/2008 11:46 AM: | Hello, and sorry for the delay, Hello Ralf, and better late than never ;) | | I'm punting. The '#define header templates' test already requires that | #undef macro additional-stuff | | removes

Re: regression in autoconf-2.62 vs. 2.61

2008-06-16 Thread Ralf Wildenhues
Hello, and sorry for the delay, * Eric Blake wrote on Thu, Jun 05, 2008 at 11:37:01PM CEST: > Stepan Kasal redhat.com> writes: > > > First, let me state that, strictly speaking, this is not a > > regression. The Autoconf manual says that the #undef line cannot > > contain anything after the sym

Re: regression in autoconf-2.62 vs. 2.61

2008-06-05 Thread Eric Blake
Stepan Kasal redhat.com> writes: > First, let me state that, strictly speaking, this is not a > regression. The Autoconf manual says that the #undef line cannot > contain anything after the symbol. And in that case, all versions > tested by Ralf do the same. I agree that whether or not we cha

Re: regression in autoconf-2.62 vs. 2.61

2008-06-05 Thread Stepan Kasal
Hello, I'd like to propose a solution, please speak up if you are not satisfied with it. (If we reach an agreement, I'm willing to prepare a patch later.) First, let me state that, strictly speaking, this is not a regression. The Autoconf manual says that the #undef line cannot contain anything

Re: regression in autoconf-2.62 vs. 2.61

2008-06-04 Thread Ralf Wildenhues
Hi Eric, thanks for the quick review. * Eric Blake wrote on Wed, Jun 04, 2008 at 10:19:40PM CEST: > Ralf Wildenhues gmx.de> writes: > > # Replace #undef with comments. This is necessary, for example, > > # in the case of _POSIX_SOURCE, which is predefined and required > > # on some

Re: regression in autoconf-2.62 vs. 2.61

2008-06-04 Thread Eric Blake
Ralf Wildenhues gmx.de> writes: > > Hello Karsten, > > Thanks for the bug report. Yes, thanks for bringing it to our attention. > > > https://bugzilla.redhat.com/show_bug.cgi?id=449245 It looks like the redhat bug was closed as not-a-bug, but I agree with Ralf's analysis that a simple pat

Re: regression in autoconf-2.62 vs. 2.61

2008-06-04 Thread Ralf Wildenhues
Hello Karsten, Thanks for the bug report. * Karsten Hopp wrote on Wed, Jun 04, 2008 at 05:00:49PM CEST: > (second attempt, first one got stuck in the maintainer queue) Usually there is some latency due to the human involved in the first-time moderation, and/or the system involved in spam filteri

regression in autoconf-2.62 vs. 2.61

2008-06-04 Thread Karsten Hopp
https://bugzilla.redhat.com/show_bug.cgi?id=449245 lists two issues after updating autoconf in Fedora to 2.62. - same line comments are now really broken where they worked before even though this was discouraged. The documentation should probably reflect this new behaviour if this breakage

regression in autoconf-2.62 vs. 2.61

2008-06-04 Thread Karsten Hopp
(second attempt, first one got stuck in the maintainer queue) https://bugzilla.redhat.com/show_bug.cgi?id=449245 lists two issues after updating autoconf in Fedora to 2.62. - same line comments are now really broken where they worked before even though this was discouraged. The documentation