Re: [PATCH] Fix sloppy tests for silent rules

2010-07-05 Thread Ludovic Courtès
Hi, Stefano Lattarini writes: > At Monday 05 July 2010, Ludovic Courtès wrote: > >> I noticed on NixOS GNU/Linux that silent*.test would randomly fail (see >> .) The reason is that these tests >> would fail if “mv” is found in the standard output of ‘make’,

Re: [PATCH] Fix sloppy tests for silent rules

2010-07-05 Thread Stefano Lattarini
At Monday 05 July 2010, Ludovic Courtès wrote: > I noticed on NixOS GNU/Linux that silent*.test would randomly fail (see > .) The reason is that these tests > would fail if “mv” is found in the standard output of ‘make’, but the > random build directory names

Re: [PATCH] Fix sloppy tests for silent rules

2010-07-05 Thread Ludovic Courtès
Oops, here’s the right patch: Make these tests more robust. Previously, they would fail if the name of the build directory contains `mv', which can very well happen with Nix. --- automake-1.11.1/tests/silent.test 2009-12-08 19:02:32.0 +0100 +++ automake-1.11.1/tests/silent.test 2010-07-0

[PATCH] Fix sloppy tests for silent rules

2010-07-05 Thread Ludovic Courtès
Hello, I noticed on NixOS GNU/Linux that silent*.test would randomly fail (see .) The reason is that these tests would fail if “mv” is found in the standard output of ‘make’, but the random build directory names used by Nix could very well contain this string.