Re: coding standards

L A Walsh wrote: 1) I see no benefit in the use of extra braces. It diminishes > comprehension in this case. really? to me the braces make the code easier to read, in the context of the surrounding function. they clarify the intention. *if (THE VALUE IS OK) {* *USE THE VALUE* *

Re: coding standards

don fong wrote: my patch (form (A)): -report_error (_("%s: parameter null or not set"), name); +{ + if (check_nullness) + report_error (_("%s: parameter null or not set"), name); + else + report_error (_("%s: parameter is not set"), name); +} the new

Re: coding standards

On Tue, Mar 06, 2018 at 05:15:36PM +0800, Clark Wang wrote: > I don't know much about bash's source code so I cannot comment much. And > this kind of arguments are quite opinion based which are not simple yes/no > questions. That's precisely what a "coding standard" is -- an opinion. If one

Re: coding standards

I don't know much about bash's source code so I cannot comment much. And this kind of arguments are quite opinion based which are not simple yes/no questions. And I believe one thing - the world is not perfect. :) -clark On Tue, Mar 6, 2018 at 8:26 AM, don fong wrote: > Clark,