Re: Bug report in ubuntu 24.04

This isn't a bug in bash. You might find some of the suggestions in https://github.com/rstudio/rstudio/issues/8539 helpful. On Sun, Oct 6, 2024, 18:02 Luis Vazquez de Lara via Bug reports for the GNU Bourne Again SHell wrote: > Reporting a bug after in RStudio terminal with the aliases > > Dr. L

[PATCH] help -d: print loadable builtins correctly

help -d output assumes that long_doc[0] includes a newline, which is not the case for loadable builtins: $ enable ln rm $ help -d ln rm ln - Link files.rm - Remove files --- builtins/help.def | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/builtins/help

[PATCH] BASH_SOURCE_FULLPATH_DEFAULT fixup

Fix typo in configure.ac causing: src/bash/configure: 3892: test: =: unexpected operator Update shopt reset code to use new define. --- builtins/shopt.def | 2 +- configure.ac | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/builtins/shopt.def b/builtins/shopt

[PATCH] braces: avoid signed overflow

INTMAX_MAX=9223372036854775807 eval ": {$((INTMAX_MAX-1))..$((INTMAX_MAX))}" braces.c:447:9: runtime error: signed integer overflow: 9223372036854775807 + 1 cannot be represented in type 'intmax_t' (aka 'long') --- braces.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/b

Re: [PATCH] Correct error message when using -n and -o ignoreeof in interactive mode

On Wed, Aug 21, 2024, 11:27 Chet Ramey wrote: > On 8/19/24 9:52 AM, Ángel wrote: > > On 2024-08-18 at 11:21 +0700, Robert Elz wrote: > >> Interactive shells with -n (noexec) set are pointless > > > > The man page states: > >>-n Read commands but do not execute them. This may

[PATCH] bash_source_fullpath: add to reset_shopt_options

This was actually caught by the test suite --- builtins/shopt.def | 1 + tests/shopt.right | 4 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/builtins/shopt.def b/builtins/shopt.def index 67bc0c22..37fda11e 100644 --- a/builtins/shopt.def +++ b/builtins/shopt.def @@ -357,6 +3

Another redisplay issue in single-byte locales

In a single-byte locale, if the prompt is wider than the screen width and contains invisible characters on the last line, and the input line is also wider than the screen width, redisplay gets messed up: printf -v s '%*s' "$COLUMNS" PS1=$s'%\[\e[0m\]' LC_ALL=C bash --norc -in <<< $s$'X\caY

Re: printf inconsistent results for %.0f

On Mon, Aug 12, 2024, 11:04 Chet Ramey wrote: > My question is why the (admittedly old) gnulib replacement strtod/strtold > is messing things up. > Looks like printf(3) gets called with a `Lf' conversation specifier and a double argument. diff --git a/builtins/printf.def b/builtins/printf.def i

[PATCH] read: unsigned char delim issues

The new read_mbchar code is missing an (unsigned char) cast, causing an invalid continuation byte >0x7F to fail to be recognized as a delimiter on platforms where char is signed. $ printf '\317_' | { read -d _; echo "${REPLY@Q}"; } $'\317' $ printf '\317\360_' | { read -d $'\360'; echo

termios.h not included if sys/ioctl.h provides struct winsize

On e.g. Alpine Linux, the following are set by configure: bash_cv_struct_winsize_ioctl='yes' bash_cv_struct_winsize_termios='yes' bash_cv_struct_winsize_header='ioctl_h' ac_cv_func_tcgetwinsize='yes' and so config.h ends up with: #define STRUCT_WINSIZE_IN_SYS_IOCTL 1 /* #

Re: whats wrong , exit code 11 on android termux

On Tue, Aug 6, 2024, 14:19 alex xmb sw ratchev wrote: > ~ $ alias tm='timemark+=( $EPOCHREALTIME )' > ~ $ tm > > [Process completed (signal 11) - press Enter] > I believe this was reported in https://lists.gnu.org/archive/html/bug-bash/2023-05/msg00146.html and fixed in https://git.savannah.gnu.

[PATCH] tests: printf: provide explicit TZ start/end

POSIX says about the TZ variable: If the dst field is specified and the rule field is not, it is implementation-defined when the changes to and from DST occur. musl seems to interpret `TZ=EST5EDT` as having DST always in effect, causing the tests that rely on the glibc behavior (of defaul

Re: [PATCH] cond expr: cleanup on errors

On Mon, Jun 3, 2024 at 3:53 PM Chet Ramey wrote: > > On 5/31/24 5:07 PM, Grisha Levit wrote: > > Two minor leak fixes for conditional command error conditions: > > > > If a WORD token is read when COND_AND, COND_OR, COND_END, or a binary > > operator are expect

Re: [PATCH] cond expr: cleanup on errors

On Mon, Jun 3, 2024 at 3:53 PM Chet Ramey wrote: > > On 5/31/24 5:07 PM, Grisha Levit wrote: > > Two minor leak fixes for conditional command error conditions: > > > > If a WORD token is read when COND_AND, COND_OR, COND_END, or a binary > > operator are expect

[PATCH] exec: free args on failed exec

The comment describing why this wasn't done has been there since the start of the repo's history and AFAICT it is not accurate anymore, as shell_execve only calls realloc when it's going to longjmp rather than return. Fixes leak in bash -O execfail -c 'exec /; :' --- builtins/exec.def | 4 --

[PATCH] expand_word_internal: fix leak with W_NOSPLIT2

Free temporary list allocated when exapnding `$@' in bash -c 'IFS=:; : ${_+$@}' _ X --- subst.c | 1 + 1 file changed, 1 insertion(+) diff --git a/subst.c b/subst.c index 3faa4068..c56d2434 100644 --- a/subst.c +++ b/subst.c @@ -12144,6 +12144,7 @@ finished_with_string: retu

[PATCH] coproc: do not leak name

When a named coproc is created, the name string and associated WORD_DESC are leaked. --- parse.y | 2 ++ 1 file changed, 2 insertions(+) diff --git a/parse.y b/parse.y index d39d6737..fe5038be 100644 --- a/parse.y +++ b/parse.y @@ -1103,6 +1103,7 @@ coproc: COPROC shell_command

[PATCH] cond expr: cleanup on errors

Two minor leak fixes for conditional command error conditions: If a WORD token is read when COND_AND, COND_OR, COND_END, or a binary operator are expected, the allocated WORD_DESC is leaked. If a conditional command has a syntax error, the allocated COMMAND is leaked. --- parse.y | 14 ++

[PATCH] bind_assoc_variable: free key if cannot assign

Avoid leaking expansion of `x' in `declare -Ar A; A[x]=' --- arrayfunc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arrayfunc.c b/arrayfunc.c index e85ba6e5..aaa1963c 100644 --- a/arrayfunc.c +++ b/arrayfunc.c @@ -302,6 +302,7 @@ bind_assoc_variable (SHELL_VAR *entry, const char *name, c

[PATCH] read: free ifs_chars

Avoid leaking ifs_chars on more return paths. --- builtins/read.def | 16 1 file changed, 16 insertions(+) diff --git a/builtins/read.def b/builtins/read.def index 37328efc..69a1ef4c 100644 --- a/builtins/read.def +++ b/builtins/read.def @@ -635,6 +635,8 @@ read_builtin (WORD_LIS

[PATCH] readstr: do not clear undo list

The undo command fails if invoked via execute-named-command on a line from the history list: $ bash --norc -in <<< $'A\n\cPB\c_C' bash-5.3$ A bash-5.3$ AC $ bash --norc -in <<< $'A\n\cPB\exundo\nC' bash-5.3$ A bash-5.3$ ABC AFAICT the rl_maybe_replace_line in _rl_readstr_

compute_lcd_of_matches w/ mismatched upper/lowercase byte counts

This requires case-insensitive completion of two+ words where the the prefix in a word contains the single-byte lowercase form of the multi- byte character occuring in the same position in an earlier word. The words here start consist of one of the following followed by `-': U+212A KELVIN SIG

Re: segmentation fault after interrupting function that uses "time"

On Thu, May 23, 2024 at 3:55 PM Chet Ramey wrote: > > On 5/23/24 7:43 AM, Michael Maurer wrote: > > > Bash Version: 5.2 > > Patch Level: 15 > > Release Status: release > > > > Description: > > Calling a function that itself uses the keyword "time" to call > > another function that performs

Re: [PATCH] rl_change_case: skip over invalid mbchars

On Thu, May 23, 2024 at 4:11 PM Chet Ramey wrote: > > On 5/23/24 3:25 PM, Grisha Levit wrote: > > On Thu, May 23, 2024 at 10:25 AM Chet Ramey wrote: > >> > >> On 5/21/24 2:42 PM, Grisha Levit wrote: > >>> Avoid using (size_t)-1 as an offset. > >

Re: [PATCH] rl_change_case: skip over invalid mbchars

On Thu, May 23, 2024 at 10:25 AM Chet Ramey wrote: > > On 5/21/24 2:42 PM, Grisha Levit wrote: > > Avoid using (size_t)-1 as an offset. > > I can't reproduce this on macOS. Where is the code that's using -1 as an > offset? The loop in rl_change_case does the follo

[PATCH] dynamic-complete-history: avoid null ptr qsort UB

$ HISTFILE= bash --norc -in <<< $'#\n#\e\t' bashline.c:3720:16: runtime error: null pointer passed as argument 1, which is declared to never be null /usr/include/stdlib.h:971:30: note: nonnull attribute specified here SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior bashline.c:3720:16 ---

[PATCH] spell-correct-word: avoid inf loop with neg arg

bash --norc -in <<< $'A \e-\cXs' --- bashline.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bashline.c b/bashline.c index 528f56e0..0a4e280e 100644 --- a/bashline.c +++ b/bashline.c @@ -1336,6 +1336,9 @@ bash_spell_correct_shellword (int count, int key) int wbeg, wend; char *text

[PATCH] spell-correct-word: fix small leak

Avoid leak when spell-correcting an empty line. --- bashline.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/bashline.c b/bashline.c index 525d065a..528f56e0 100644 --- a/bashline.c +++ b/bashline.c @@ -1348,7 +1348,10 @@ bash_spell_correct_shellword (int count, int key)

[PATCH] rl_change_case: skip over invalid mbchars

Avoid using (size_t)-1 as an offset. Also, not sure it makes sense to change the case of an invalid byte cast to (wchar_t). $ bash --norc -in <<< $'\300\e-1\eL' lib/readline/text.c:1544:26: runtime error: addition of unsigned offset to 0x51100680 overflowed to 0x5110067f ERROR: AddressSa

[PATCH] bashline: small leaks

- free directory_part when completing command words like `~/bin/' - free contents of matches when completing command words in old-style command substitutions --- bashline.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/bashline.c b/bashline.c index b638e001..525d065a

[PATCH] execute-named-command: fix small leaks

- free command if it is the empty string - free command before calling bound function, in case bound function does not return, like rl_abort --- lib/readline/text.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/readline/text.c b/lib/readline/text.c index c5281efe

[PATCH] spell.c: uninitialized value in mindist

./bash --norc -in <<<$'XX\cXs' bash-5.3$ XX==34016==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0xaafbbb80 in mindist /home/vm/src/bash/local/lib/sh/spell.c:138:22 #1 0xaafbb468 in spname /home/vm/src/bash/local/lib/sh/spell.c:90:11 #2 0xaafbbe78 in dirspell /hom

Re: [PATCH] bracketed paste unterminated buffer

On Mon, May 20, 2024, 10:52 Chet Ramey wrote: > On 5/20/24 10:42 AM, Grisha Levit wrote: > > If bracketed paste input terminates prior to the paste end sequence, > > How would this happen? The terminal emulator (or whatever) performing > the paste guarantees it. > Maybe ove

[PATCH] bracketed paste unterminated buffer

If bracketed paste input terminates prior to the paste end sequence, the buffer passed to rl_insert_text never gets its null termination. $ bash-asan --norc -in <<<$'\e[200~X' ==15989==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x006167e51260 at pc 0x007e690b5374 bp 0x007ff50ab620 s

Re: ${var/\#} no longer works

On Sun, May 19, 2024, 14:05 konsolebox wrote: > Here's an output from devel branch bash and 5.2.26: > > $ bash-9 -c 'echo "$BASH_VERSION"; x="abc#xyz"; echo "${x/\#}"' > 5.3.0(1)-alpha > abc#xyz > $ bash-5.2.26 -c 'echo "$BASH_VERSION"; x="abc#xyz"; echo "${x/\#}"' > 5.2.26(1)-release > abcxy

Re: [PATCH] globsort: handle int overflow in cmp functions

On Fri, May 17, 2024 at 3:06 PM Chet Ramey wrote: > > On 5/17/24 12:57 PM, Grisha Levit wrote: > > The current cmp implementation for size and blocks subtracts the two > > values and returns the difference as an int. This subtraction can > > overflow, and the returned i

[PATCH] globsort: handle int overflow in cmp functions

The current cmp implementation for size and blocks subtracts the two values and returns the difference as an int. This subtraction can overflow, and the returned int can end up having the wrong sign. This also makes the qsort comparison function non-transitive. (Some interesting discussion on that

[PATCH] fdopen in read -e -u N

Looks like `read -e -u N' creates (and leaks) a new stream for fd N. If a second `read' tries to fdopen the same fd once more, Android's FDSAN (on and enforcing defualt) causes the process to abort: $ bash -c 'read -eu3; read -eu3' 3<&0 fdsan: failed to exchange ownership of file descriptor: fd 3

[PATCH] use newly loaded compspec in more cases

If a completion function installs a new compspec and returns 124, and the new compspec is for something other than the exact name currently being completed (i.e. a new default compspec, or a compspec for the basename of a command being completed that includes a slash), the newly installed compspec

[PATCH] builtins build with -std=

When building with glibc and an -std= arg in CFLAGS, asort and cat fail to build since sigsetjmp is guarded by _POSIX_C_SOURCE In file included from bashjmp.h:24, from shell.h:25, from examples/loadables/cat.c:30: include/posixjmp.h:29:25: error: unknown type name

build failure without system extension macros

Since 9c430f6b changed some files to no longer include config.h, building with glibc and an -std= in CFLAGS fails because getopt, used in support/bashversion.c and mksyntax.c, is guarded by _POSIX_C_SOURCE >= 2 || _XOPEN_SOURCE support/bashversion.c:69:17: warning: implicit declaration of function

[PATCH] tests/cond-regexp3.sub: avoid ERE UB

This test fails on systems with recent-ish BSD regex libs, where a backslash followed by an alphabetic chatacter now throws REG_EESCAPE. See https://reviews.freebsd.org/D10510 --- tests/cond-regexp3.sub | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/cond-regexp3.sub b/t

Re: [5.3-alpha] ">& /some/file" would fail when /some/file already exists

On Thu, Apr 25, 2024, 23:03 Oğuz wrote: > On Fri, Apr 26, 2024 at 1:17 AM Grisha Levit > wrote: > > Actually, I see this on Ubuntu 22.04 but not on macOS. > On Linux, O_EXCL and RX_EXPANDED (a flag used by bash to signal that > the redirection word is already expanded) has

Re: [5.3-alpha] ">& /some/file" would fail when /some/file already exists

On Thu, Apr 25, 2024 at 6:05 PM Grisha Levit wrote: > > On Thu, Apr 25, 2024, 14:55 Chet Ramey wrote: >> >> On 4/25/24 12:18 PM, Clark Wang wrote: >> > (I'm using the "devel" branch as the "bash-5.3-testing" branch failed >> >

Re: [5.3-alpha] ">& /some/file" would fail when /some/file already exists

On Thu, Apr 25, 2024, 14:55 Chet Ramey wrote: > On 4/25/24 12:18 PM, Clark Wang wrote: > > (I'm using the "devel" branch as the "bash-5.3-testing" branch failed > > to build for me. HEAD: 8c8daff1e3661c) > > > > To reproduce: > > > > $ bash53 --norc > > bash53-5.3# touch /tmp/file > > bash53-5.3#

Re: 5.3-alpha: less readable output when set -x

On Wed, Apr 24, 2024 at 11:35 AM wrote: > > hello > > Apologies if I am missing some blatant point here > > I have noticed a difference in behavior of bash-5.2.26 and > bash-5.3-alpha which isn't a problem of correctness, but may be wasn't > intentional(?) This is from https://lists.gnu.org/archi

Re: install-headers stdckdint.h error

On Fri, Mar 29, 2024, 09:37 Chet Ramey wrote: > On 3/28/24 9:54 PM, Grisha Levit wrote: > > The addition of stdckdint.h to CREATED_HEADERS in Makefile.in leads to > > an error when installing loadable builtins on platforms that provide > > the header: > > Thanks for th

install-headers stdckdint.h error

The addition of stdckdint.h to CREATED_HEADERS in Makefile.in leads to an error when installing loadable builtins on platforms that provide the header: install: cannot stat '/tmp/bash/stdckdint.h': No such file or directory make[2]: *** [Makefile:903: install-headers] Error 1 make[2]: Leaving dire

funsub in PS2

Having funsubs in PS2 seems to cause input tokens that are split across lines to be partially replaced with the last token of the last funsub to be parsed while expanding the prompt string. $ PS2='${ : ; }> ' $ printf '[%s]\n' ab\ > cd [XXcd]

[PATCH] fix cmd and hist nums in ${var@P} inside $PS[012]

When \# or \! is decoded in a ${var@P} expansion embedded in a prompt string, the value can be off by one from that of the same sequence embedded directly in the prompt string. $ H='\!' $ PS1='(\!:${H@P}) $' (3:2 501:500) $ * parse.y - decode_prompt_string: accept new int flag to sign

Re: [PATCH] retry opening startup files on EINTR

On Tue, Feb 20, 2024 at 9:18 AM Chet Ramey wrote: > > Well, depending on when the terminal emulator sends the SIGWINCH, this is > probably a bug in Dropbox or the File Provider code. Bash installs its > SIGWINCH handler with SA_RESTART, and the default disposition is to > discard, so even if a SIG

Re: [PATCH] retry opening startup files on EINTR

On Tue, Feb 20, 2024 at 4:35 AM Grisha Levit wrote: > > Though a similar test shows that the Readline part of the patch is wrong, > and I'm not sure how to solve it, at least without changing existing > applications' behavior (and requiring signal setup to happen bef

Re: [PATCH] retry opening startup files on EINTR

On Mon, Feb 19, 2024 at 5:10 PM Chet Ramey wrote: > > On 2/7/24 1:33 AM, Grisha Levit wrote: > > I have some dotfiles symlinked to storage backed by a macOS File > > Provider extension (e.g. Dropbox): > > > > $ realpath ~/.bash_profile > > /User

Re: [PATCH] use unlocked stdio functions

On Sat, Feb 17, 2024, 12:29 Chet Ramey wrote: > On 2/16/24 9:37 PM, Grisha Levit wrote: > > After this change, `make -C examples/loadables others` fails building > > necho.o with: > > > > use of undeclared identifier 'fflush_unlocked' > > I can&#

Re: $* within a here-document puts space instead of the first IFS char.

On Fri, Feb 16, 2024 at 9:02 PM Damien ISSANCHOU wrote: > When expanding $* within a here-document, bash puts a space between > each positional parameters while I would expect it to put the first > character of the IFS variable (if it contains at least one character) as > per POSIX.1-2017. F

Re: Bash 5.1: Make shell_script_filename available to startup files

On Fri, Feb 16, 2024, 16:17 Marc Aurèle La France wrote: > > On Mon, 2021-Feb-01, Marc Aurèle La France wrote: > > > Currently, only the script's arguments are passed as positional > > parameters. For compatibility reasons, $0 cannot be used to also pass the > > script's filename, so I'm creating

Re: [PATCH] use unlocked stdio functions

After this change, `make -C examples/loadables others` fails building necho.o with: use of undeclared identifier 'fflush_unlocked' I checked other object files to make sure the expected symbols are used and they were, except for the loadable pushd. Also added the dependency where needed in M

Re: It is possible to remove the readonly attribute from {BASH, SHELL}OPTS

On Fri, Feb 16, 2024 at 11:32 AM Chet Ramey wrote: > > On 2/13/24 12:41 PM, Grisha Levit wrote: > > On Wed, Jan 31, 2024, 14:10 Chet Ramey > <mailto:chet.ra...@case.edu>> wrote: > > > > Well, is this a "my arm hurts when I do this" problem

Re: It is possible to remove the readonly attribute from {BASH, SHELL}OPTS

On Wed, Jan 31, 2024, 14:10 Chet Ramey wrote: > Well, is this a "my arm hurts when I do this" problem, or should bash > restrict the types of attributes that can be set on readonly variables? > For the attributes that only affect future assignments ([iluc]), I think think it makes sense to eithe

[PATCH] rltech.texi: missing @end deftypevar

Building readline.info fails in the devel branch: $ make readline.info rltech.texi:2399: @node seen before @end deftypevar make: *** [readline.info] Error 1 --- lib/readline/doc/rltech.texi | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/readline/doc/rltech.texi b/lib/readlin

[PATCH] expand_declaration_argument: handle mixed on/off opts

When assigning a variable as part of expanding a compound assignment argument, any [aAgGiIluc] options are treated as either all being on or all being off: $ unset X; declare -a +i X=(2+2); declare -p X declare -a X=([0]="4") $ unset X; declare +i -u X=(foo); declare -p X declare

Re: declare -A +A

On Mon, Feb 12, 2024 at 4:13 PM Chet Ramey wrote: > > On 2/7/24 2:23 AM, Grisha Levit wrote: > > If a single declare command both sets and unsets the array or assoc > > attribute for an existing scalar variable, the `value' member of the > > SHELL_VAR is assigne

Re: [PATCH] printf6.sub: set LC_ALL

On Wed, Feb 7, 2024, 14:45 Kerin Millar wrote: > On Wed, 7 Feb 2024 13:59:47 -0500 > Grisha Levit wrote: > > > +#LC_ALL=en_US.UTF-8 > > Is this not merely adding a comment? > Sorry you're right, made the patch after commenting my change out to confirm it was needed. >

[PATCH] printf6.sub: set LC_ALL

The tests in printf6.sub fail if `make check' is executed in the C locale. diff --git a/tests/printf6.sub b/tests/printf6.sub index fbacd4d5..382943c7 100644 --- a/tests/printf6.sub +++ b/tests/printf6.sub @@ -11,6 +11,8 @@ # You should have received a copy of the GNU General Public License #

declare -A +A

If a single declare command both sets and unsets the array or assoc attribute for an existing scalar variable, the `value' member of the SHELL_VAR is assigned an ARRAY* or HASH_TABLE* as appropriate, but later ends up treated as a char*: $ bash-asan -c 'X=Y; declare -A +A X; declare -p X'

declare -Aa var

If given both the -a and -A flags and an existing scalar variable, declare will assign both attributes to the variable: $ V=X; declare -Aa V; echo $? 0 $ echo ${V@a} aA $ (declare -p V) Segmentation fault: 11

[PATCH] ASS_NOEVAL for BASHOPTS and SHELLOPTS

(Prompted by the report from Emanuele Torre in [1]) The value of currently_executing_command is garbage when there is an error during assignment when popping the variable context: $ bash -c 'declare -i SHELLOPTS; f() { local -; set -f; }; f' |& cat -v bash: line 1: M-`^WM-R^N^\{: braceexp

[PATCH] retry opening startup files on EINTR

I have some dotfiles symlinked to storage backed by a macOS File Provider extension (e.g. Dropbox): $ realpath ~/.bash_profile /Users/levit/Library/CloudStorage/Dropbox/profile/.bash_profile This normally works fine, except when my terminal emulator (tested both Terminal.app and iTerm) re

[PATCH] use unlocked stdio functions

Bash makes many calls to stdio functions that may have unlocked_stdio(3) equivalents. Since the locking functionality provided by the regular versions is only useful in multi-threaded applications, it probably makes sense for Bash to use the *_unlocked versions where available. E.g. in situations

Re: [PATCH] printf: more error handling

On Sat, Feb 3, 2024 at 1:05 PM Chet Ramey wrote: > > On 2/2/24 6:33 PM, Grisha Levit wrote: > > Is it necessary to check the error indicator if printf(3) just had a non- > > negative return? > > I think printf is allowed to set the error flag that ferror checks even if >

Re: [PATCH] printf: more error handling

On Thu, Feb 1, 2024 at 7:41 PM Chet Ramey wrote: > > On 1/22/24 9:44 PM, Grisha Levit wrote: > > The size of the buffer used for printf -v is tracked in an int but this > > can overflow since the buffer can be built up by multiple vsnprintf(3) > > calls, each of which

heap-use-after-free in executing_line_number

If currently_executing_command was a subshell, it can end up freed by the time executing_line_number checks it. $ bash-asan -c '${ (:); }/' = ERROR: AddressSanitizer: heap-use-after-free on address 0x000106208a40 at pc 0x000102c8bf38

[PATCH] printf: more error handling

The size of the buffer used for printf -v is tracked in an int but this can overflow since the buffer can be built up by multiple vsnprintf(3) calls, each of which can append up to INT_MAX bytes to the buffer: $ INT_MAX=$(getconf INT_MAX) $ printf -v VAR "%$((INT_MAX-1))s%$((INT_MAX-1))s"

Re: ./script doesn't work in completion function

On Mon, Jan 22, 2024, 01:54 Martin D Kealey wrote: > You seem to have created an invalid executable. It seems that scripts > without a #! can only be run with help from the debugger library; That's not quite what happens. These scripts get executed by forking the current bash process (without e

Re: Bash Bug - Incorrect Printing of Escaped Characters

On Tue, Jan 16, 2024, 11:01 Seth Sabar wrote: > Are you planning on releasing a patch for this? If you'd like me to try to > prepare a patch, I'd appreciate some guidance around the various > dequote_... functions in subst.c. Thanks! > Hi Seth, Chet has committed a fix for this in the devel bran

Re: Bash 5.2.21 segfaults when I feed it garbage

On Fri, Jan 12, 2024, 15:29 Chet Ramey wrote: > On 1/10/24 2:06 PM, Grisha Levit wrote: > > > Rewriting the original report as: > > > > bash <<<'((X=([))' > > > > even after the last fix, there's still a similar issue with inp

Re: bash-4-2 issue

On Wed, Jan 10, 2024 at 5:33 PM Grisha Levit wrote: > I'm not sure this is fixed. In all versions, including 4.2 [...] > > $ bash -m -c 'trap /usr/bin/true DEBUG; :|:' > bash: child setpgid (49581 to 49579): Operation not permitted Correction, versions prior to

Re: bash-4-2 issue

On Mon, Jan 8, 2024 at 7:04 AM Sam Kappen via Bug reports for the GNU Bourne Again SHell wrote: > We see that bash throws the "Operation not permitted" error when doing > chained pipe operation > along with a debug trap. > > We set a debug trap here "my_debug" to save the terminal commands entered

Re: Bash 5.2.0: Memory leak with $(

On Mon, Jan 8, 2024, 12:26 wrote: > Do any of the other six patches in that report also apply to Bash 5.2? > Yes, all but the one for the `kv' builtin which did not exist yet. See attached. > From 711ab85262884f2b91f09eceb9aefd0e2426ce67 Mon Sep 17 00:00:00 2001 From: Grisha Le

Re: Bash 5.2.21 segfaults when I feed it garbage

On Mon, Jan 8, 2024 at 4:41 PM Chet Ramey wrote: > I think there's a simpler > way to fix it in parse_compound_assignment and parse_string_to_word_list > directly, and that change will be in the next devel branch push. Rewriting the original report as: bash <<<'((X=([))' even after the last

Re: Bash 5.2.0: Memory leak with $(

On Sun, Jan 7, 2024, 00:26 pourko--- via Bug reports for the GNU Bourne Again SHell wrote: > For demonstration, put a $( becomes very noticeable: > The bug is not present in bashes before 5.2.0. > I believe this is fixed in (yet unreleased) Bash 5.3. See report [1] applied in [2]. [1]: https

Re: [PATCH] preserve $_ value across prompt expansions

On Thu, Dec 14, 2023, 12:51 Chet Ramey wrote: > On 12/12/23 3:55 PM, Grisha Levit wrote: > > Since expanding a prompt string that contains a funsub will modify the > > value of $_, would it make sense to restore the value of $_ after the > > expansion is complete, as

[PATCH] preserve $_ value across prompt expansions

Since expanding a prompt string that contains a funsub will modify the value of $_, would it make sense to restore the value of $_ after the expansion is complete, as we do when executing PROMPT_COMMAND? $ PS0='${ : X; }' bash --norc bash-5.3$ : A bash-5.3$ echo $_ X P.S. Technica

Re: TAB completion bug

The problem seems to be not treating a single quote that follows a backslash as the end of a single-quoted string. diff --git a/bashline.c b/bashline.c index 774f813f..b1837d43 100644 --- a/bashline.c +++ b/bashline.c @@ -4077,15 +4077,13 @@ bash_dequote_filename (char *text, int quote_char) ret

[PATCH] OPTIND in funsub

00:00 2001 From: Grisha Levit Date: Tue, 28 Nov 2023 01:13:12 -0500 Subject: [PATCH] restore getopt state after funsub --- execute_cmd.c | 2 +- execute_cmd.h | 1 + subst.c | 8 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/execute_cmd.c b/execute_cmd.c index 567

[PATCH] return at top-level after funsub

Calling `return' after a funsub outside of a function or `.' context doesn't behave correctly: $ bash -c '${ :; }; (return 2); echo $?' 2 $ bash -c '${ :; }; return' Segmentation fault From cd67d9defa0dbb7be36c1df163db33e78cac8f27 Mon Sep 17 00:00:00 2001 Fr

Re: readline: double free when using PageDown

On Sat, Nov 25, 2023, 14:03 Chet Ramey wrote: > On 11/25/23 11:41 AM, Matthias Klose wrote: > > [forwarded from https://bugs.debian.org/1056314] > > > > """ > > I am getting a crash in the Python REPL in this scenario: > > > > 1. start "python3" in a terminal > > 2. type "2+2", enter > > 3. type

Re: [PATCH] tests/unicode1.sub: fixup

On Fri, Nov 24, 2023, 17:32 Chet Ramey wrote: > Thanks for the report. Nice attention to detail. This test has not changed > substantially since it was donated in 2012. Namerefs didn't exist then, and > my guess is that John Kearney wasn't familiar or comfortable with ${!x[@]}. > > https://lists.

tests/glob2.sub failure on macOS 14

In macOS 14 (Sonoma), Apple switched from GNU to BSD-based iconv, which have slightly different charset definitions. The tests in glob2.sub test U+03B1 in zh_HK.big5hkscs, but this codepoint is not present in the BSD BIG5-HKSCS definition, so the test fails. The codepoint does exist in the BIG5 ch

[PATCH] tests/unicode1.sub: fixup

Many of the tests in unicode.sub don't actually run because the arrays containing codepoints to test are sparse and the TestCodePage function assumes that they are not. If that's fixed, the zh_TW.BIG5 tests run but fail. I'm not sure what the original intent was, they seem to expect U+00F6..U+00FE

Re: bash.1: "Theextglob"

On Wed, Nov 22, 2023, 15:55 Jakub Wilk wrote: > Bash Version: 5.2 > Patch Level: 15 > Release Status: release > > Description: > > In the manual page, space is missing between "The" and "extglob". > > Repeat-By: > > $ man bash | grep Thee >Theextglob option changes

[PATCH] small doc typos

diff --git a/doc/bash.1 b/doc/bash.1 index 901794c1..595ff977 100644 --- a/doc/bash.1 +++ b/doc/bash.1 @@ -2290,7 +2290,7 @@ Control how the results of pathname expansion are sorted. The value of this variable specifies the sort criteria and sort order for the results of pathname expansion. If t

Re: [PATCH] negative arg trimming

On Tue, Nov 21, 2023, 00:57 Grisha Levit wrote: > rl_trim_arg_from_keyseq fails to trim a negative argument entered with > universal-argument and fails to trim arguments if they have multiple > leading minus signs. > Also fails if the function to be executed is shadowed by a key ma

[PATCH] negative arg trimming

'"\C-u": universal-argument' bind -x '"\eX": "declare -p READLINE_ARGUMENT"' Followed any of: "\e--\eX" "\C-u-\eX" "\C-u--\eX", etc. all result in: bash: bash_execute_unix_command: cannot find keymap for comman

Re: Regex: A case where the longest match isn't being found

On Thu, Oct 26, 2023, 20:30 Dale R. Worley wrote: > I suspect the difference between the versions is how the regexp is > unquoted while it is being read, with version 3 interpreting [^\'] as > "character class excluding newline, backslash, and quote" and version 5 > interpreting it as "character

Re: [PATCH] printf %ls/%lc/%Q fixes

On Thu, Oct 19, 2023 at 8:23 PM Grisha Levit wrote: > @@ -490,7 +491,10 @@ printf_builtin (WORD_LIST *list) > ws[0] = wc; > ws[1] = L'\0'; > > - r = printwidestr (start, ws, 1, fieldwidth, precision); > +

[PATCH] printf width/precision argument overflow

When reading a printf width/precision argument, the value isn't checked for overflow if it happens to be the last argument: $ INT_MAX=$(getconf INT_MAX) $ printf '[%*s]' "$((INT_MAX+1))" [] $ printf '[%*s]' "$((INT_MAX+1))" X -bash: printf: X: Result too large [] ..and the

[PATCH] printf %ls/%lc/%Q fixes

A few issues with handling of the new %ls, %lc and %Q conversion specifications: The %ls and %lc conversion specifications dereference a null pointer if used without an argument: $ (printf %ls) Segmentation fault: 11 $ (printf %lc) Segmentation fault: 11 The Q conversion specifie

Re: wrong variable name in error message about unbound variable?

On Tue, Oct 17, 2023, 10:48 Christoph Anton Mitterer wrote: > > On Tue, 2023-10-17 at 00:26 -0400, Grisha Levit wrote: > > The array subscript can an arbitrary arithmetic expression with side > > effects, so it makes sense to perform the expansion even if the array > >

Re: wrong variable name in error message about unbound variable?

On Mon, Oct 16, 2023, 22:46 Christoph Anton Mitterer wrote: > Hey. > > On Mon, 2023-10-16 at 22:05 -0400, Lawrence Velázquez wrote: > > Under no circumstances should your examples complain about "array" > > because they do not attempt to expand it. As I demonstrated, your > > examples do not eve

  1   2   3   4   5   >