Re: Bash patches format

2018-06-03 Thread Siteshwar Vashisht
- Original Message - > From: "Marty E. Plummer" > To: "Chet Ramey" > Cc: bash-annou...@gnu.org, bug-bash@gnu.org > Sent: Thursday, May 31, 2018 3:08:57 AM > Subject: Re: Bash patches format > > Well, as I said, debian and fedora convert to

Re: Bash patches format

2018-06-02 Thread Matt Housh
On 5/30/2018 02:04, Marty E. Plummer wrote: > On Wed, May 30, 2018 at 10:42:27AM +0800, Clark Wang wrote: >> On Wed, May 30, 2018 at 8:25 AM, Marty E. Plummer >> wrote: >> If people are willing to do the conversion between patch formats for >>> their own purposes, more power to them. I

Re: Bash patches format

2018-05-31 Thread Robert Elz
pkgsrc (for NetBSD and other systems) has no listed bash maintainer, so ... (and please understand that I in no way speak for pkgsrc or NetBSD here). As long as patch(1) can handle the format, which form (context, unified, ...) patches are released in makes no difference at all. pkgsrc defaults

Re: Bash patches format

2018-05-31 Thread Rainer Müller
On 2018-05-30 09:04, Marty E. Plummer wrote: > Maintainers, I'd really like to hear your thoughts on this matter. If > the diffs are produced as -p1 unified diffs, then downstreams who do > convert from -p0 context won't have to, and distros who work around it > won't either. Speaking as

Re: Bash patches format

2018-05-31 Thread Eric Blake
On 05/30/2018 02:04 AM, Marty E. Plummer wrote: Maintainers, I'd really like to hear your thoughts on this matter. If the diffs are produced as -p1 unified diffs, then downstreams who do convert from -p0 context won't have to, and distros who work around it won't either. Makes no real

Re: Bash patches format

2018-05-31 Thread Bartłomiej Piotrowski
On 2018-05-30 09:04, Marty E. Plummer wrote: > Maintainers, I'd really like to hear your thoughts on this matter. If > the diffs are produced as -p1 unified diffs, then downstreams who do > convert from -p0 context won't have to, and distros who work around it > won't either. > > Regards, > >

Re: Bash patches format

2018-05-31 Thread Natanael Copa
"Marty E. Plummer" wrote: > Maintainers, I'd really like to hear your thoughts on this matter. If > the diffs are produced as -p1 unified diffs, then downstreams who do > convert from -p0 context won't have to, and distros who work around it > won't either. Alpine Linux uses -p1 and unified

Re: Bash patches format

2018-05-30 Thread Todd Zullinger
Marty E. Plummer wrote: > On Wed, May 30, 2018 at 09:15:04AM -0400, Chet Ramey wrote: >> On 5/29/18 8:25 PM, Marty E. Plummer wrote: >> If people are willing to do the conversion between patch formats for their own purposes, more power to them. I don't see any compelling reason to

Re: Bash patches format

2018-05-30 Thread Todd Zullinger
Chet Ramey wrote: > On 5/29/18 11:44 PM, Todd Zullinger wrote: > >> The main difference is the lack of detail in the git commit >> message. It would great if the same data found in the >> bash44-019 patch file was added to the git commit message. > > This is certainly doable. I would just have

Re: Bash patches format

2018-05-30 Thread Marty E. Plummer
On Wed, May 30, 2018 at 04:59:15PM +0200, Christian Weisgerber wrote: > Marty E. Plummer: > > > Maintainers, I'd really like to hear your thoughts on this matter. If > > the diffs are produced as -p1 unified diffs, then downstreams who do > > convert from -p0 context won't have to, and distros

Re: Bash patches format

2018-05-30 Thread Marty E. Plummer
On Wed, May 30, 2018 at 09:15:04AM -0400, Chet Ramey wrote: > On 5/29/18 8:25 PM, Marty E. Plummer wrote: > > >> If people are willing to do the conversion between patch formats for their > >> own purposes, more power to them. I don't see any compelling reason to > >> change the format I use. >

Re: Bash patches format

2018-05-30 Thread Christian Weisgerber
Marty E. Plummer: > Maintainers, I'd really like to hear your thoughts on this matter. If > the diffs are produced as -p1 unified diffs, then downstreams who do > convert from -p0 context won't have to, and distros who work around it > won't either. Speaking in my capacity as the OpenBSD

Re: Bash patches format

2018-05-30 Thread Chet Ramey
On 5/29/18 11:44 PM, Todd Zullinger wrote: > The main difference is the lack of detail in the git commit > message. It would great if the same data found in the > bash44-019 patch file was added to the git commit message. This is certainly doable. I would just have to change the script I use.

Re: Bash patches format

2018-05-30 Thread Chet Ramey
On 5/29/18 8:25 PM, Marty E. Plummer wrote: >> If people are willing to do the conversion between patch formats for their >> own purposes, more power to them. I don't see any compelling reason to >> change the format I use. >> > Could I at least convince you to start doing -p1, if not unified?

Re: Bash patches format

2018-05-30 Thread Marty E. Plummer
On Wed, May 30, 2018 at 10:30:10AM +0200, Emanuel Haupt wrote: > "Marty E. Plummer" wrote: > > On Wed, May 30, 2018 at 10:42:27AM +0800, Clark Wang wrote: > > > On Wed, May 30, 2018 at 8:25 AM, Marty E. Plummer > > > wrote: > > > > > > > > If people are willing to do the conversion between

Re: Bash patches format

2018-05-30 Thread Vladimir Marek
> > > > If people are willing to do the conversion between patch formats for > > > their > > > > own purposes, more power to them. I don't see any compelling reason to > > > > change the format I use. > > > > > > > Could I at least convince you to start doing -p1, if not unified? > > > > > > > I

Re: Bash patches format

2018-05-30 Thread Emanuel Haupt
"Marty E. Plummer" wrote: > On Wed, May 30, 2018 at 10:42:27AM +0800, Clark Wang wrote: > > On Wed, May 30, 2018 at 8:25 AM, Marty E. Plummer > > wrote: > > > > > > If people are willing to do the conversion between patch > > > > formats for > > > their > > > > own purposes, more power to them.

Re: Bash patches format

2018-05-30 Thread Todd Zullinger
Hi, Marty E. Plummer wrote: >> If people are willing to do the conversion between patch formats for their >> own purposes, more power to them. I don't see any compelling reason to >> change the format I use. >> > Could I at least convince you to start doing -p1, if not unified? Don't we

Re: Bash patches format

2018-05-30 Thread Marty E. Plummer
On Wed, May 30, 2018 at 10:42:27AM +0800, Clark Wang wrote: > On Wed, May 30, 2018 at 8:25 AM, Marty E. Plummer > wrote: > > > > If people are willing to do the conversion between patch formats for > > their > > > own purposes, more power to them. I don't see any compelling reason to > > >

Re: Bash patches format

2018-05-29 Thread Clark Wang
On Wed, May 30, 2018 at 8:25 AM, Marty E. Plummer wrote: > > If people are willing to do the conversion between patch formats for > their > > own purposes, more power to them. I don't see any compelling reason to > > change the format I use. > > > Could I at least convince you to start doing

Re: Bash patches format

2018-05-29 Thread Marty E. Plummer
On Tue, May 29, 2018 at 11:05:45AM -0400, Chet Ramey wrote: > On 5/19/18 9:46 AM, Marty E. Plummer wrote: > > Greetings, > > > > In doing some research into ways to better improve the gentoo ebuild qa, > > I ran across the fact that the official bash patches are provided as > > -p0, context

Re: Bash patches format

2018-05-29 Thread Chet Ramey
On 5/19/18 9:46 AM, Marty E. Plummer wrote: > Greetings, > > In doing some research into ways to better improve the gentoo ebuild qa, > I ran across the fact that the official bash patches are provided as > -p0, context diffs. > > I was hoping I could convince you to convert to -p1, unified

Bash patches format

2018-05-19 Thread Marty E. Plummer
Greetings, In doing some research into ways to better improve the gentoo ebuild qa, I ran across the fact that the official bash patches are provided as -p0, context diffs. I was hoping I could convince you to convert to -p1, unified diffs, such as are produced by diff -u or git format-patch,