Re: better buffer size for copy

2005-11-04 Thread Paul Eggert
[EMAIL PROTECTED] (Robert Latham) writes: > In the time since the above thread was started, there is now an > implementation of lcm in src/system.h. I'd rather use something more like buffer_lcm in diffutils, since it handles weird cases without dumping core. ___

Re: {base,dir}name // semantics

2005-11-04 Thread Paul Eggert
Eric Blake <[EMAIL PROTECTED]> writes: > for cross compilation, should I be pessimistic and > make dir_name("//") always return "//" (unless overridden by priming the > cache, of course)? Or should I write the test with hard-coded knowledge > of the HOST values that are known to have distinct //

Re: {base,dir}name // semantics

2005-11-04 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 7/9/2005 2:49 PM: >>>should this patch be made globally, or should it be limited to only >>>systems that have a distinct //, leaving other platforms to continue >>>having just a single slash returned? >> >>Limit it to just th

better buffer size for copy

2005-11-04 Thread Robert Latham
Hi The thread here http://lists.gnu.org/archive/html/bug-coreutils/2003-11/msg00030.html suggested that copy, instead of using the destination block size, should use the LCM of the source block size and the destination block size. In the time since the above thread was started, there is now an i

Re: ln.c portability fix for hosts where / != //

2005-11-04 Thread Paul Eggert
Jim Meyering <[EMAIL PROTECTED]> writes: > But if someone submits a clean patch, I'll consider it. Here's a patch that I hope is clean enough; it shortens the source code by 18 lines. It doesn't fix any bugs so I have not installed it. 2005-11-04 Paul Eggert <[EMAIL PROTECTED]> * src

Re: possible bug - output stream handling inconsistency in dd

2005-11-04 Thread Theodoros V. Kalamatianos
On Wed, 2 Nov 2005, Theodoros V. Kalamatianos wrote: Anyway, I _think_ that following patch implements the desired behaviour: Did anyone review the patch, or did it slip through the cracks ? I'd really like to know if I need to imrove on this... Regards, Theodoros Kalamatianos _

Re: ln.c portability fix for hosts where / != //

2005-11-04 Thread Jim Meyering
Eric Blake <[EMAIL PROTECTED]> wrote: ... >> /* Construct a string NEW_DEST by concatenating DEST, a slash, and >> - basename(SOURCE) in alloca'd memory. Don't modify DEST or SOURCE. */ >> + basename (SOURCE) in alloca'd memory. Don't modify DEST or SOURCE. >> + Omit unnecessary slashes i

Re: coreutils-5.92:du not AIX largefile safe --

2005-11-04 Thread Jim Meyering
Paul Townsend <[EMAIL PROTECTED]> wrote: > I put the above plus a couple of other commands in a script. Below is > the output of `ksh -xv tst'. I've applied your patch and written a test for the bug. Would you please see if it detects the problem with the previous version of du and that it succee