Re: recent const churn

2008-06-17 Thread Jim Meyering
Eric Blake [EMAIL PROTECTED] wrote: According to Jim Meyering on 6/16/2008 9:49 AM: | Sounds like an updated maintainer rule to check for redundant const might be | useful? | | Thanks for keeping watch! | Anything to protect me from myself ;-) | If you feel like it, a patch would be most

Re: rebased patches?

2008-06-17 Thread Jim Meyering
Bo Borgerson [EMAIL PROTECTED] wrote: Jim Meyering wrote: This brings up another (as yet unwritten) guideline: Don't change translatable strings if you can avoid it. If you must rearrange lines, extract and create new strings, rather than extracting and moving into existing blocks.

Re: rebased patches?

2008-06-17 Thread Jim Meyering
Bo Borgerson [EMAIL PROTECTED] wrote: I've pushed a version of the sort branch that contains the following updates: 1. Try to minimize changes to translatable strings 2. Improve diagnostic messages for files0-from edge-cases 3. Use the new standardized files0-from test script format 4.

Re: recent const churn

2008-06-17 Thread Eric Blake
Jim Meyering jim at meyering.net writes: However, rather than changing sc_const_long_option to avoid sc_redundant_const triggering on it's regexp, I've chosen to use a stricter regexp in the new rule so we don't have to twist the other rule: grep -E

Re: recent const churn

2008-06-17 Thread Jim Meyering
Eric Blake [EMAIL PROTECTED] wrote: Jim Meyering jim at meyering.net writes: However, rather than changing sc_const_long_option to avoid sc_redundant_const triggering on it's regexp, I've chosen to use a stricter regexp in the new rule so we don't have to twist the other rule: grep -E