Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-11 Thread Jim Meyering
Giuseppe Scrivano <[EMAIL PROTECTED]> wrote: > do you have suggestions on this patch? It replaces any `signal' with > `sigaction'. > > Regards, > Giuseppe Scrivano > > Jim Meyering <[EMAIL PROTECTED]> writes: > >> Good idea. >> I've wanted to get rid of "signal" uses for ages. >> Are you intereste

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-11 Thread Giuseppe Scrivano
Sure, if you are going to use my patch then I will assign my coreutils copyright to the FSF. Giuseppe Scrivano Eric Blake <[EMAIL PROTECTED]> writes: > The size of this patch is not trivial; are you willing to assign copyright > to FSF? If so, I can get you started off-list. Meanwhile, I don't

Re: FAIL: df/total-awk.log

2008-10-11 Thread Jim Meyering
Ed Avis <[EMAIL PROTECTED]> wrote: > FAIL: df/total-awk.log (exit: 1) > > + diff -u out1 out2 > --- out1 2008-10-10 20:22:10.0 +0100 > +++ out2 2008-10-10 20:22:10.0 +0100 > @@ -1,3 +1,3 @@ > -4.11081e+09 > -2.60756e+09 > +4110809460 > +260

Re: FAIL: df/total-awk.log

2008-10-11 Thread Philip Rowlands
On Sat, 11 Oct 2008, Jim Meyering wrote: Actually, that might be due to something else. What version of awk are you using? With the versions of gawk I've tried (3.1.5 and 3.1.6), it doesn't use the offending format: $ awk 'BEGIN {print 2607560286}' 2607560286 Ah ha! But if i use mawk, it do

Re: FAIL: df/total-awk.log

2008-10-11 Thread Jim Meyering
Philip Rowlands <[EMAIL PROTECTED]> wrote: > I get the same results as Jim, even though on my system (Ubuntu Hardy) > both gawk and mawk docs state OFMT defaults to "%.6g". > > I can't tell why OFMT is being ignored here by gawk - although I found > a bug-gnu-utils post suggesting a difference betw

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-11 Thread Giuseppe Scrivano
Hello, Jim Meyering <[EMAIL PROTECTED]> writes: > Giuseppe, > > Perhaps you misunderstood? > Eric proposed that idea and I addressed the reply above to him. > He then replied that he would indeed like to implement it. Sorry, I thought it was directed to both. > Since you have spent time working

Re: FAIL: df/total-awk.log

2008-10-11 Thread Jim Meyering
Ed Avis <[EMAIL PROTECTED]> wrote: > With current coreutils source from git, one test fails on my machine. It is a > Fedora 9 box with a few Windows filesystems mounted. Here is the tests/test- > suite.log. > > === >GNU coreutils 7.0.5-

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-11 Thread Jim Meyering
Pádraig Brady <[EMAIL PROTECTED]> wrote: > Eric Blake wrote: >> On the other hand, POSIX is explicit that mixing signal and sigaction is >> not portable. For that matter, now that gnulib provides a guaranteed >> sigaction, why don't we just change all of coreutils to use it? Affected >> are: cspl

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-11 Thread Andreas Schwab
Giuseppe Scrivano <[EMAIL PROTECTED]> writes: > + memset (&sa, 0, sizeof sa); > + sigemptyset (&sa.sa_mask); I don't think you need the memset. Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-11 Thread Giuseppe Scrivano
Andreas Schwab <[EMAIL PROTECTED]> writes: >> + memset (&sa, 0, sizeof sa); >> + sigemptyset (&sa.sa_mask); > > I don't think you need the memset. and how reset the struct without a memset or using "sa = {0,}" as Pádraig suggested? Do you advise me to reset manually only members that really mus

Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

2008-10-11 Thread Andreas Schwab
Giuseppe Scrivano <[EMAIL PROTECTED]> writes: > Andreas Schwab <[EMAIL PROTECTED]> writes: >>> + memset (&sa, 0, sizeof sa); >>> + sigemptyset (&sa.sa_mask); >> >> I don't think you need the memset. > > > and how reset the struct without a memset or using "sa = {0,}" as > Pádraig suggested? You

df test failure for coreutils-7.0

2008-10-11 Thread Paul Jarc
I got this failure from "make check" with coreutils 7.0. It looks like a bug in the test, rather than in df itself. df is complaining about not being able to access a mount point which has a FUSE filesystem mounted on it. = GNU coreutils 7.0: tests/

info info

2008-10-11 Thread stephen brenton
I hope I am writing to the right group of people. I have found an error in the info file. It's really just a group of typos, but I thought I would let you know. example: File: coreutils.info, Node: ptx invocation, Next: tsort invocation, Prev: co\ mm invocation, Up: Operating on sorte

Re: info info

2008-10-11 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to stephen brenton on 10/11/2008 8:10 PM: > I hope I am writing to the right group of people. > I have found an error in the info file. It's really just a group of typos, > but I thought I would let you know. Thanks for the report; Karl Ber