Re: snapshot in a few hours

2009-09-04 Thread Jim Meyering
Pádraig Brady wrote: > Jim Meyering wrote: >> Pádraig Brady wrote: >>> Jim Meyering wrote: If anyone knows of bug-related fixes that aren't yet applied, please speak up. I'm thinking of making a snapshot today, leading to a bug-fix release, coreutils-7.6, next week. >>> It would be

Re: [PATCH] doc: make the tail --sleep-interval help less confusing

2009-09-04 Thread Jim Meyering
Eric Blake wrote: > According to Pádraig Brady on 9/4/2009 3:57 PM: >> A trivial patch make tail --help less confusing to me at least >> >> * src/tail.c (usage): I read "approximately S seconds" >> as "approximately 5 seconds" for approximately 5 seconds. > > Nice commit message! It took me the sa

test-openat-safer failure on older kernel

2009-09-04 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On on older machine (2.6.16.29 kernel, glibc 3.4.6), when using /proc emulation, openat(fd,"",O_RDONLY) was accidentally succeeding in opening a copy of /proc/self/fd/n (ie. the directory pointed to by fd) instead of failing with ENOENT. Fixed as foll

Re: brand new failure: ln/misc

2009-09-04 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 9/4/2009 3:47 PM: > so I'm applying this to gnulib, plus a submodule bump > in coreutils (but I'll run more testing there first). Testing confirms it; bumping the submodule fixes the regression. - -- Don't work too hard, ma

Re: [PATCH] cp, mv: do preserve extended attributes even for read-only source files

2009-09-04 Thread Pádraig Brady
Ondřej Vašík wrote: > As reported in > http://lists.gnu.org/archive/html/bug-coreutils/2009-08/msg00342.html by > Ernest N. Mamikonyan, cp/mv fails to preserve extended attributes for > read-only source files. > Following patch fixes the issue for me, although maybe it's not perfect > solution. But

Re: [PATCH] doc: make the tail --sleep-interval help less confusing

2009-09-04 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Pádraig Brady on 9/4/2009 3:57 PM: > A trivial patch make tail --help less confusing to me at least > > * src/tail.c (usage): I read "approximately S seconds" > as "approximately 5 seconds" for approximately 5 seconds. Nice commit messag

[PATCH] doc: make the tail --sleep-interval help less confusing

2009-09-04 Thread Pádraig Brady
A trivial patch make tail --help less confusing to me at least From: =?utf-8?q?P=C3=A1draig=20Brady?= Date: Fri, 4 Sep 2009 22:50:15 +0100 Subject: [PATCH] doc: make the tail --sleep-interval help less confusing * src/tail.c (usage): I read "approximately S seconds" as "approximately 5 seconds"

Re: brand new failure: ln/misc

2009-09-04 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 9/4/2009 3:26 PM: > I don't have time to investigate right now, so... > > == >GNU coreutils 7.5.55-860a3: tests/test-suite.log > =

brand new failure: ln/misc

2009-09-04 Thread Jim Meyering
I don't have time to investigate right now, so... == GNU coreutils 7.5.55-860a3: tests/test-suite.log == 1 of 350 tests failed. (36 tests were not run). .. contents:: :depth: 2 ... FAIL:

Re: snapshot in a few hours

2009-09-04 Thread Pádraig Brady
Jim Meyering wrote: > Pádraig Brady wrote: >> Jim Meyering wrote: >>> If anyone knows of bug-related fixes that aren't yet applied, >>> please speak up. I'm thinking of making a snapshot today, >>> leading to a bug-fix release, coreutils-7.6, next week. >> It would be nice to get Ondřej's fix for

Re: snapshot in a few hours

2009-09-04 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 9/4/2009 2:36 PM: >> + so we are justified in trying link() before blindly removing B, >> + and calling link() twice for a successful 'ln -f'. > > Looks fine, modulo: > > how about adjusting via > > s/and/and thu

Re: snapshot in a few hours

2009-09-04 Thread Jim Meyering
Eric Blake wrote: > According to Eric Blake on 9/4/2009 2:06 PM: >> According to Jim Meyering on 9/4/2009 12:12 PM: copy.c needs to use #if LINK_FOLLOWS_SYMLINKS instead of #ifdef. >>> Sounds good. >> >> How about the following two patches? ... >>From 410eddc47c10082591b2487b234a3b5a6155daaf M

Re: snapshot in a few hours

2009-09-04 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 9/4/2009 2:06 PM: > According to Jim Meyering on 9/4/2009 12:12 PM: >>> copy.c needs to use #if LINK_FOLLOWS_SYMLINKS instead of #ifdef. >> Sounds good. > > How about the following two patches? Aargh. Did it again, and att

Re: snapshot in a few hours

2009-09-04 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 9/4/2009 12:12 PM: >> copy.c needs to use #if LINK_FOLLOWS_SYMLINKS instead of #ifdef. > > Sounds good. How about the following two patches? - -- Don't work too hard, make some time for fun as well! Eric Blake

Re: snapshot in a few hours

2009-09-04 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 9/4/2009 12:11 PM: > Or maybe even add a hidden (three hyphen ---no-inotify, since we presume > it'll be used only for testing) option to expose that behavior without > the requirement to jump through build-time hoops. > >

Re: snapshot in a few hours

2009-09-04 Thread Jim Meyering
Eric Blake wrote: > According to Jim Meyering on 9/4/2009 10:17 AM: >> If anyone knows of bug-related fixes that aren't yet applied, >> please speak up. I'm thinking of making a snapshot today, >> leading to a bug-fix release, coreutils-7.6, next week. >> >> Eric, I'm open to the idea of using the

Re: snapshot in a few hours

2009-09-04 Thread Jim Meyering
Pádraig Brady wrote: > Jim Meyering wrote: >> If anyone knows of bug-related fixes that aren't yet applied, >> please speak up. I'm thinking of making a snapshot today, >> leading to a bug-fix release, coreutils-7.6, next week. > > It would be nice to get Ondřej's fix for copy xattrs from readonly

Re: snapshot in a few hours

2009-09-04 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 9/4/2009 10:17 AM: > If anyone knows of bug-related fixes that aren't yet applied, > please speak up. I'm thinking of making a snapshot today, > leading to a bug-fix release, coreutils-7.6, next week. > > Eric, I'm open t

Re: snapshot in a few hours

2009-09-04 Thread Pádraig Brady
Jim Meyering wrote: > If anyone knows of bug-related fixes that aren't yet applied, > please speak up. I'm thinking of making a snapshot today, > leading to a bug-fix release, coreutils-7.6, next week. It would be nice to get Ondřej's fix for copy xattrs from readonly files. I might be able to lo

Re: [PATCH] tests: fix a failure when running tail-2/wait as root

2009-09-04 Thread Jim Meyering
Pádraig Brady wrote: > I misunderstood Giuesspe's previous fix, > so this should reinstate it. >>From 99e1135a74cc7342f4c2599d8bf34c725095983d Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?P=C3=A1draig=20Brady?= > Date: Fri, 4 Sep 2009 14:01:42 +0100 > Subject: [PATCH] tests: fix a failure when runn

snapshot in a few hours

2009-09-04 Thread Jim Meyering
If anyone knows of bug-related fixes that aren't yet applied, please speak up. I'm thinking of making a snapshot today, leading to a bug-fix release, coreutils-7.6, next week. Eric, I'm open to the idea of using the latest from gnulib if you think it's worthwhile. If that would mean a bit of ada

Re: system ask user confirmation with cp -f

2009-09-04 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to YOGESH PATANKAR on 9/4/2009 7:23 AM: > 1. Create a file i.e bdlist.txt in tmp directory. > 2. Create a file with same name in root directory. > 3. Execute command cp -f bdlist.txt /tmp > > Error : System ask for confirmation from user. I

system ask user confirmation with cp -f

2009-09-04 Thread YOGESH PATANKAR
Hi   I am trying to copy the file through 'cp -f' command. If the same file exist on destination folder system ask for user confirmation. Ideally by using '-f' option system should overwrite the file directly.   Steps to reproduced 1. Create a file i.e bdlist.txt in tmp directory. 2. Create a fil

[PATCH] tests: fix a failure when running tail-2/wait as root

2009-09-04 Thread Pádraig Brady
I misunderstood Giuesspe's previous fix, so this should reinstate it. cheers, Pádraig. >From 99e1135a74cc7342f4c2599d8bf34c725095983d Mon Sep 17 00:00:00 2001 From: =?utf-8?q?P=C3=A1draig=20Brady?= Date: Fri, 4 Sep 2009 14:01:42 +0100 Subject: [PATCH] tests: fix a failure when running tail-2/wait

Bug#545009: coreutils: FTBFS on GNU/kFreeBSD (testsuite failure of tests/tail-2/wait)

2009-09-04 Thread Petr Salinger
Package: coreutils Version: 7.5-1 Severity: important Tags: patch User: debian-...@lists.debian.org Usertags: kfreebsd X-Debbugs-CC: bug-coreutils@gnu.org Hi, the current version fails to build on GNU/kFreeBSD due to failure in tests/tail-2/wait. The problem is that GNU/kFreeBSD is not inotify

Re: rm (remove.c): Rewrite to use fts: request for review

2009-09-04 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Jim Meyering on 9/3/2009 11:03 PM: >> diff --git a/ChangeLog b/ChangeLog >> index efda62b..fe02dd9 100644 >> diff --git a/MODULES.html.sh b/MODULES.html.sh > ... >> diff --git a/lib/closein.c b/lib/closein.c > ... > > Thanks. It looks li

Re: rm (remove.c): Rewrite to use fts: request for review

2009-09-04 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Eric Blake on 9/3/2009 10:51 PM: > I thought I'd push this now to make it easier to review. > >> http://git.sv.gnu.org/cgit/coreutils.git/log/?h=next Well, it would help if I'd actually attach the right patch. For the record of what

Re: [PATCH] fix libcap configure flag handling

2009-09-04 Thread Mike Frysinger
On Friday 04 September 2009 03:27:00 Jim Meyering wrote: > Kamil Dudka wrote: > > Looks good to me. I wrote that nonsense as I had misunderstood semantic > > of the AC_ARG_ENABLE macro... > > Thanks for the review. > This time I tested carefully ;-) > > After each of the first three, below, grep LI

Re: [PATCH] fix libcap configure flag handling

2009-09-04 Thread Jim Meyering
Kamil Dudka wrote: > Looks good to me. I wrote that nonsense as I had misunderstood semantic > of the AC_ARG_ENABLE macro... Thanks for the review. This time I tested carefully ;-) After each of the first three, below, grep LIB_CAP config.status prints S["LIB_CAP"]="-lcap": ./configure