bug#6176: [PATCH 2/2] sort: --debug: output data independent key warnings

2010-05-12 Thread Pádraig Brady
On 12/05/10 14:55, Eric Blake wrote: > On 05/12/2010 07:53 AM, Eric Blake wrote: >> On 05/11/2010 05:39 PM, Pádraig Brady wrote: >>> The attached patch gives warnings about questionable >>> option combinations. For example: >>> >>> $ sort --debug -rb -k1,1n /dev/null >>> ! options `-b' are ignored

bug#6176: [PATCH 2/2] sort: --debug: output data independent key warnings

2010-05-12 Thread Eric Blake
On 05/12/2010 07:53 AM, Eric Blake wrote: > On 05/11/2010 05:39 PM, Pádraig Brady wrote: >> The attached patch gives warnings about questionable >> option combinations. For example: >> >> $ sort --debug -rb -k1,1n /dev/null >> ! options `-b' are ignored >> ! option `-r' only applies to last-resort

bug#6176: [PATCH 1/2] sort: add a --debug option to highlight key extents

2010-05-12 Thread Pádraig Brady
On 12/05/10 12:08, Jim Meyering wrote: > Pádraig Brady wrote: >> The attached patch allows one to: >> >> $ printf "one 2 3e3e" | .sort --debug -k3,3g -k2,2 >> one 2 3e3e >> ___ >>__ >> __ > > Nice. Thanks for writing all of that. > These changes are sure to be useful. > > I hav

bug#6176: [PATCH 2/2] sort: --debug: output data independent key warnings

2010-05-12 Thread Eric Blake
On 05/11/2010 05:39 PM, Pádraig Brady wrote: > The attached patch gives warnings about questionable > option combinations. For example: > > $ sort --debug -rb -k1,1n /dev/null > ! options `-b' are ignored > ! option `-r' only applies to last-resort comparison That looks awkward, both when compare

bug#6176: [PATCH 1/2] sort: add a --debug option to highlight key extents

2010-05-12 Thread Jim Meyering
Pádraig Brady wrote: > The attached patch allows one to: > > $ printf "one 2 3e3e" | .sort --debug -k3,3g -k2,2 > one 2 3e3e > ___ >__ > __ Nice. Thanks for writing all of that. These changes are sure to be useful. I have merely glanced through them (look fine so far), but woul

bug#6176: [PATCH 2/2] sort: --debug: output data independent key warnings

2010-05-12 Thread Pádraig Brady
On 12/05/10 00:39, Pádraig Brady wrote: > The attached patch gives warnings about questionable > option combinations. For example: > > $ sort --debug -rb -k1,1n /dev/null > ! options `-b' are ignored > ! option `-r' only applies to last-resort comparison Oops, The previous patch warned about -r e

bug#6131: [PATCH]: fiemap support for efficient sparse file copy

2010-05-12 Thread Jim Meyering
jeff.liu wrote: > Hello All, ... > Would you guys please review and consider apply the patches if there is no > other issue? Thanks for yet another iteration, and sorry it's taking so long. >>From f8c78794a70f1fb45a2c61c8bbeca344087287ab Mon Sep 17 00:00:00 2001 > From: Jie Liu > Date: Fri, 7 M