bug#13099: possible test bug in tests/df/total-verify.sh

2012-12-06 Thread Bernhard Voelker
On 12/06/2012 04:39 AM, Assaf Gordon wrote: Correction: On 12/05/12 22:33, Assaf Gordon wrote: === $ df --total -i -P Filesystem Inodes IUsed IFree IUse% Mounted on snip //bluearctitan3/foobar0 0 0 - /media/foobar === The

bug#13099: possible test bug in tests/df/total-verify.sh

2012-12-06 Thread Pádraig Brady
On 12/06/2012 09:22 AM, Bernhard Voelker wrote: On 12/06/2012 04:39 AM, Assaf Gordon wrote: Correction: On 12/05/12 22:33, Assaf Gordon wrote: === $ df --total -i -P Filesystem Inodes IUsed IFree IUse% Mounted on snip //bluearctitan3/foobar0

bug#13099: possible test bug in tests/df/total-verify.sh

2012-12-06 Thread Bernhard Voelker
On 12/06/2012 10:55 AM, Pádraig Brady wrote: That still passes here with a standard file system at least. Please push. I could reproduce the failure with a loop-mounted vfat image. Thanks for the review, pushed: http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=43a6ccf0

bug#13089: Wish: split every n'th into n pipes

2012-12-06 Thread Pádraig Brady
On 12/06/2012 12:20 PM, Ole Tange wrote: On Thu, Dec 6, 2012 at 12:41 PM, Pádraig Brady p...@draigbrady.com wrote: On 12/06/2012 11:25 AM, Pádraig Brady wrote: On 12/06/2012 12:06 AM, Ole Tange wrote: Do you have a similar reference: * if each record is k lines (e.g. 4 lines as is the case

bug#13098: [PATCH] cut.c: Fix memory leak

2012-12-06 Thread Pádraig Brady
On 12/06/2012 02:11 AM, Cojocaru Alexandru wrote: From 82f2b062c0e21d9a0d64f9ceab363d2a79f5a6eb Mon Sep 17 00:00:00 2001 From: Cojocaru Alexandru xo...@gmx.com Date: Thu, 6 Dec 2012 03:03:41 +0100 Subject: [PATCH] cut: fix memory leak * src/cut.c (set_fields): don't allocate memory for

bug#13098: [PATCH] cut.c: Fix memory leak

2012-12-06 Thread Cojocaru Alexandru
Hmm, it might be a bit more consistent to guard all references to the bit vector array with max_range_endpoint? How about the attached? I checked for `n_rp' and `printable_field' becuase it felt more natural. I reasoned as follows: first check if we have any finite ranges (n_rp) if yes,

bug#13098: [PATCH] cut.c: Fix memory leak

2012-12-06 Thread Jim Meyering
Pádraig Brady wrote: ... How about the attached? From: Cojocaru Alexandru xo...@gmx.com Date: Thu, 6 Dec 2012 03:03:41 +0100 Subject: [PATCH] cut: avoid a redundant heap allocation * src/cut.c (set_fields): Don't allocate memory for `printable_field' if there are no finite ranges. The

bug#13098: [PATCH] cut.c: Fix memory leak

2012-12-06 Thread Jim Meyering
Jim Meyering wrote: Pádraig Brady wrote: ... How about the attached? From: Cojocaru Alexandru xo...@gmx.com Date: Thu, 6 Dec 2012 03:03:41 +0100 Subject: [PATCH] cut: avoid a redundant heap allocation * src/cut.c (set_fields): Don't allocate memory for `printable_field' if there are no