bug#32703: echo_man_error

2018-09-24 Thread Pádraig Brady
On 24/09/18 15:15, Eric Blake wrote: > On 9/23/18 9:48 PM, Pádraig Brady wrote: > >> +++ b/NEWS >> @@ -5,6 +5,12 @@ GNU coreutils NEWS-*- >> outline -*- >> ** Bug fixes >> >> df no longer corrupts displayed multibyte characters on macOS. >> + [bug

bug#32703: echo_man_error

2018-09-24 Thread Pádraig Brady
On 24/09/18 14:47, Bernhard Voelker wrote: > On 9/24/18 4:48 AM, Pádraig Brady wrote: >> I'll push the attached later. >> Interesting there were no echo tests until now. > > Nice work, indeed. > > Additionally to Eric's comment, I'd suggest to increase the coverage > for 'echo' to about 100% [1]

bug#32703: echo_man_error

2018-09-24 Thread Eric Blake
On 9/23/18 9:48 PM, Pádraig Brady wrote: +++ b/NEWS @@ -5,6 +5,12 @@ GNU coreutils NEWS-*- outline -*- ** Bug fixes df no longer corrupts displayed multibyte characters on macOS. + [bug introduced with coreutils-8.18] + +** Changes in behavior + +

bug#32703: echo_man_error

2018-09-24 Thread Bernhard Voelker
On 9/24/18 4:48 AM, Pádraig Brady wrote: > I'll push the attached later. > Interesting there were no echo tests until now. Nice work, indeed. Additionally to Eric's comment, I'd suggest to increase the coverage for 'echo' to about 100% [1] with the attached patch: * src/echo.c (usage): Assert

bug#32703: echo_man_error

2018-09-24 Thread Eric Blake
On 9/23/18 9:48 PM, Pádraig Brady wrote: I'll push the attached later. Interesting there were no echo tests until now. Marking this as done. Thanks. +++ b/tests/misc/echo.sh + +# Verify the methods of specifying "Escape": +# Note 4 octal digits are allows (unlike printf which uses up to

bug#31979: csplit: a regexp pattern does not consider the negative offset of a

2018-09-24 Thread Stéphane Campinas
Hi, After attempting to port csplit, I think I understand why it is like that: it is to stop the iteration in case a pattern should be executed several times. Therefore, maybe an easy fix is to alter the documentation to indicate that lines within a negative offset are not matched in subsequent