bug#36831: enhance 'directory not empty' message

2019-07-31 Thread Paul Eggert
Assaf Gordon wrote: An explicit error explicitly saying "cannot move", and mention the source and destination, and also "blames" the target directory seems the most user-friendly and least ambiguous. Sure, but that handles only the ENOTEMPTY/EEXIST case. How would you handle the EDQUOT, EISDIR

bug#36831: enhance 'directory not empty' message

2019-07-31 Thread Bernhard Voelker
On 8/1/19 12:05 AM, Assaf Gordon wrote: > Happy to hear your opinion, +1 Including the full context about an error is essential: - what did the tool try to do (at that point)? - what was the problem? (e.g. ENOTEMPTY) - where was the problem: src or dst? Thanks & have a nice day, Berny

bug#36831: enhance 'directory not empty' message

2019-07-31 Thread Assaf Gordon
Hello Paul, On Mon, Jul 29, 2019 at 06:50:46PM -0500, Paul Eggert wrote: > On 7/29/19 1:28 AM, Assaf Gordon wrote: > > + if (rename_errno == ENOTEMPTY || rename_errno == EEXIST) > > +{ > > + error (0, 0, _("cannot move %s to %s: Target directory not > > empty"), > > +