bug#79336: [PATCH] df: fix potential null pointer dereference

2025-08-30 Thread Pádraig Brady
On 30/08/2025 18:52, Pádraig Brady wrote: On 29/08/2025 02:45, yubiao hu wrote: * src/df.c (get_dev): Fix potential null pointer dereference - Avoid dereferencing stat_file when both device and mount_point are NULL - Handle allocation failure for cell when mount_point is NULL These are v

bug#79336: [PATCH] df: fix potential null pointer dereference

2025-08-30 Thread Collin Funk
Paul Eggert writes: > On 2025-08-28 18:45, yubiao hu wrote: >> * src/df.c (get_dev): Fix potential null pointer dereference >> - Avoid dereferencing stat_file when both device and >> mount_point are NULL >> - Handle allocation failure for cell when mount_point >> is NULL > > Why is this patch

bug#79336: [PATCH] df: fix potential null pointer dereference

2025-08-30 Thread Pádraig Brady
On 29/08/2025 02:45, yubiao hu wrote: * src/df.c (get_dev): Fix potential null pointer dereference - Avoid dereferencing stat_file when both device and mount_point are NULL - Handle allocation failure for cell when mount_point is NULL These are valid concerns. I also see potential null dere

bug#79347: Bad formatting for ls with block-size 'k

2025-08-30 Thread Peter Laan
Hi, I'm a GNU/Linux noob so maybe I'm doing something wrong. But see the attached image for badly formatted output from ls -s1 --block-size=\'k. The columns are not always aligned. This only happens when you have large files in the directory. Everything looks fine with --block-size=k. I'm running

bug#79336: [PATCH] df: fix potential null pointer dereference

2025-08-30 Thread Paul Eggert
On 2025-08-28 18:45, yubiao hu wrote: * src/df.c (get_dev): Fix potential null pointer dereference - Avoid dereferencing stat_file when both device and mount_point are NULL - Handle allocation failure for cell when mount_point is NULL Why is this patch needed? Can you give an example df inv

bug#79300: fold-nbsp test failure

2025-08-30 Thread Pádraig Brady
On 30/08/2025 04:27, Collin Funk wrote: Pádraig Brady writes: Thanks for the suggestion, but that doesn't work. Any issue with skipping based on $host_os for this test and for fold-spaces.sh? I was thinking of testing "printf '\u00A0' | ./src/tr -d '[:blank:]'" but that won't work since 'tr' o

bug#79336: [PATCH] df: fix potential null pointer dereference

2025-08-30 Thread yubiao hu
* src/df.c (get_dev): Fix potential null pointer dereference - Avoid dereferencing stat_file when both device and mount_point are NULL - Handle allocation failure for cell when mount_point is NULL --- src/df.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) d

bug#79300: fold-nbsp test failure

2025-08-30 Thread Collin Funk
Pádraig Brady writes: >> Thanks for the suggestion, but that doesn't work. Any issue with >> skipping based on $host_os for this test and for fold-spaces.sh? >> I was thinking of testing "printf '\u00A0' | ./src/tr -d >> '[:blank:]'" >> but that won't work since 'tr' operates on bytes and U+00A0

bug#79300: fold-nbsp test failure

2025-08-30 Thread Pádraig Brady
On 29/08/2025 05:23, Collin Funk wrote: Pádraig Brady writes: Perhaps the techniques from tests/wc/wc-nbsp.sh could be used? Maybe something like: check_space() { char="$1" # Use -L to determine whether NBSP is printable. # FreeBSD 11 and OS X treat NBSP as non printable ? test "$

bug#79261: coreutils 9.7 "date -u" - timezone offset is in the wrong direction

2025-08-30 Thread Martin D Kealey
On Tue, 26 Aug 2025, 07:15 James Feeney, wrote: > Hey Martin > > On Mon, 2025-08-25 at 20:10 +1000, Martin D Kealey wrote: > > TL;DR locale and timezone are independent; neither implies the other. > > Thanks for your note. Short version: your point is taken, and I submit a > revised argument, an

bug#79300: fold-nbsp test failure

2025-08-30 Thread Collin Funk
Pádraig Brady writes: > Perhaps the techniques from tests/wc/wc-nbsp.sh could be used? > Maybe something like: > > check_space() { > char="$1" > # Use -L to determine whether NBSP is printable. > # FreeBSD 11 and OS X treat NBSP as non printable ? > test "$(env printf "=$char=" | wc -L)"

bug#79300: fold-nbsp test failure

2025-08-30 Thread Collin Funk
Bruno Haible writes: > Collin Funk wrote: >> My initial idea was to check if U+2007 FIGURE SPACE and U+00A0 NO-BREAK >> SPACE are blank using grep. But apparently Solaris grep does not handle >> multibyte characters. Therefore, FIGURE SPACE cannot be checked. :( > > I'm not sure we are talking ab