Re: [PATCH] Again, do not change the mode of all directories below $HOME.

2008-08-02 Thread Jim Meyering
Ralf Wildenhues <[EMAIL PROTECTED]> wrote: ... >> > Would the following not have sufficed, too? >> > >> >> -trap 'st=$?; cleanup_; d='"$t_"'; >> >> -cd '"$test_dir_"' && chmod -R u+rwx "$d" && rm -rf "$d" && exit $st' >> >> 0 >> > +trap 'st=$?; cleanup_; d="$t_"; >> > +cd "$test_dir_" &

Re: [PATCH] Again, do not change the mode of all directories below $HOME.

2008-08-02 Thread Ralf Wildenhues
Hi Jim, and sorry for the delay, * Jim Meyering wrote on Tue, Jul 22, 2008 at 09:42:30PM CEST: > Ralf Wildenhues <[EMAIL PROTECTED]> wrote: > > > >> But seriously, considering the potential for damage and mischief, > >> perhaps it's time to add infrastructure that stops e.g., configure > >> in its

Re: [PATCH] Again, do not change the mode of all directories below $HOME.

2008-07-22 Thread Jim Meyering
Ralf Wildenhues <[EMAIL PROTECTED]> wrote: >> Look at it as an incentive not to use directories with names >> containing meta-characters ;-) > > Well, *I* am doing it for fun. Others use /c/My Files/... because yet > others thought requiring users to cope with such names would be a cool > idea. T

Re: [PATCH] Again, do not change the mode of all directories below $HOME.

2008-07-22 Thread Ralf Wildenhues
Hi Jim, * Jim Meyering wrote on Tue, Jul 22, 2008 at 01:17:20PM CEST: > Ralf Wildenhues <[EMAIL PROTECTED]> wrote: > > this fixes a regression of "make check" when source and build tree live > > in a directory with spaces in the name. The regression was introduced > > some time after I posted a f

Re: [PATCH] Again, do not change the mode of all directories below $HOME.

2008-07-22 Thread Jim Meyering
Ralf Wildenhues <[EMAIL PROTECTED]> wrote: > * tests/CuTmpdir.pm (chmod_tree): Do not run chmod on undefined > argument, can happen when the build path contains spaces. > --- > > this fixes a regression of "make check" when source and build tree live > in a directory with spaces in the name. The r

Re: [PATCH] Again, do not change the mode of all directories below $HOME.

2008-07-22 Thread Jim Meyering
Philip Rowlands <[EMAIL PROTECTED]> wrote: > On Tue, 22 Jul 2008, Ralf Wildenhues wrote: > >> * tests/CuTmpdir.pm (chmod_tree): Do not run chmod on undefined >> argument, can happen when the build path contains spaces. > > That sounds wrong - there's no magic to unusual characters in > filenames ot

Re: [PATCH] Again, do not change the mode of all directories below $HOME.

2008-07-22 Thread Philip Rowlands
On Tue, 22 Jul 2008, Ralf Wildenhues wrote: * tests/CuTmpdir.pm (chmod_tree): Do not run chmod on undefined argument, can happen when the build path contains spaces. That sounds wrong - there's no magic to unusual characters in filenames other than avoiding passing them unquoted through an IF

[PATCH] Again, do not change the mode of all directories below $HOME.

2008-07-21 Thread Ralf Wildenhues
* tests/CuTmpdir.pm (chmod_tree): Do not run chmod on undefined argument, can happen when the build path contains spaces. --- Hi Jim, this fixes a regression of "make check" when source and build tree live in a directory with spaces in the name. The regression was introduced some time after I po