Re: [PATCH] Fix preserve_mode when destination directory partially exists

2008-01-11 Thread Jim Meyering
Jan Blunck <[EMAIL PROTECTED]> wrote: > On Tue, Jan 08, Paul Eggert wrote: > >> Jim Meyering <[EMAIL PROTECTED]> writes: >> >> > 2008-01-07 Jan Blunck <[EMAIL PROTECTED]> >> > >> >cp --parents: don't use uninitialized memory when restoring permissions >> >> In reviewing that patch I noticed t

Re: [PATCH] Fix preserve_mode when destination directory partially exists

2008-01-11 Thread Jan Blunck
On Tue, Jan 08, Paul Eggert wrote: > Jim Meyering <[EMAIL PROTECTED]> writes: > > > 2008-01-07 Jan Blunck <[EMAIL PROTECTED]> > > > > cp --parents: don't use uninitialized memory when restoring permissions > > In reviewing that patch I noticed that the bug of using uninitialized > memory s

Re: [PATCH] Fix preserve_mode when destination directory partially exists

2008-01-09 Thread Jim Meyering
Paul Eggert <[EMAIL PROTECTED]> wrote: > Jim Meyering <[EMAIL PROTECTED]> writes: > >> 2008-01-07 Jan Blunck <[EMAIL PROTECTED]> >> >> cp --parents: don't use uninitialized memory when restoring permissions > > In reviewing that patch I noticed that the bug of using uninitialized > memory st

Re: [PATCH] Fix preserve_mode when destination directory partially exists

2008-01-08 Thread Paul Eggert
Jim Meyering <[EMAIL PROTECTED]> writes: > 2008-01-07 Jan Blunck <[EMAIL PROTECTED]> > > cp --parents: don't use uninitialized memory when restoring permissions In reviewing that patch I noticed that the bug of using uninitialized memory still remains in some (unlikely) cases. If 'stat (

Re: [PATCH] Fix preserve_mode when destination directory partially exists

2008-01-07 Thread Jim Meyering
Jan Blunck <[EMAIL PROTECTED]> wrote: > On Fri, Jan 04, Paul Eggert wrote: > >> Jan Blunck <[EMAIL PROTECTED]> writes: >> >> > I found a bug with cp -p --parents when the destination partially exists >> > and >> > the filesystem isn't mounted with acls. >> > >> > $ mkdir -p a/b/c a/b/d e >> > $ t

Re: [PATCH] Fix preserve_mode when destination directory partially exists

2008-01-07 Thread Jan Blunck
On Fri, Jan 04, Paul Eggert wrote: > Jan Blunck <[EMAIL PROTECTED]> writes: > > > I found a bug with cp -p --parents when the destination partially exists and > > the filesystem isn't mounted with acls. > > > > $ mkdir -p a/b/c a/b/d e > > $ touch a/b/c/foo a/b/d/foo > > $ cp -p --parent a/b/c e

Re: [PATCH] Fix preserve_mode when destination directory partially exists

2008-01-04 Thread Paul Eggert
Jan Blunck <[EMAIL PROTECTED]> writes: > I found a bug with cp -p --parents when the destination partially exists and > the filesystem isn't mounted with acls. > > $ mkdir -p a/b/c a/b/d e > $ touch a/b/c/foo a/b/d/foo > $ cp -p --parent a/b/c e > $ cp -p --parent a/b/d e > $ ls -ld e/a > d---

[PATCH] Fix preserve_mode when destination directory partially exists

2008-01-04 Thread Jan Blunck
I found a bug with cp -p --parents when the destination partially exists and the filesystem isn't mounted with acls. $ mkdir -p a/b/c a/b/d e $ touch a/b/c/foo a/b/d/foo $ cp -p --parent a/b/c e $ cp -p --parent a/b/d e $ ls -ld e/a d- 3 jblunck suse 4096 1970-01-01 01:00 e/a This bug was