Re: [PATCH] tests: refactor to use the new getlimits utility

2009-01-02 Thread Pádraig Brady
Pádraig Brady wrote: New version attached with that fixed plus some tweaks of the commit log Thanks Bo! OK I verified that all tests pass with this patch on both 32 bit and 64 bit x86 linux systems, so I'll push it soon along with this trivial one: From

[PATCH] tests: refactor to use the new getlimits utility

2008-12-12 Thread Pádraig Brady
I'd especially like a review of the perl bits as my perl is _very_ weak. cheers. Pádraig. From daaab330ebcd18ecc45b38270d315ae9e08c6ff9 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?P=C3=A1draig=20Brady?= p...@draigbrady.com Date: Fri, 12 Dec 2008 10:25:34 + Subject: [PATCH] tests: refactor to use

Re: [PATCH] tests: refactor to use the new getlimits utility

2008-12-12 Thread Bo Borgerson
Pádraig Brady wrote: I'd especially like a review of the perl bits Hi Pádraig, I'm not sure that this function will behave quite as you intended it to: +sub getlimits() +{ + my $NV; + open NV, getlimits | or die Error running getlimits\n; + my %limits = map {split /=|\n/} NV; + return

Re: [PATCH] tests: refactor to use the new getlimits utility

2008-12-12 Thread Pádraig Brady
+ Subject: [PATCH] tests: refactor to use the new getlimits utility * tests/Coreutils.pm: add function to make limits available * tests/test-lib.sh: ditto * tests/misc/join: check for both SIZE_OFLOW and UINTMAX_OFLOW (in case they're different), rather than using arbitrary 2^128 * tests/misc