bug#13030: factor: infinite loop on Linux/powerpc

2013-01-06 Thread Jim Meyering
Pádraig Brady wrote: ... > No comments, so I'm pushing the attached. ... > Subject: [PATCH] factor: apply a more general fix to enable correct assembly > > In addition to the previous 64 bit guards we've placed in longlong.h > there are additional _LP64 guards required for mips with -mcpu >= 3, > t

bug#13030: factor: infinite loop on Linux/powerpc

2013-01-06 Thread Pádraig Brady
On 01/04/2013 02:47 PM, Pádraig Brady wrote: So what I'm going to do is pull all the _LP64 amendments to longlong.h and instead avoid it completely with this in factor.c: diff --git a/src/factor.c b/src/factor.c index 473eee7..95451a5 100644 --- a/src/factor.c +++ b/src/factor.c @@ -118,7 +118,1

bug#13030: factor: infinite loop on Linux/powerpc

2013-01-04 Thread Pádraig Brady
On 11/29/2012 08:08 PM, Pádraig Brady wrote: On 11/29/2012 07:36 PM, Torbjorn Granlund wrote: Pádraig Brady writes: > -#if HAVE_HOST_CPU_FAMILY_powerpc && W_TYPE_SIZE == 64 > +#if HAVE_HOST_CPU_FAMILY_powerpc && W_TYPE_SIZE == 64 && defined (_LP64) > #if !defined (_LONG_LONG_LIMB)

bug#13030: factor: infinite loop on Linux/powerpc

2012-12-05 Thread Bernhard Voelker
On 12/05/2012 11:08 AM, Colin Watson wrote: > On Wed, Dec 05, 2012 at 09:58:11AM +0100, Bernhard Voelker wrote: >> Now, "make syntax-check" fails: >> >> Colin Watson >> maint.mk: remove the above names from THANKS.in >> make: *** [sc_THANKS_in_duplicates] Error 1 >> >> Before removing that en

bug#13030: factor: infinite loop on Linux/powerpc

2012-12-05 Thread Colin Watson
On Wed, Dec 05, 2012 at 09:58:11AM +0100, Bernhard Voelker wrote: > On 11/29/2012 08:34 PM, Pádraig Brady wrote: > > The fix looks good thanks. > > I'll commit [...] > > Now, "make syntax-check" fails: > > Colin Watson > maint.mk: remove the above names from THANKS.in > make: *** [sc_THANKS

bug#13030: factor: infinite loop on Linux/powerpc

2012-12-05 Thread Bernhard Voelker
On 11/29/2012 08:34 PM, Pádraig Brady wrote: > On 11/29/2012 02:28 PM, Colin Watson wrote: > The fix looks good thanks. > I'll commit [...] Now, "make syntax-check" fails: Colin Watson maint.mk: remove the above names from THANKS.in make: *** [sc_THANKS_in_duplicates] Error 1 Before remov

bug#13030: factor: infinite loop on Linux/powerpc

2012-11-29 Thread Pádraig Brady
On 11/29/2012 07:36 PM, Torbjorn Granlund wrote: Pádraig Brady writes: > -#if HAVE_HOST_CPU_FAMILY_powerpc && W_TYPE_SIZE == 64 > +#if HAVE_HOST_CPU_FAMILY_powerpc && W_TYPE_SIZE == 64 && defined (_LP64) > #if !defined (_LONG_LONG_LIMB) > /* _LONG_LONG_LIMB is ABI=mode32 where a

bug#13030: factor: infinite loop on Linux/powerpc

2012-11-29 Thread Torbjorn Granlund
Pádraig Brady writes: > -#if HAVE_HOST_CPU_FAMILY_powerpc && W_TYPE_SIZE == 64 > +#if HAVE_HOST_CPU_FAMILY_powerpc && W_TYPE_SIZE == 64 && defined (_LP64) > #if !defined (_LONG_LONG_LIMB) > /* _LONG_LONG_LIMB is ABI=mode32 where adde operates on 32-bit values. So > use adde et

bug#13030: factor: infinite loop on Linux/powerpc

2012-11-29 Thread Pádraig Brady
On 11/29/2012 02:28 PM, Colin Watson wrote: Both Debian and Ubuntu builds of coreutils 8.20 hang while running the test suite on powerpc. This turns out to be reproducible using 'factor 122'. This turns out to be somewhat related to http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12754, but not qu

bug#13030: factor: infinite loop on Linux/powerpc

2012-11-29 Thread Colin Watson
Both Debian and Ubuntu builds of coreutils 8.20 hang while running the test suite on powerpc. This turns out to be reproducible using 'factor 122'. This turns out to be somewhat related to http://debbugs.gnu.org/cgi/bugreport.cgi?bug=12754, but not quite the same. uintmax_t is 64 bits, but the c