bug#13582: [PATCH] stat: add ext4 to the ext2/ext3 list

2013-01-31 Thread Bernhard Voelker
On 01/30/2013 11:44 PM, Bob Proulx wrote: Bernhard Voelker wrote: b) just adding ext4 to ext2/ext3 as it has already been proposed by several people could break existing scripts that use code like this: test $(stat -f -c %T .) = ext2/ext3 ... I'm wondering how often users check for

bug#13582: [PATCH] stat: add ext4 to the ext2/ext3 list

2013-01-31 Thread Ondrej Vasik
On Thu, 2013-01-31 at 09:02 +0100, Bernhard Voelker wrote: On 01/30/2013 11:44 PM, Bob Proulx wrote: Bernhard Voelker wrote: b) just adding ext4 to ext2/ext3 as it has already been proposed by several people could break existing scripts that use code like this: test $(stat -f -c

bug#13582: [PATCH] stat: add ext4 to the ext2/ext3 list

2013-01-30 Thread Bob Proulx
reopen 13582 severity 13582 wishlist thanks Bernhard Voelker wrote: I feel very sorry if my words were a bit harsh. Admitted, you refer to this in README: If your patch adds a new feature, please try to get some sort of consensus that it is a worthwhile change. One way to do that is

bug#13582: [PATCH] stat: add ext4 to the ext2/ext3 list

2013-01-30 Thread Bob Proulx
I am just adding references here to tie in the previous discussions. The bugzilla.redhat.com discussion actually has the best analysis of the problem. However let me summarize (and plagarize) as best as I can here. In https://bugzilla.redhat.com/show_bug.cgi?id=485507 Eric Sandeen proposed

bug#13582: [PATCH] stat: add ext4 to the ext2/ext3 list

2013-01-30 Thread Bernhard Voelker
On 01/30/2013 10:27 PM, Bob Proulx wrote: I am just adding references here to tie in the previous discussions. Thanks for that excellent summary. Reading (again) through it, it seems to me that we have 2 arguments: a) basically, it would be good to be able to distinguish ext2/ext3 from ext4

bug#13582: [PATCH] stat: add ext4 to the ext2/ext3 list

2013-01-30 Thread Bob Proulx
Bernhard Voelker wrote: Reading (again) through it, it seems to me that we have 2 arguments: a) basically, it would be good to be able to distinguish ext2/ext3 from ext4 while it is problematic in the real world due to EXT4's nature - or at least would bring a lot of code into stat. Yes.

bug#13582: [PATCH] stat: add ext4 to the ext2/ext3 list

2013-01-29 Thread Mike Frysinger
On Tuesday 29 January 2013 01:57:42 Bernhard Voelker wrote: tag 13582 + notabug close 13582 stop On 01/29/2013 07:13 AM, Mike Frysinger wrote: Since ext4 returns the same info as ext2/ext3, add it to the list. This fixes the output of running `stat -f / -c %T` on my system that has an

bug#13582: [PATCH] stat: add ext4 to the ext2/ext3 list

2013-01-29 Thread Bernhard Voelker
On 01/29/2013 07:39 PM, Mike Frysinger wrote: On Tuesday 29 January 2013 01:57:42 Bernhard Voelker wrote: On 01/29/2013 07:13 AM, Mike Frysinger wrote: Thanks for the patch, however, you submitted it to the bug-coreutils mailing list which automatically opened a new ticket. Therefore, I'm

bug#13582: [PATCH] stat: add ext4 to the ext2/ext3 list

2013-01-28 Thread Mike Frysinger
Since ext4 returns the same info as ext2/ext3, add it to the list. This fixes the output of running `stat -f / -c %T` on my system that has an ext4 rootfs. * src/stat.c (human_fstype): Add ext4 to the S_MAGIC_EXT2 and FSTYPE_EXT2FS cases. --- src/stat.c | 4 ++-- 1 file changed, 2 insertions(+),

bug#13582: [PATCH] stat: add ext4 to the ext2/ext3 list

2013-01-28 Thread Bob Proulx
Mike Frysinger wrote: Since ext4 returns the same info as ext2/ext3, add it to the list. This fixes the output of running `stat -f / -c %T` on my system that has an ext4 rootfs. * src/stat.c (human_fstype): Add ext4 to the S_MAGIC_EXT2 and FSTYPE_EXT2FS cases. Previous discussion (wow,

bug#13582: [PATCH] stat: add ext4 to the ext2/ext3 list

2013-01-28 Thread Bernhard Voelker
tag 13582 + notabug close 13582 stop On 01/29/2013 07:13 AM, Mike Frysinger wrote: Since ext4 returns the same info as ext2/ext3, add it to the list. This fixes the output of running `stat -f / -c %T` on my system that has an ext4 rootfs. Thanks for the patch, however, you submitted it to the