bug#16922: df --si -h should emit a warning

2014-03-03 Thread Eric Blake
On 03/03/2014 08:19 AM, Mateusz Jończyk wrote: > W dniu 03.03.2014 04:02, Pádraig Brady pisze: >> On 03/02/2014 05:38 PM, Bernhard Voelker wrote: Very few read info pages, and >> anyway in this case we should be clear at the man page level. > >> Mateusz stated the issue was that on a quick glance,

bug#16922: df --si -h should emit a warning

2014-03-03 Thread Pádraig Brady
On 03/03/2014 03:19 PM, Mateusz Jończyk wrote: > W dniu 03.03.2014 04:02, Pádraig Brady pisze: >> On 03/02/2014 05:38 PM, Bernhard Voelker wrote: Very few read info pages, and >> anyway in this case we should be clear at the man page level. > >> Mateusz stated the issue was that on a quick glance,

bug#16922: df --si -h should emit a warning

2014-03-03 Thread Mateusz Jończyk
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 W dniu 03.03.2014 04:02, Pádraig Brady pisze: > On 03/02/2014 05:38 PM, Bernhard Voelker wrote: Very few read info pages, and > anyway in this case we should be clear at the man page level. > > Mateusz stated the issue was that on a quick glance, the

bug#16922: df --si -h should emit a warning

2014-03-03 Thread Bernhard Voelker
On 03/03/2014 12:35 PM, Pádraig Brady wrote: I suppose it's better to err on the side of less code, and let the translator adjust, assuming LC_MESSAGES == LC_NUMERIC. The alternative edge case is probably not worth the extra code. I'll push the attached soon. +1 Thanks! Have a nice day, Bern

bug#16922: df --si -h should emit a warning

2014-03-03 Thread Pádraig Brady
On 03/03/2014 10:54 AM, Pádraig Brady wrote: > On 03/03/2014 09:36 AM, Pádraig Brady wrote: >> On 03/03/2014 04:55 AM, Paul Eggert wrote: >>> Pádraig Brady wrote: + -h, --human-readable print abbreviated sizes in powers of 1024 (e.g. %s)\n\ + -H, --si print abbreviat

bug#16922: df --si -h should emit a warning

2014-03-03 Thread Pádraig Brady
On 03/03/2014 09:36 AM, Pádraig Brady wrote: > On 03/03/2014 04:55 AM, Paul Eggert wrote: >> Pádraig Brady wrote: >>> + -h, --human-readable print abbreviated sizes in powers of 1024 (e.g. >>> %s)\n\ >>> + -H, --si print abbreviated sizes in powers of 1000 (e.g. >>> %s)\n\ >> >> T

bug#16922: df --si -h should emit a warning

2014-03-03 Thread Bernhard Voelker
On 03/03/2014 10:35 AM, Pádraig Brady wrote: On 03/03/2014 08:00 AM, Bernhard Voelker wrote: On 03/03/2014 04:02 AM, Pádraig Brady wrote: -h, --human-readable print abbreviated sizes in powers of 1024 (e.g. 1023M) -H, --si print abbreviated sizes in powers of 1000 (e.g. 1.1G)

bug#16922: df --si -h should emit a warning

2014-03-03 Thread Pádraig Brady
On 03/03/2014 04:55 AM, Paul Eggert wrote: > Pádraig Brady wrote: >> + -h, --human-readable print abbreviated sizes in powers of 1024 (e.g. >> %s)\n\ >> + -H, --si print abbreviated sizes in powers of 1000 (e.g. >> %s)\n\ > > Thanks for looking into improving this. Please put co

bug#16922: df --si -h should emit a warning

2014-03-03 Thread Pádraig Brady
On 03/03/2014 08:00 AM, Bernhard Voelker wrote: > On 03/03/2014 04:02 AM, Pádraig Brady wrote: >> Very few read info pages, and anyway in this case we should be clear at the >> man page level. >> >> Mateusz stated the issue was that on a quick glance, the --si option wasn't >> described >> well e

bug#16922: df --si -h should emit a warning

2014-03-03 Thread Bernhard Voelker
On 03/03/2014 04:02 AM, Pádraig Brady wrote: > Very few read info pages, and anyway in this case we should be clear at the > man page level. > > Mateusz stated the issue was that on a quick glance, the --si option wasn't > described > well enough in isolation. Likewise, the description of -h req

bug#16922: df --si -h should emit a warning

2014-03-02 Thread Paul Eggert
Pádraig Brady wrote: + -h, --human-readable print abbreviated sizes in powers of 1024 (e.g. %s)\n\ + -H, --si print abbreviated sizes in powers of 1000 (e.g. %s)\n\ Thanks for looking into improving this. Please put commas after "e.g.". Also, I suggest removing "abbreviated",

bug#16922: df --si -h should emit a warning

2014-03-02 Thread Pádraig Brady
On 03/02/2014 05:38 PM, Bernhard Voelker wrote: > On 03/02/2014 03:33 PM, Pádraig Brady wrote: >> On 03/02/2014 12:33 PM, Mateusz Jończyk wrote: >>> Hello, >>> There should be a warning when running df --si -h because it will display >>> results >>> in blocks of 1024 and not 1000, as one might thi

bug#16922: df --si -h should emit a warning

2014-03-02 Thread Mateusz Jończyk
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 W dniu 02.03.2014 18:38, Bernhard Voelker pisze: > The problem is maybe that "df --help" doesn't explicitly say that -h is using > powers of 1024 no matter what other option was given before. > > -h, --human-readable print sizes in human readable for

bug#16922: df --si -h should emit a warning

2014-03-02 Thread Mateusz Jończyk
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 W dniu 02.03.2014 15:33, Pádraig Brady pisze: > On 03/02/2014 12:33 PM, Mateusz Jończyk wrote: >> Hello, There should be a warning when running df --si -h because it will >> display results in blocks of 1024 and not 1000, as one might think (the >> sw

bug#16922: df --si -h should emit a warning

2014-03-02 Thread Bernhard Voelker
On 03/02/2014 03:33 PM, Pádraig Brady wrote: > On 03/02/2014 12:33 PM, Mateusz Jończyk wrote: >> Hello, >> There should be a warning when running df --si -h because it will display >> results >> in blocks of 1024 and not 1000, as one might think (the switch --si displays >> blocks >> in a human-r

bug#16922: df --si -h should emit a warning

2014-03-02 Thread Pádraig Brady
On 03/02/2014 12:33 PM, Mateusz Jończyk wrote: > Hello, > There should be a warning when running df --si -h because it will display > results > in blocks of 1024 and not 1000, as one might think (the switch --si displays > blocks > in a human-readable format when used by itself). This is confusi

bug#16922: df --si -h should emit a warning

2014-03-02 Thread Mateusz Jończyk
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hello, There should be a warning when running df --si -h because it will display results in blocks of 1024 and not 1000, as one might think (the switch --si displays blocks in a human-readable format when used by itself). Greetings, Mateusz Jończyk