bug#25378: cp does not preserve SElinx context of sub folder

2017-02-21 Thread Pádraig Brady
On 20/02/17 23:18, Bernhard Voelker wrote: > Hi Padraig, > > only some minor remarks from my side. > > On 02/21/2017 04:11 AM, Pádraig Brady wrote: >> From d17ca013f3aadcf697663830fa9ec34cba551f66 Mon Sep 17 00:00:00 2001 >> From: =?UTF-8?q?P=C3=A1draig=20Brady?= >> Date:

bug#25378: cp does not preserve SElinx context of sub folder

2017-02-20 Thread Bernhard Voelker
Hi Padraig, only some minor remarks from my side. On 02/21/2017 04:11 AM, Pádraig Brady wrote: > From d17ca013f3aadcf697663830fa9ec34cba551f66 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?P=C3=A1draig=20Brady?= > Date: Mon, 20 Feb 2017 18:46:49 -0800 > Subject: [PATCH] cp:

bug#25378: cp does not preserve SElinx context of sub folder

2017-02-20 Thread Pádraig Brady
On 20/02/17 20:46, Paul Eggert wrote: > Does 'mkdir -Z --parents' need a similar patch? Already handled. > > Minor points: > > Please don't use 'extern' in front of function definitions. Just decls. > > The usual style in .h files is to say "extern type function (args);" rather > than > to

bug#25378: cp does not preserve SElinx context of sub folder

2017-02-20 Thread Paul Eggert
Does 'mkdir -Z --parents' need a similar patch? Minor points: Please don't use 'extern' in front of function definitions. Just decls. The usual style in .h files is to say "extern type function (args);" rather than to have a newline after the type.

bug#25378: cp does not preserve SElinx context of sub folder

2017-02-20 Thread Pádraig Brady
On 06/01/17 00:19, HE Henry wrote: > Hi coreutils team, > > When using cp with --parents options, the SELinux context of sub folders are > not preserved. > > Example as below: > > 1. Before using cp: > [root@oame0 etc]# pwd > /etc > [root@oame0 etc]# ls -Z selinux/ > -rw-r--r--. root root

bug#25378: cp does not preserve SElinx context of sub folder

2017-01-06 Thread HE Henry
Hi coreutils team, When using cp with --parents options, the SELinux context of sub folders are not preserved. Example as below: 1. Before using cp: [root@oame0 etc]# pwd /etc [root@oame0 etc]# ls -Z selinux/ -rw-r--r--. root root system_u:object_r:selinux_config_t:s0 config -rw-r--r--. root