bug#32703: echo_man_error

2018-10-27 Thread Pádraig Brady
On 24/09/18 21:51, Pádraig Brady wrote: > On 24/09/18 15:15, Eric Blake wrote: >> On 9/23/18 9:48 PM, Pádraig Brady wrote: >> >>> +++ b/NEWS >>> @@ -5,6 +5,12 @@ GNU coreutils NEWS-*- >>> outline -*- >>> ** Bug fixes >>> >>> df no longer corrupts displa

bug#32703: echo_man_error

2018-09-24 Thread Pádraig Brady
On 24/09/18 15:15, Eric Blake wrote: > On 9/23/18 9:48 PM, Pádraig Brady wrote: > >> +++ b/NEWS >> @@ -5,6 +5,12 @@ GNU coreutils NEWS-*- >> outline -*- >> ** Bug fixes >> >> df no longer corrupts displayed multibyte characters on macOS. >> + [bug int

bug#32703: echo_man_error

2018-09-24 Thread Pádraig Brady
On 24/09/18 14:47, Bernhard Voelker wrote: > On 9/24/18 4:48 AM, Pádraig Brady wrote: >> I'll push the attached later. >> Interesting there were no echo tests until now. > > Nice work, indeed. > > Additionally to Eric's comment, I'd suggest to increase the coverage > for 'echo' to about 100% [1]

bug#32703: echo_man_error

2018-09-24 Thread Eric Blake
On 9/23/18 9:48 PM, Pádraig Brady wrote: +++ b/NEWS @@ -5,6 +5,12 @@ GNU coreutils NEWS-*- outline -*- ** Bug fixes df no longer corrupts displayed multibyte characters on macOS. + [bug introduced with coreutils-8.18] + +** Changes in behavior + +

bug#32703: echo_man_error

2018-09-24 Thread Bernhard Voelker
On 9/24/18 4:48 AM, Pádraig Brady wrote: > I'll push the attached later. > Interesting there were no echo tests until now. Nice work, indeed. Additionally to Eric's comment, I'd suggest to increase the coverage for 'echo' to about 100% [1] with the attached patch: * src/echo.c (usage): Assert t

bug#32703: echo_man_error

2018-09-24 Thread Eric Blake
On 9/23/18 9:48 PM, Pádraig Brady wrote: I'll push the attached later. Interesting there were no echo tests until now. Marking this as done. Thanks. +++ b/tests/misc/echo.sh + +# Verify the methods of specifying "Escape": +# Note 4 octal digits are allows (unlike printf which uses up to 3

bug#32703: echo_man_error

2018-09-23 Thread Pádraig Brady
On 11/09/18 11:07, Eric Blake wrote: > On 9/11/18 11:01 AM, Eric Blake wrote: > >> $ POSIXLY_CORRECT=1 /bin/echo a\\nb >> a\nb >> >> Yikes! Even though we asked for POSIX correctness, we are NOT >> interpreting backslashes. I think this is a bug in GNU coreutils' echo, >> and could be fixed by

bug#32703: echo_man_error

2018-09-16 Thread Paul Eggert
Pádraig Brady wrote: Author: Jim Meyering Date: Thu Sep 25 12:58:50 1997 + Make echo conform to POSIX. By default, don't interpret backslash escape sequences. POSIX may have changed in the meantime, but POSIXLY_CORRECT was never used as a condition for enabling interpretat

bug#32703: echo_man_error

2018-09-15 Thread Pádraig Brady
On 11/09/18 11:07, Eric Blake wrote: > On 9/11/18 11:01 AM, Eric Blake wrote: > >> $ POSIXLY_CORRECT=1 /bin/echo a\\nb >> a\nb >> >> Yikes! Even though we asked for POSIX correctness, we are NOT >> interpreting backslashes. I think this is a bug in GNU coreutils' echo, >> and could be fixed by

bug#32703: echo_man_error

2018-09-11 Thread Eric Blake
On 9/11/18 11:01 AM, Eric Blake wrote: $ POSIXLY_CORRECT=1 /bin/echo a\\nb a\nb Yikes!  Even though we asked for POSIX correctness, we are NOT interpreting backslashes.  I think this is a bug in GNU coreutils' echo, and could be fixed by the patch below (but the testsuite would also need upd

bug#32703: echo_man_error

2018-09-11 Thread Eric Blake
tag 32703 needinfo thanks On 9/11/18 6:32 AM, 1064240043 wrote: In Manual page echo(1) it says '-E disable interpretation of backslash escapes (default)' but I tried and found out that enable(-e) is default. What exactly did you try? And are you sure you are testing the same echo in your

bug#32703: echo_man_error

2018-09-11 Thread 1064240043
In Manual page echo(1) it says '-E disable interpretation of backslash escapes (default)' but I tried and found out that enable(-e) is default.