Re: tail -f: --pid *and* inotify

Pádraig Brady wrote: Pádraig Brady wrote: I'm not able to compile/test/push at the moment due to gnulib submodule weirdness. I was playing around with submodules today and thought I had messed up something. But I think the issue is that you synced to a private gnulib version? Hi Pádraig,

Re: tail -f: --pid *and* inotify

I found another bug I think. Hopefully the attached is OK, but I'm not able to compile/test/push at the moment due to gnulib submodule weirdness. cheers, Pádraig. From 45e2e5f26d4d7641c3ef2bfc3e47aab5bc93b8fe Mon Sep 17 00:00:00 2001 From: =?utf-8?q?P=C3=A1draig=20Brady?= p...@draigbrady.com

Re: tail -f: --pid *and* inotify

Pádraig Brady wrote: I found another bug I think. Hopefully the attached is OK, but I'm not able to compile/test/push at the moment due to gnulib submodule weirdness. Thanks! Pushed. ___ Bug-coreutils mailing list Bug-coreutils@gnu.org

Re: tail -f: --pid *and* inotify

Giuseppe Scrivano wrote: Jim Meyering j...@meyering.net writes: A couple of points: Please move these declarations down into the scope where they are used. It would be better not to perform the kill test after every single select call when actively tailing files. Considering how --pid

Re: tail -f: --pid *and* inotify

Giuseppe Scrivano wrote: Jim Meyering j...@meyering.net writes: Hi Giuseppe, I've realized that there is a good way to remove the ugly exclusion that currently disables inotify-based tail -f when --pid is specified. Instead of the existing while-1-loop around code that reads the inotify FD

Re: tail -f: --pid *and* inotify

Jim Meyering j...@meyering.net writes: A couple of points: Please move these declarations down into the scope where they are used. It would be better not to perform the kill test after every single select call when actively tailing files. Considering how --pid is documented (in the

tail -f: --pid *and* inotify

Hi Giuseppe, I've realized that there is a good way to remove the ugly exclusion that currently disables inotify-based tail -f when --pid is specified. Instead of the existing while-1-loop around code that reads the inotify FD, we can use a loop that polls that single FD with a 1-2-second timeout

Re: tail -f: --pid *and* inotify

Hi Jim, Jim Meyering j...@meyering.net writes: Hi Giuseppe, I've realized that there is a good way to remove the ugly exclusion that currently disables inotify-based tail -f when --pid is specified. Instead of the existing while-1-loop around code that reads the inotify FD, we can use