Re: Feature Branch Windows Build Broken - lib/glob.c & WINDOWS32

2005-05-30 Thread Derek Price
Conrad T. Pino wrote: >I suggest using %USERPROFILE% only as the next fall back for cases where any >of %HOMEDRIVE%%HOMEPATH% are missing. > > I suggest some more research may be in order here first. Make sure that setting %USERPROFILE% isn't the perscribed method for overriding %HOMEDRIVE%%HO

RE: Feature Branch Windows Build Broken - lib/glob.c & WINDOWS32

2005-05-30 Thread Conrad T. Pino
Hi Derek, > From: Derek Price > > >I propose we do both, I'll edit and test, you coach: > > Sure. Great. I plan to stretch this out and finish in about a week. > >I will improve "pwd.c" also so long as cutting and pasting is acceptable > >between "pwd.c" and "glob.c" is acceptable. > > Hrm?

Re: Feature Branch Windows Build Broken - lib/glob.c & WINDOWS32

2005-05-28 Thread Derek Price
Conrad T. Pino wrote: >I propose we do both, I'll edit and test, you coach: > > Sure. >I'm OK with leaving WINDOWS32 undefined in our project. I'd like to see >an improvement in the WINDOWS32 code for the benefit of other projects if >for no other reason than saying thank you to GLib and GNUL

RE: Feature Branch Windows Build Broken - lib/glob.c & WINDOWS32

2005-05-28 Thread Conrad T. Pino
Hi Derek, > From: Derek Price > > Conrad T. Pino wrote: > > >Yes, the Windows build completes. Can you explain what "home_dir" value > >will be in the "WINDOWS32" undefined logic? > > It looks like it would call, basically, getpwnam (getlogin()). There > are substitutes for both in windows-NT

Re: Feature Branch Windows Build Broken - lib/glob.c & WINDOWS32

2005-05-26 Thread Derek Price
Conrad T. Pino wrote: >Yes, the Windows build completes. Can you explain what "home_dir" value >will be in the "WINDOWS32" undefined logic? > > It looks like it would call, basically, getpwnam (getlogin()). There are substitutes for both in windows-NT/pwd.c, though it doesn't look like they a

RE: Feature Branch Windows Build Broken - lib/glob.c & WINDOWS32

2005-05-26 Thread Conrad T. Pino
Hi Derek, > From: Derek Price > > >Compiling... > >glob.c > >h:\conrad\projects\cvs-1.12\lib\glob.c(535) : warning C4013: 'sysconf' > undefined; assuming extern returning int > >h:\conrad\projects\cvs-1.12\lib\glob.c(535) : error C2065: > '_SC_LOGIN_NAME_MAX' : undeclared identifier > > I've che

Re: Feature Branch Windows Build Broken - lib/glob.c & WINDOWS32

2005-05-25 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: >Oops, I forgot the error message which follows. > >Compiling... >glob.c >h:\conrad\projects\cvs-1.12\lib\glob.c(535) : warning C4013: 'sysconf' undefined; assuming extern returning int >h:\conrad\projects\cvs-1.12\lib\glob.c(535

Re: Feature Branch Windows Build Broken - lib/glob.c & WINDOWS32

2005-05-25 Thread Derek Price
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Conrad T. Pino wrote: >Hi Derek, > >The latest "lib/glob.c" introduced new macros not addressed >in the m4 stuff. Of interest are "WINDOWS32" and perhaps >"__MSDOS__" as "#define" and "#undef" respectively. > >Should I be expecting an "m4" solution wh

RE: Feature Branch Windows Build Broken - lib/glob.c & WINDOWS32

2005-05-25 Thread Conrad T. Pino
Oops, I forgot the error message which follows. Compiling... glob.c h:\conrad\projects\cvs-1.12\lib\glob.c(535) : warning C4013: 'sysconf' undefined; assuming extern returning int h:\conrad\projects\cvs-1.12\lib\glob.c(535) : error C2065: '_SC_LOGIN_NAME_MAX' : undeclared identifier h:\conrad\pr