Re: next release version of findutils?

2018-08-08 Thread Kamil Dudka
On Thursday, August 9, 2018 8:30:39 AM CEST Bernhard Voelker wrote: > On 08/08/2018 09:49 AM, Karl Nordström wrote: > > Hi, > > > > I wanted to ask whether there is a new release for findutils comming up? > > > > I want to add it to conda-forge and am having trouble passing make > > check. Partly

Re: next release version of findutils?

2018-08-08 Thread Bernhard Voelker
On 08/08/2018 09:49 AM, Karl Nordström wrote: > Hi, > > I wanted to ask whether there is a new release for findutils comming up? > > I want to add it to conda-forge and am having trouble passing make > check. Partly perhaps due to inexperience, but I think some of the tests > have been updated

Re: [Findutils-patches] [PATCH] Do not leave fd_limit as an unused variable on the stack if getrlimit is not supported.

2018-08-08 Thread Bernhard Voelker
On 08/08/2018 04:07 PM, Barath Aron wrote: > It is good to go. Thanks, pushed at: https://git.sv.gnu.org/cgit/findutils.git/commit/?id=5dae49b4fc7f Have a nice day, Berny

Re: [Findutils-patches] [PATCH] Do not leave fd_limit as an unused variable on the stack if getrlimit is not supported.

2018-08-08 Thread Barath Aron
On 08/08/2018 03:31 PM, Bernhard Voelker wrote: ah, right. That's a different motivation, so I changed the commit message in the attached. Okay to push? Thanks & have a nice day, Berny It is good to go. Thanks, Aron

Re: [Findutils-patches] [PATCH] Do not leave fd_limit as an unused variable on the stack if getrlimit is not supported.

2018-08-08 Thread Bernhard Voelker
On 08/08/2018 01:34 PM, Barath Aron wrote: > [...] the point is to avoid compiler error if getrlimit is not supported > (because the struct rlimit is not exists). ah, right. That's a different motivation, so I changed the commit message in the attached. Okay to push? Thanks & have a nice day,

Re: [Findutils-patches] [PATCH] Do not leave fd_limit as an unused variable on the stack if getrlimit is not supported.

2018-08-08 Thread Barath Aron
On 08/08/2018 01:11 PM, Bernhard Voelker wrote: On 08/08/2018 09:39 AM, Aron Barath wrote: * lib/fdleak.c (get_max_fd): add guard around the fd_limit variable Thanks for the patch. I'd favor to give that variable a better scope instead of adding another #if/#endif block. I'll push the attache

Re: [Findutils-patches] [PATCH] Do not leave fd_limit as an unused variable on the stack if getrlimit is not supported.

2018-08-08 Thread Bernhard Voelker
On 08/08/2018 09:39 AM, Aron Barath wrote: > * lib/fdleak.c (get_max_fd): add guard around the fd_limit variable Thanks for the patch. I'd favor to give that variable a better scope instead of adding another #if/#endif block. I'll push the attached in your name unless you have objections. Thank

next release version of findutils?

2018-08-08 Thread Karl Nordström
Hi, I wanted to ask whether there is a new release for findutils comming up? I want to add it to conda-forge and am having trouble passing make check. Partly perhaps due to inexperience, but I think some of the tests have been updated since 4.6.0. I think one such example is mbrtowc: http://

fork vs posix_spawn

2018-08-08 Thread Barath Aron
Hello, I successfully cross-compiled the findutils 4.6.0 to Threos ( see: https://threos.io ). Sadly, I had to apply some patches, namely: additional guard around an unused stack variable (see the submitted patch), and two fork-related patches (replacing "fork()" with "-1", because Threos doe

[PATCH] Do not leave fd_limit as an unused variable on the stack if getrlimit is not supported.

2018-08-08 Thread Aron Barath
* lib/fdleak.c (get_max_fd): add guard around the fd_limit variable --- lib/fdleak.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/fdleak.c b/lib/fdleak.c index 38ff8360..51b83cd9 100644 --- a/lib/fdleak.c +++ b/lib/fdleak.c @@ -109,7 +109,9 @@ get_proc_max_fd (void) static int get_m