Re: [RFA] Fix file name generation in edit_command (was: Ver 6.3 edit command failing)

2005-04-27 Thread Eli Zaretskii
> Date: Wed, 27 Apr 2005 10:36:20 -0400 > From: Daniel Jacobowitz <[EMAIL PROTECTED]> > Cc: [EMAIL PROTECTED], bug-gdb@gnu.org, [EMAIL PROTECTED] > > I can simplify this a whole lot further :-) > > You should use symtab_to_fullname. Then all the fallback logic is > unnecessary; if symtab_to_full

Re: [RFA] Fix file name generation in edit_command (was: Ver 6.3 edit command failing)

2005-04-28 Thread Eli Zaretskii
> Date: Wed, 27 Apr 2005 14:04:10 -0400 > From: Daniel Jacobowitz <[EMAIL PROTECTED]> > Cc: [EMAIL PROTECTED], bug-gdb@gnu.org, [EMAIL PROTECTED] > > It strikes me as odd that you can use "edit" if GDB doesn't know where > the source file is. I thought about that, and decided to leave that code a

Re: [RFA] Fix file name generation in edit_command (was: Ver 6.3 edit command failing)

2005-04-28 Thread Eli Zaretskii
> Date: Wed, 27 Apr 2005 14:04:10 -0400 > From: Daniel Jacobowitz <[EMAIL PROTECTED]> > Cc: [EMAIL PROTECTED], bug-gdb@gnu.org, [EMAIL PROTECTED] > > It strikes me as odd that you can use "edit" if GDB doesn't know where > the source file is. I realize this is a pre-existing condition, but... > A

Re: [RFA] Fix file name generation in edit_command (was: Ver 6.3 edit command failing)

2005-04-28 Thread Eli Zaretskii
> Date: Thu, 28 Apr 2005 16:42:01 -0400 > From: Daniel Jacobowitz <[EMAIL PROTECTED]> > Cc: [EMAIL PROTECTED], bug-gdb@gnu.org, [EMAIL PROTECTED] > > The use of "" is not a bulletproof quoting mechanism Yep, known. But it's IMHO the most portable one can get without going into the pains of quote

Re: [RFA] Fix file name generation in edit_command (was: Ver 6.3 edit command failing)

2005-04-29 Thread Eli Zaretskii
> Date: Thu, 28 Apr 2005 17:18:03 -0400 > From: Daniel Jacobowitz <[EMAIL PROTECTED]> > Cc: bug-gdb@gnu.org, [EMAIL PROTECTED] > > Or using a mechanism to start other processes that takes an argument > vector :-) Unfortunately, that's not a magic wand, either. Specifically, in the case in point,

Re: [RFA] Fix file name generation in edit_command (was: Ver 6.3 edit command failing)

2005-05-06 Thread Daniel Jacobowitz
On Wed, Apr 27, 2005 at 06:48:46PM +0300, Eli Zaretskii wrote: > Thanks for the tip. Here's the revised patch: The rest of this is mostly stylistic; a few comments... > + /* If we don't already know the full absolute file name of the > + source file, find it now. */ > + if (NULL == sal.sy

Re: [RFA] Fix file name generation in edit_command (was: Ver 6.3 edit command failing)

2005-05-06 Thread Daniel Jacobowitz
On Thu, Apr 28, 2005 at 11:36:50PM +0300, Eli Zaretskii wrote: > I ended up committing the attached. Note that it quotes the file > name, to account for possible special characters that would confise > the shell. (I use "..." for quoting because this is more portable to > various shells, includin

Re: [RFA] Fix file name generation in edit_command (was: Ver 6.3 edit command failing)

2005-05-06 Thread Daniel Jacobowitz
On Fri, Apr 29, 2005 at 12:02:27AM +0300, Eli Zaretskii wrote: > > Date: Thu, 28 Apr 2005 16:42:01 -0400 > > From: Daniel Jacobowitz <[EMAIL PROTECTED]> > > Cc: [EMAIL PROTECTED], bug-gdb@gnu.org, [EMAIL PROTECTED] > > > > The use of "" is not a bulletproof quoting mechanism > > Yep, known. But

Re: [RFA] Fix file name generation in edit_command (was: Ver 6.3 edit command failing)

2005-05-06 Thread Daniel Jacobowitz
On Wed, Apr 27, 2005 at 05:30:11PM +0300, Eli Zaretskii wrote: > > Date: Tue, 12 Apr 2005 09:58:25 -0400 > > From: [EMAIL PROTECTED] > > > > While using gdb 6.3, I was having a problem with the directory name and the > > file name being concatenated by the edit command without an intervening > >