I noticed that regex invoked alloca with unbounded size. Rather
than use the allocsa module I thought it better to stick to glibc
style, and define __libc_use_alloca when _LIBC isn't defined.
I installed this (and filed glibc bug 1245):
2005-08-25 Paul Eggert <[EMAIL PROTECTED]>
* conf
Paul Eggert <[EMAIL PROTECTED]> writes:
> Simon Josefsson <[EMAIL PROTECTED]> writes:
>
>> Ok to install?
>
> OK, with the following caveats:
>
> * Please put the standard implementation first, and the Windows implementation
> second. That'll make it easier to read.
Yup.
> * Please use standa
Bruno Haible <[EMAIL PROTECTED]> writes:
> I'm adding to gnulib-tool the support for unitary tests.
Great!
I routinely build my software on many platforms too, and I can set up
to build a gnulib megatestdir once the tests are sufficiently useful.
I'll try to write tests for my modules, but I kn
Sam Steingold <[EMAIL PROTECTED]> writes:
> a superficial code examination shows that these are indeed bugs in
> regex: build_wcs_upper_buffer should be declared to return reg_errcode_t
> and not int.
Thanks for reporting this. I installed the following patch, which I
hope covers all the C++ pro
Stepan Kasal <[EMAIL PROTECTED]> writes:
> 2005-08-25 Stepan Kasal <[EMAIL PROTECTED]>
>
> * regex.m4: If --with-included-regex was given, skip the autodetection.
Thanks; I installed that.
___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://
Stepan Kasal wrote on 2005-06-30:
> I think it's time to re-submit my patch to minmax.m4.
> A new version of the patch is attached to this mail.
>
> Again, it features:
> > - use m4_pushdef/m4_popdef instead of define/undefine
>
> As I explained before, you cannot inadvertently undefine([HEADER]).
Yuri Vasilevski <[EMAIL PROTECTED]> writes:
> Recent versions of sed expect glibc behavior form malloc, i.e.
> malloc(0) return live pointer. This is not true for uClibc (and many
> other old/classical libc implementations).
Thanks, but I'd rather not go through the glibc regex implementation
loo
Simon Josefsson <[EMAIL PROTECTED]> writes:
> Ok to install?
OK, with the following caveats:
* Please put the standard implementation first, and the Windows implementation
second. That'll make it easier to read.
* Please use standard GNU indenting style, e.g.,
char *
getpass (const char *pr
Stepan Kasal <[EMAIL PROTECTED]> writes:
> something like the attached patch (not tested)?
Yes, something like that.
For sanity's sake, I'd use the string "exitcodes" uniformly, though
(e.g., modules/exitcodes, m4/exitcodes.m4, gl_EXITCODES). And I'd
move the "#include " next to the other syste
Today I tried to use `cp' to copy a file larger than 2GB and
was surprised to get a `File too large' error.
Here's the patch I've applied to both coreutils and gnulib:
2005-08-25 Jim Meyering <[EMAIL PROTECTED]>
* open-safer.c: Include .
Otherwise, we'd lose LARGEFILE support in
Paul Eggert <[EMAIL PROTECTED]> wrote:
> I suspect that he'll say it's OK with him as long as it's no real work
> for him.
That's accurate :)
___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnulib
Hello,
On Thu, Aug 25, 2005 at 09:21:00AM -0700, Paul Eggert wrote:
> > What would be wrong with the following patch?
>
> Synchronization with glibc. mktime.c is shared with the GNU C
> Library, and glibc doesn't have intprops.h.
thanks for explanation. I'm dropping the patch.
> I suppose tha
Bruno Haible <[EMAIL PROTECTED]> writes:
> What's the right way to fill the struct timezone?
Don't fill it in at all. Don't even look at the pointer to it. POSIX
says portable applications must always pass NULL, but I wouldn't even
rely on that.
>> I have two questions: Would you consider inte
Stepan Kasal <[EMAIL PROTECTED]> writes:
> What would be wrong with the following patch?
Synchronization with glibc. mktime.c is shared with the GNU C
Library, and glibc doesn't have intprops.h.
I suppose that we could migrate intprops.h into glibc, but that would
be a bigger project and we're
Hello,
On Thu, Aug 25, 2005 at 05:06:55PM +0200, Bruno Haible wrote:
> AC_INIT(regexp, 1.0, clisp-list)
> +AC_GNU_SOURCE
> AC_CONFIG_SRCDIR(regexp.lisp)
> That might be a little too early, [...]
> I would put it after the determination of CC and CPP, but
> before all AC_CHECK_HEADER and AC_CHE
On Thu, 25. Aug 2005, 15:32:00 +0200, Bruno Haible wrote:
> > If so, how can this be done?
>
> It can be done by merging your .m4 file with Jim's one, and put a big
> #if inside lib/gettimeofday.c.
OK, I had no better idea than defining GETTIMEOFDAY_USE_REPLACEMENTS if
the replacement functions
Hello,
On Sat, Aug 13, 2005 at 07:30:21PM -0500, Albert Chin wrote:
> Look at how glib solves a similar problem. Of course, they define
> their own types but they install a platform-specific .h file in
> $prefix/lib/include (glibconfig.h). This is similar to the
> gnutls-config.h suggested by Step
Hello,
On Thu, Aug 25, 2005 at 09:36:12AM -0400, Sam Steingold wrote:
> But I do not have lib/regex.c!
> I have regex.c in the current directory!
> Is it OK?
yes, it is.
Stepan
___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailm
Sam Steingold wrote:
> But I do not have lib/regex.c!
> I have regex.c in the current directory!
> Is it OK?
Yes, it is OK since clisp is not using automake. Only in projects with a
Makefile.am it is a problem if you don't put the AC_LIBSOURCEd files into
lib/.
Bruno
__
Stepan Kasal wrote:
> There was one remaining problem: AC_GNU_SOURCE has to be called early in
> configure.ac.
> ...
@@ -4,6 +4,7 @@
AC_PREREQ(2.57)
AC_INIT(regexp, 1.0, clisp-list)
+AC_GNU_SOURCE
AC_CONFIG_SRCDIR(regexp.lisp)
AC_CONFIG_AUX_DIR(../../src/build-aux)
AC_CONFIG_HEADERS(config.h
Hello,
regarding this old patch:
On Mon, Mar 14, 2005 at 04:46:10PM -0800, Paul Eggert wrote:
> When I updated intprops.h I forgot to make similar modifications to
> mktime.c and strtol.c. I installed this patch to fix that.
>
> 2005-03-14 Paul Eggert <[EMAIL PROTECTED]>
>
> * mktime.
> * Stepan Kasal <[EMAIL PROTECTED]> [2005-08-25 11:06:00 +0200]:
>
> On Wed, Aug 24, 2005 at 10:30:44PM -0400, Sam Steingold wrote:
>> gnulib CVS head does not contain gl_INCLUDED_REGEX.
>
> (gl_REGEX): Don't bother checking whether lib/regex.c exists;
> assume that it does.
>
> The first change m
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
According to Bruno Haible on 8/25/2005 6:13 AM:
> An update of the --version output.
>
> ! echo "Copyright (C) 2002-2005 Free Software Foundation, Inc.
Don't the coding standards state that the --version output need only be
the most recent year, an
Hi,
Martin Lambers wrote:
> I'd like to provide a gettimeofday() function for systems that do not
> have it (at least Win32).
>
> I already wrote a module that works, see below. But this module
> overwrites the existing gettimeofday module. I do not know how to
> integrate the changes into the exi
Sam Steingold wrote:
> gnulib CVS head does not contain gl_INCLUDED_REGEX.
Paul removed this macro; you need to call gl_REGEX without arguments, now.
Bruno
___
bug-gnulib mailing list
bug-gnulib@gnu.org
http://lists.gnu.org/mailman/listinfo/bug-gnuli
Hi all,
C code generally doesn't work unless it's tested.
Simon added a test for the 'getpass' module yesterday, but no "make check"
actually runs it. So it resembles dead code. Let's change that!
Nelson Beebe has a zoo of different platforms, and now and then he reports
portability problems abo
Hello,
On Wed, Aug 24, 2005 at 10:20:08PM -0700, Paul Eggert wrote:
> Let's please just define [EX_OK] to 0; [...]
>
> I also like Simon's suggestion of defining EXIT_SUCCESS and
> EXIT_FAILURE in config.h, [...]
something like the attached patch (not tested)?
Stepan
diff -urpN gnulib/lib/.cpp
Paul Eggert <[EMAIL PROTECTED]> writes:
> Simon Josefsson <[EMAIL PROTECTED]> writes:
>
>> The resulting code would look awful, and I think it would be weird to
>> have plenty of non-glibc specific hacks inside glibc. But keeping
>> things in sync is a good idea, and I can work toward that goal f
This patch makes --aux-dir work for the other modes than --import.
* gnulib-tool: Add support for the --aux-dir option to
--create-testdir, --create-megatestdir, --test, --megatest.
(func_create_testdir, func_create_megatestdir): Optionally emit a
AC_CONFIG_AUX_DIR
An update of the --version output.
* gnulib-tool (func_version): Update.
*** gnulib-tool.bak 2005-08-25 02:05:40.0 +0200
--- gnulib-tool 2005-08-25 02:14:54.0 +0200
***
*** 108,117
func_version ()
{
echo "$progname (GNU $package) $version"
!
Alexandre Duret-Lutz recommends that all autoconf macro invocations should
quote their arguments. This patch does it in gnulib-tool.
* gnulib-tool (func_import, func_create_testdir,
func_create_megatestdir): Quote all autoconf macro arguments.
*** gnulib-tool.bak 2005-08-16 13
Hello,
would you accept this patch?
Stepan Kasal
2005-08-25 Stepan Kasal <[EMAIL PROTECTED]>
* regex.m4: If --with-included-regex was given, skip the autodetection.
Index: m4/regex.m4
===
RCS file: /cvsroot/gnulib/gnulib
Currently, a megatestdir will, during the first "./configure; make",
rebuild config.h, requiring autoconf and automake in the PATH. This fixes it.
* gnulib-tool (func_create_megatestdir): Call autoreconf without the
option --force, because --force causes the aclocal.m4 of each
The default --aux-dir of "." clutters up the top-level directory.
Now that have agreed on a reasonable name for this directory, gnulib-tool
does not need to do this any more. I'm changing the default --aux-dir
to "build-aux".
Note: This is an INCOMPATIBLE change. You need to add an option
--aux-di
This change is to use { ... } syntax instead of ( ... ) where possible.
( ... ) causes a subshell to be fork()ed, { ... } doesn't.
* gnulib-tool (import): Use compound statement instead of subshell
where possible.
*** gnulib-tool.bak 2005-08-25 00:56:16.0 +0200
--- gn
Hello,
On Thu, Aug 25, 2005 at 11:06:00AM +0200, Stepan Kasal wrote:
> Indeed, when I cp ../gnulib/m4/regex.m4 src/m4/
> and apply the patch attached below, then
>
> make -f Makefile.devel check-configures
I forgot to attach the patch, sorry.
Please find it attached to this mail.
Stepan
Hello,
On Wed, Aug 24, 2005 at 10:30:44PM -0400, Sam Steingold wrote:
> gnulib CVS head does not contain gl_INCLUDED_REGEX.
Indeed:
revision 1.42
date: 2005/08/23 18:48:31; author: eggert; state: Exp; lines: +95 -109
* regex.m4 (gl_INCLUDED_REGEX): Remove; no longer used.
All contents moved t
37 matches
Mail list logo
