fix in vasnprintf.c

2006-01-23 Thread Bruno Haible
Hi, I committed this patch in lib/vasnprintf.c. Fixes a too low estimate of the size of an sprintf result, leading to a buffer overflow. Fortunately most platforms have either a snprintf() or _snprintf() function, and lib/vasnprintf.c uses this if available. Otherwise it would have been a security

Re: $(EXEEXT) in TESTS required?

2006-01-23 Thread Bruno Haible
[For the automake people: The problem is that a Makefile.am snippet like TESTS = test-lock check_PROGRAMS = test-lock test_LOCK_LDFLAGS = -lmyspeciallib when cross-compiling to mingw on a Unix system with 'wine', will cause "make check" to build 'test-lock', rather than 'test-lock.

Re: [bug-gnulib] tls-tests and lock-tests

2006-01-23 Thread Bruno Haible
Simon Josefsson wrote: > 2006-01-19 Simon Josefsson <[EMAIL PROTECTED]> > > + * modules/lock-tests, modules/tls-tests: Use check_PROGRAMS > + instead of noinst_PROGRAMS to be able to remove test_*_SOURCES. > + Thanks, I have applied the uncontroversial part of it, not the $(EXEEXT), whi

Re: [bug-gnulib] socket.h

2006-01-23 Thread Bruno Haible
Simon Josefsson wrote: > +#if !defined(SHUT_WR) && defined (SD_SEND) > +# define SHUT_WR 1 > +#endif > +#if !defined(SHUT_RDWR) && defined (SD_BOTH) > +# define SHUT_RDWR 2 > +#endif Is SD_SEND == 1 and SD_BOTH == 2 ? Bruno ___ bug-gnulib mailing lis

Re: socket.h

2006-01-23 Thread Jim Meyering
Simon Josefsson <[EMAIL PROTECTED]> wrote: > For some reason, mingw32 uses non-POSIX names for shutdown's ... > --- socket_.h 09 Jan 2006 17:13:09 +0100 1.1 > +++ socket_.h 19 Jan 2006 14:39:07 +0100 > @@ -34,4 +34,15 @@ > # include > #endif > > +/* For shutdown(). */ > +#if !defined(SHUT_RD)

Re: socket.h

2006-01-23 Thread Paul Eggert
Jim Meyering <[EMAIL PROTECTED]> writes: > I find that those parentheses provide no benefit. Although coreutils > doesn't use that module, it might be worthwhile to start following the > same guideline in gnulib. I've never run into a compiler that didn't support "defined FOO", and I don't see a

srclist.txt comments update for glibc

2006-01-23 Thread Paul Eggert
I installed this: 2006-01-23 Paul Eggert <[EMAIL PROTECTED]> * config/srclist.txt: Adjust to reflect glibc reorganization. This affects only comments. --- config/srclist.txt 20 Jan 2006 21:18:53 - 1.111 +++ config/srclist.txt 24 Jan 2006 07:13:46 - 1.112 @@

Re: portability fix for bison-1.75

2006-01-23 Thread Paul Eggert
Dieter <[EMAIL PROTECTED]> writes: > Compiling [Bison] 2.1 gives: > > ../../lib/getopt.c:127: warning: function declaration isn't a prototype > ../../lib/quotearg.c:591: warning: comparison is always false due to limited > range of data type > ../../lib/strndup.c:39: warning: no previous prototyp