Re: rules, rules, and more (code policy) rules

2006-02-10 Thread Simon Josefsson
Jim Meyering [EMAIL PROTECTED] writes: Simon Josefsson [EMAIL PROTECTED] wrote: Jim Meyering [EMAIL PROTECTED] writes: I tend to forget, too, so have automated quite a few policy checks, over the years. You might try adding some checks like those in coreutils' Makefile.maint. Here are the

Re: rules, rules, and more (code policy) rules

2006-02-10 Thread Simon Josefsson
A lot of the tests look like: sc_cast_of_argument_to_free: @grep -E '\free \(\(' $(srcdir)/{lib,src}/*.[chly] \ I.e., the paths and filenames are hardcoded. Using 'find . -name *.[chly]` seem more appropriate. Or? Some tests do: sc_space_tab: @( $(CVS_LIST) )

Re: rules, rules, and more (code policy) rules

2006-02-10 Thread Jim Meyering
Simon Josefsson [EMAIL PROTECTED] wrote: I'm going through Coreutils GNUmakefile and Makefile.maint to identify useful rules. Some question pop up: 1) Is this rule generally safe? Does it assume GNU tar? Is there a real problem solved by this, or is it just nice? # Make tar archive

Re: rules, rules, and more (code policy) rules

2006-02-10 Thread Paul Eggert
Jim Meyering [EMAIL PROTECTED] writes: For example, here's the change I've just made so that the rule works even when gzip doesn't support the --rsyncable option: Thanks. That reminds me, I had made several changes to Bison's Makefile.maint (one of which did something similar for --rsyncable,

Re: rules, rules, and more (code policy) rules

2006-02-10 Thread Jim Meyering
Paul Eggert [EMAIL PROTECTED] wrote: 2006-02-10 Paul Eggert [EMAIL PROTECTED] * Makefile.maint (CVS_LIST): Don't assume cvsu is available. (CVS_LIST_EXCEPT): New macro, to simplify exception-processing. Most uses of CVS_LIST changed to use CVS_LIST_EXCEPT. ... Thanks for