Re: maintainer-makefile troubles and suggestions

2010-01-21 Thread Ben Pfaff
Martin von Gagern writes: > sc_prohibit_atoi_atof: > -- > > The comment claims that [fs]?scanf doesn't provide error feedback. The > "return value" section of my scanf(3) man page says differently: the > number of successful conversions is returned, which is quite a suitable >

Re: maintainer-makefile troubles and suggestions

2010-01-21 Thread Jim Meyering
Martin von Gagern wrote: > On 21.01.2010 17:10, Eric Blake wrote: >> Thanks for all the feedback! > > I've got two more. > > sc_prohibit_atoi_atof: > -- > > The comment claims that [fs]?scanf doesn't provide error feedback. The > "return value" section of my scanf(3) man page sa

Re: maintainer-makefile troubles and suggestions

2010-01-21 Thread Martin von Gagern
Hi Eric! On 21.01.2010 17:10, Eric Blake wrote: > Thanks for all the feedback! I've got two more. sc_prohibit_atoi_atof: -- The comment claims that [fs]?scanf doesn't provide error feedback. The "return value" section of my scanf(3) man page says differently: the number of s

Re: [PATCH 1/2] top/maint.mk: Fix VC_LIST_EXCEPT for srcdir != builddir

2010-01-21 Thread Jim Meyering
Jim Meyering wrote: > Here are a pair of maint.mk patches. > The first is from Jiri Denemark and makes VC_LIST-using > rules like "make syntax-check" also work when run from > a non-srcdir build. > > The second tweaks things so that the pre-filter works robustly > even when $(srcdir) contains a '.'

Re: Improvements for maint.mk

2010-01-21 Thread Eric Blake
Martin von Gagern gmx.net> writes: > As for the copyright: I've already assigned copyright for wdiff to the fsf. > Do I have to repeat all the paperwork, or can I simply commit my > modifications to the wdiff tree in order to make them officially owned by > the FSF? It would be best if you repea

Re: maintainer-makefile troubles and suggestions

2010-01-21 Thread Eric Blake
Martin von Gagern gmx.net> writes: > Here's a list of things that either caused me trouble or made me think. > Some aspects of it involve parts of gnulib besides maint.mk. Thanks for all the feedback! I haven't looked closely at your fixes or at any of the points where you haven't yet provided

[PATCH 1/2] top/maint.mk: Fix VC_LIST_EXCEPT for srcdir != builddir

2010-01-21 Thread Jim Meyering
Here are a pair of maint.mk patches. The first is from Jiri Denemark and makes VC_LIST-using rules like "make syntax-check" also work when run from a non-srcdir build. The second tweaks things so that the pre-filter works robustly even when $(srcdir) contains a '.'. I'll push these as soon as I a

Re: [PATCH 4/4] maint.mk: Imporved LINGUAS generation.

2010-01-21 Thread Martin von Gagern
On 21.01.2010 15:39, Martin von Gagern wrote: > + sed -ie '/^[a-z]/d' $(PODIR)/LINGUAS ^^^ That should have been "-i -e" instead, as the -i option to sed takes an optional argument. Sorry. I've incorporated my changes into wdiff by now: http://bzr.savannah.gnu.org/lh/wdiff/trunk/r

[PATCH 4/4] maint.mk: Imporved LINGUAS generation.

2010-01-21 Thread Martin von Gagern
This change avoids duplicates for e...@boldquot and e...@quot. It also ensures that the list is completely sorted and that any comment lines preceding the list of linguas will be preserved. Non-lingua lines following the list of linguas will be moved in front of the linguas, so it is suggested to

[PATCH 3/4] maint.mk: Update translations using rsync instead of wget.

2010-01-21 Thread Martin von Gagern
Checksums (-c) are used instead of timestamps (-t) to check whether a file is already up to date. This allows integration with version control systems that usually don't preserve timestamps. The listing of files was changed from verbose (-v) to itemize (-i) so it becomes easier to distinguish upd

[PATCH 2/4] maint.mk: cache VC_LIST output.

2010-01-21 Thread Martin von Gagern
Several syntax checks work on the list of all versioned files. Regenerating this list for every such check can be quite time-consuming. To avoid this, a wrapper target could generate this list once, perform all checks, and clean up the list afterwards. As an added benefit, this allows us to pass

[PATCH 1/4] vc-list-files: List bzr files recursively.

2010-01-21 Thread Martin von Gagern
bzr ls isn't recursive by default, so we have to add the "--recursive" flag. The short form would have been "-R", but as the script uses "--versioned" instead of "-V", using the long option seems more consistent. --- build-aux/vc-list-files |4 ++-- 1 files changed, 2 insertions(+), 2 deletion

Improvements for maint.mk

2010-01-21 Thread Martin von Gagern
Hello! As I just wrote a lengthy email of issues I noticed with maint.mk, here are a few patches dealing with some of them. I hope you can apply them to gnulib. As for the copyright: I've already assigned copyright for wdiff to the fsf. Do I have to repeat all the paperwork, or can I simply comm

maintainer-makefile troubles and suggestions

2010-01-21 Thread Martin von Gagern
Hi there! I've got a few troubles with the maintainer-makefile module. Basically I'm just trying to get "make beta" to work (on my GNU wdiff development tree, where I just imported it). Here's a list of things that either caused me trouble or made me think. Some aspects of it involve parts of gnu

Re: use warn-on-use rather than link-warning

2010-01-21 Thread Jim Meyering
Eric Blake wrote: > According to Eric Blake on 1/11/2010 7:00 AM: >> As promised, here's the conversion to drop all use of GL_LINK_WARNING >> within gnulib for the newer _GL_WARN_ON_USE. > > This patch is now applied. Let me know if there is any fallout that I > need to help fix. Looks good to me

Re: use warn-on-use rather than link-warning

2010-01-21 Thread Eric Blake
According to Eric Blake on 1/11/2010 7:00 AM: > As promised, here's the conversion to drop all use of GL_LINK_WARNING > within gnulib for the newer _GL_WARN_ON_USE. > This patch is now applied. Let me know if there is any fallout that I need to help fix. -- Don't work too hard, make some time