Re: LONG_LONG_MIN

2010-03-08 Thread Jim Meyering
Bruno Haible wrote: Compiling a gnulib testdir on Solaris/x86 with Sun C, I get these errors: cc -O -xc99=all -DHAVE_CONFIG_H -DEXEEXT=\\ -DEXEEXT=\\ -DNO_XMALLOC -DEXEEXT=\\ -I. -I.. -I../intl -I/home/haible/prefix-x86/include -D_REENTRANT -g -c -o xstrtoll.o xstrtoll.c xstrtol.c,

C++ libtool build error?

2010-03-08 Thread Simon Josefsson
Recently gnulib added some self-tests written in C++ for otherwise C-only modules. When imported into libidn (otherwise a strictly C library), this leads to an error message: /bin/bash ../libtool --preserve-dup-deps --mode=link g++ -o test-fcntl-h-c++ test-fcntl-h-c++.o libtests.a

Re: arg-nonnull.h warn-on-use.h in build-aux

2010-03-08 Thread Sam Steingold
Sam Steingold wrote: Alternatively, I would be reasonably happy with sed -i -e 's/_GL_ARG_NONNULL/GL_ARG_NONNULL/' arg-nonnull.h sed -i -e 's/_GL_WARN_ON_USE/GL_WARN_ON_USE/' warn-on-use.h similar to GL_LINK_WARNING in link-warning.h. So, any chance the constants in arg-nonnull.h

Re: arg-nonnull.h warn-on-use.h in build-aux

2010-03-08 Thread Eric Blake
On 03/08/2010 11:34 AM, Sam Steingold wrote: Sam Steingold wrote: Alternatively, I would be reasonably happy with sed -i -e 's/_GL_ARG_NONNULL/GL_ARG_NONNULL/' arg-nonnull.h sed -i -e 's/_GL_WARN_ON_USE/GL_WARN_ON_USE/' warn-on-use.h similar to GL_LINK_WARNING in link-warning.h. So, any

Re: [PATCH] (x)memcoll: performance improvement when input is known to be NUL delimited.

2010-03-08 Thread Bruno Haible
Hi Chen, Thanks for your submission! I think your patch is a useful addition to the 'memcoll' and 'xmemcoll' modules. The code in gnulib should be copyright-assigned to the FSF. This is necessary, in order to be on the safe side, legally, should disputes à la SCO happen in the future. Is it a

documenting use of git submodule

2010-03-08 Thread Eric Blake
Given the recent commit to describe how to use a moderate approach, where some, but not all, gnulib files are checked into version control, I was inspired to re-read the section about the minimalistic approach. Any objections to this patch? Should I add more details on git commands used for

Re: documenting use of git submodule

2010-03-08 Thread Jim Meyering
Eric Blake wrote: Given the recent commit to describe how to use a moderate approach, where some, but not all, gnulib files are checked into version control, I was inspired to re-read the section about the minimalistic approach. Any objections to this patch? Should I add more details on git

[PATCH] gnulib-tool.texi: mention possibility of git submodule

2010-03-08 Thread Eric Blake
* doc/gnulib-tool.texi (VCS Issues): Add details about using git submodules. * doc/.gitignore: Ignore another generated file. Signed-off-by: Eric Blake ebl...@redhat.com --- Should I add more details on git commands used for creating an initial gnulib submodule, as well as ideas on how to

Re: [PATCH] (x)memcoll: performance improvement when input is known to be NUL delimited.

2010-03-08 Thread Chen Guo
Hi Bruno, I'll make all the changes you proposed, except this I have some questions about: For each input line, xmemcoll is called multiple times? Then you can certainly gain much more speed than 1% by replacing memcoll with 2 x memxfrm and 1 x memcmp2. Of course, the 'sort' program

Re: C++ libtool build error?

2010-03-08 Thread Bruno Haible
Hi Simon, Recently gnulib added some self-tests written in C++ for otherwise C-only modules. When imported into libidn (otherwise a strictly C library), this leads to an error message: /bin/bash ../libtool --preserve-dup-deps --mode=link g++ -o test-fcntl-h-c++ test-fcntl-h-c++.o

gnulib-tool: allow --libtool with --create-testdir

2010-03-08 Thread Bruno Haible
Hi, Currently, when using gnulib-tool --create-testdir --libtool, error messages appear, because ltmain.sh and libtool.m4 are not installed. This fixes it. 2010-03-08 Bruno Haible br...@clisp.org gnulib-tool: Add support for --libtool in --create-testdir. * gnulib-tool

Re: [PATCH] (x)memcoll: performance improvement when input is known to be NUL delimited.

2010-03-08 Thread Chen Guo
Hi Bruno, I'm going through and applying your suggestions, and I'm a bit iffy on this one: +/* Like memcoll, but S1 and S2 are known to be NUL delimited, thus no + modification to S1 or S2 are needed. */ +int +memcoll_nul (char *s1, size_t s1len, char *s2, size_t s2len) +{ +

New stable snapshot

2010-03-08 Thread Ian Beckwith
Hi, I've released a new stable snapshot. See attached NEWS.stable for details. Feedback welcome. Tarball: http://erislabs.net/ianb/projects/gnulib/gnulib-20100308-stable.tar.gz Gitweb: http://erislabs.net/gitweb?p=gnulib.git;a=shortlog;h=refs/heads/stable Git: git://erislabs.net/gnulib.git tag

[PATCH] gnulib-tool (LIBTOOLPATH): Fix cut'n'paste bug.

2010-03-08 Thread Simon Josefsson
I've pushed this, because gnulib-tool failed with: executing autopoint --copy autopoint: unknown option --copy Try 'autopoint --help' for more information. /Simon --- ChangeLog |4 gnulib-tool |2 +- 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/ChangeLog