Re: havelib tests

2010-03-30 Thread Ralf Wildenhues
Hi Bruno, * Bruno Haible wrote on Wed, Mar 31, 2010 at 01:57:25AM CEST: > In theory it would be possible to extract the history of this chunk of code > from the GNU gettext git repository and merge (oops, rebase) it into the > gnulib > repository. If anything, then merging would be the way to go

Re: havelib tests

2010-03-30 Thread Jim Meyering
Bruno Haible wrote: > Now that gnulib has a way to store long-running and unportable tests, I would > like to move the 'havelib' testsuite from a GNU gettext subdirectory > > > to gnulib. > > This testsuite is e

havelib tests

2010-03-30 Thread Bruno Haible
Hi, Now that gnulib has a way to store long-running and unportable tests, I would like to move the 'havelib' testsuite from a GNU gettext subdirectory to gnulib. This testsuite is essential when anyone modifie

[PATCH] gnumakefile: don't squelch _version output

2010-03-30 Thread Eric Blake
Borrowing from a trick I discovered on the libvirt list. * top/GNUmakefile (GNUmakefile): Create one-shot dependency rather than using $(shell) to run _version target. (_autoreconf): Run verbosely, by default. Signed-off-by: Eric Blake --- This was quite tricky to implement. I've tested (with

Re: [PATCH 1/3] Macro _header_without_use renamed to _sc_header_without_use in maint.mk

2010-03-30 Thread Jose E . Marchesi
> This looks pretty clear cut. > I'll push this along with the others once I've tested. This one is fine, and independent, so I've pushed it. The only tweak I recall was to the one-line summary: maint.mk: s/_header_without_use/_sc_header_without_use/ (and

Re: [PATCH 1/3] Macro _header_without_use renamed to _sc_header_without_use in maint.mk

2010-03-30 Thread Jim Meyering
Jim Meyering wrote: > Jose E. Marchesi wrote: >> Subject: [PATCH 1/3] Macro _header_without_use renamed to >> _sc_header_without_use in maint.mk > > Thanks, Jose. > This looks pretty clear cut. > I'll push this along with the others once I've tested. This one is fine, and independent, so I've pus

Re: [PATCH 2/2] maint: use pragma consistently across replacement headers

2010-03-30 Thread Jim Meyering
Bruno Haible wrote: > Hi Eric, > >> but for the remaining files, we might as >> well satisfy gcc's optimization, since the effort is trivial. >> >> Please apply. > > Applied. > >> Hmm, if we were using cppi more religiously, I wouldn't have introduced >> the whitespace usage in that #if in the firs

[PATCH] maint: improve module indicators

2010-03-30 Thread Eric Blake
* m4/gnulib-common.m4 (gl_MODULE_INDICATOR_SET_VARIABLE) (gl_MODULE_INDICATOR, gl_MODULE_INDICATOR_FOR_TESTS): Fit in 80 columns, and avoid extra macro expansion. Signed-off-by: Eric Blake --- No change in the output, but only because we got lucky that none of the function names that we had been

[PATCH] fdopendir: work around FreeBSD bug

2010-03-30 Thread Eric Blake
Without a declaration, at least tar would core dump on 64-bit FreeBSD because gcc only used 32 bits of the resulting pointer. * m4/dirent_h.m4 (gl_DIRENT_H_DEFAULTS): New witness. * m4/fdopendir.m4 (gl_FUNC_FDOPENDIR): Set it. * modules/dirent (Makefile.am): Substitute it. * lib/dirent.in.h (fdope

Zile build breaks in lib/btow.c on NetBSD 1.5

2010-03-30 Thread Hauke Fath
Hi, trying to build Zile 2.3.15 on an older NetBSD release (1.5), I have run into problems compiling lib/btow.c. The project maintainer pointed me in the direction of gnulib. The preprocessor magic in lib/wchar.h