Re: bashisms

2010-05-19 Thread Ralf Wildenhues
Hello Ian, * Ian Beckwith wrote on Wed, May 19, 2010 at 03:54:52AM CEST: * trap with signal numbers According to http://www.opengroup.org/onlinepubs/009695399/utilities/trap.html (btw, am I right in saying The Open Group Base Specifications Issue 6 IEEE Std 1003.1, 2004 Edition is POSIX, or

Re: valgrind-tests.m4

2010-05-19 Thread Ralf Wildenhues
* Simon Josefsson wrote on Tue, May 18, 2010 at 09:36:44AM CEST: Ralf Wildenhues writes: Well, one could prepend LOG_COMPILER (the default variable that doesn't go with any specified extension) or have the developer specify some other extension. Your macro could just set some variable that

Re: valgrind-tests.m4

2010-05-19 Thread Simon Josefsson
Ralf Wildenhues ralf.wildenh...@gmx.de writes: * Simon Josefsson wrote on Tue, May 18, 2010 at 09:36:44AM CEST: Ralf Wildenhues writes: Well, one could prepend LOG_COMPILER (the default variable that doesn't go with any specified extension) or have the developer specify some other

Re: [PATCH 00/15] Add libunistring-optional module

2010-05-19 Thread Paolo Bonzini
Here's what I'm committing, based on your original patches. This shows only the non-repetitive part of the commit. For the entire commit, please look in git. Nice. Thanks for following up. Two comments: 1) Is it so bad to drop the complicated code for 0.9-0.9.3 version detection, and just

Re: init.sh: enable MALLOC_PERTURB_

2010-05-19 Thread Paolo Bonzini
On 05/16/2010 02:05 PM, Bruno Haible wrote: enum { a, b, c }; int function (int n) { extern int (* verify_function5 (void)) [(!!sizeof (struct { unsigned int verify_error_if_negative_size__: (c == 2) ? 1 : -1; }))]; return 0; } What version of GCC? I think you should report it to the

Re: valgrind-tests.m4

2010-05-19 Thread Bruno Haible
Simon Josefsson wrote: my patch invokes valgrind with -q so that it does not output anything, unless there are errors, of course Oh, I see. Indeed. But it spends a lot of time in make check, and does not exploit the full information that valgrind could provide. For a test, I ran make check in

Re: bashisms

2010-05-19 Thread Brian K. White
On 5/19/2010 2:30 AM, Ralf Wildenhues wrote: Hello Ian, * Ian Beckwith wrote on Wed, May 19, 2010 at 03:54:52AM CEST: * trap with signal numbers According tohttp://www.opengroup.org/onlinepubs/009695399/utilities/trap.html (btw, am I right in saying The Open Group Base Specifications

Re: [PATCH 00/15] Add libunistring-optional module

2010-05-19 Thread Bruno Haible
Hi Paolo, 1) Is it so bad to drop the complicated code for 0.9-0.9.3 version detection, and just assume 0.9 if the hexversion is 9? It may be possible three years from now. But currently, 0.9.3 is the newest version available, and you'll notice that many modules carry 0.9.1 or 0.9.3 as minimum

Re: bashisms

2010-05-19 Thread Ben Pfaff
Brian K. White br...@aljex.com writes: I would have thought the portability concern would be the meanings of the numbers more than the allowance of numbers in the syntax. Even within a single OS linux, even within a single version, the meanings of signals above 16 differ between

Re: bashisms

2010-05-19 Thread Eric Blake
On 05/19/2010 12:30 AM, Ralf Wildenhues wrote: POSIX requires signals specified as names (HUP, INT, etc), although XSI allows numbers for certain signals (the ones used by gnulib all fall into this category). We've had a similar discussion about this on an Autoconf list a while ago (with a

Re: [PATCH 00/15] Add libunistring-optional module

2010-05-19 Thread Paolo Bonzini
On 05/19/2010 10:19 AM, Bruno Haible wrote: 2) What's the purpose of gl_LIBUNISTRING_VERSION_CMP_ORIG? It serves as a backup, for the case that some day we need to pass computed versions instead of literal versions. So we can delete it, git will find it and the ChangeLog will say what

AS_LITERAL_IF (was: Re: [PATCH 00/15] Add libunistring-optional module)

2010-05-19 Thread Bruno Haible
And AS_LITERAL_IF was not documented in Autoconf 2.64. gnulib allows you to program (mostly) to Autoconf 2.64 interfaces. If Eric adds AS_LITERAL_IF to m4/00gnulib.m4, I'll gladly use it in gl_LIBUNISTRING_VERSION_CMP. Bruno

Re: AS_LITERAL_IF

2010-05-19 Thread Eric Blake
On 05/19/2010 01:38 PM, Bruno Haible wrote: And AS_LITERAL_IF was not documented in Autoconf 2.64. gnulib allows you to program (mostly) to Autoconf 2.64 interfaces. If Eric adds AS_LITERAL_IF to m4/00gnulib.m4, I'll gladly use it in gl_LIBUNISTRING_VERSION_CMP. I don't need to.

Re: init.sh: enable MALLOC_PERTURB_

2010-05-19 Thread Bruno Haible
Hi Paolo, What version of GCC? ... I cannot reproduce it with either Fedora 12 or upstream GCC 4.5.0. gcc -v says: gcc version 4.3.1 20080507 (prerelease) [gcc-4_3-branch revision 135036] (SUSE Linux) I think you should report it to the suse bugzilla, I would do so if there was

libunistring: add a valgrind suppressions file

2010-05-19 Thread Bruno Haible
This patch adds a file that can be used with valgrind's --suppressions option. 2010-05-19 Bruno Haible br...@clisp.org Avoid valgrind error reports from libunistring. * lib/libunistring.valgrind: New file, based on lib/malloca.valgrind. * modules/libunistring (Files):

Re: AS_LITERAL_IF

2010-05-19 Thread Bruno Haible
Eric Blake wrote: AS_LITERAL_IF has been available since 2.59. Whether or not it was documented that far back, it already had the right semantics that far back. Thanks for this confirmation. So, I'm doing what Paolo suggested: 2010-05-19 Bruno Haible br...@clisp.org Clean up dead

Re: bashisms

2010-05-19 Thread Ian Beckwith
Hi, On Wed, May 19, 2010 at 08:30:13AM +0200, Ralf Wildenhues wrote: We've had a similar discussion about this on an Autoconf list a while ago (with a Debian maintainer). The Autoconf manual, Shell Portability chapter, lists 1 2 13 15 as signals which are safe to trap. I'm not aware of any

Re: valgrind-tests.m4

2010-05-19 Thread Ralf Wildenhues
Hi Simon, I like this patch, with one small nit: * Simon Josefsson wrote on Wed, May 19, 2010 at 08:41:29AM CEST: +This will run all self-checks under valgrind. This can be wasteful if +you have many shell scripts or other non-binaries. Using the Automake +parallel-tests feature, this can