Re: maint.mk sc_prohibit_always-defined_macros complains about build-aux/warn-on-use.h

2010-05-25 Thread Jim Meyering
Bruno Haible wrote: > Hi Eric, > >> While it may be possible to modify gnulib's warn-on-use.h to >> avoid triggering this false positive in a comment > > Even better: Avoid the false positive. Jim has a sed expression for > eliminating comments from C source code in cfg.mk [1]. You could use > that

Re: maint.mk sc_prohibit_always-defined_macros complains about build-aux/warn-on-use.h

2010-05-25 Thread Jim Meyering
Martin von Gagern wrote: > Hi there! > > I've got gnulib in my repository, so devs don't need a git checkout. > When I last ran the syntax checks from maint.mk, I got a false positive > from prohibit_always-defined_macros complaining about the definition of > environ in build-aux/warn-on-use.h. >

Re: maint.mk sc_prohibit_always-defined_macros complains about build-aux/warn-on-use.h

2010-05-25 Thread Bruno Haible
Hi Eric, > While it may be possible to modify gnulib's warn-on-use.h to > avoid triggering this false positive in a comment Even better: Avoid the false positive. Jim has a sed expression for eliminating comments from C source code in cfg.mk [1]. You could use that as a filter, to avoid the false

Re: maint.mk sc_prohibit_always-defined_macros complains about build-aux/warn-on-use.h

2010-05-25 Thread Eric Blake
On 05/25/2010 02:21 PM, Martin von Gagern wrote: > Hi there! > > I've got gnulib in my repository, so devs don't need a git checkout. > When I last ran the syntax checks from maint.mk, I got a false positive > from prohibit_always-defined_macros complaining about the definition of > environ in bui

maint.mk sc_prohibit_always-defined_macros complains about build-aux/warn-on-use.h

2010-05-25 Thread Martin von Gagern
Hi there! I've got gnulib in my repository, so devs don't need a git checkout. When I last ran the syntax checks from maint.mk, I got a false positive from prohibit_always-defined_macros complaining about the definition of environ in build-aux/warn-on-use.h. The error is due to the following line

maint.mk sc_prohibit_always_true_header_tests: bad cd

2010-05-25 Thread Martin von Gagern
Hi there! Running "make sc_prohibit_always_true_header_tests" causes a cd invocation to fail, without make aborting: > prohibit_always_true_header_tests > /bin/sh: line 0: cd: ./gnulib/lib: No such file or directory It would be nice to actually check that $(gnulib_dir) exists, and either skip th

Re: gettext 0.17 legacy

2010-05-25 Thread Bruno Haible
Hi Martin, > Commit 190bf61ecbb3727a3dd742498938be9e251f9315 on 2010-05-09 updated > gettext from 0.17 to 0.18, but left the file build-aux/po/Makefile.in.in > in its old form from gettext-0.17. This will cause problems for packages > that use separate po files for gnulib. You're entirely right.

gettext 0.17 legacy

2010-05-25 Thread Martin von Gagern
Hi there! Commit 190bf61ecbb3727a3dd742498938be9e251f9315 on 2010-05-09 updated gettext from 0.17 to 0.18, but left the file build-aux/po/Makefile.in.in in its old form from gettext-0.17. This will cause problems for packages that use separate po files for gnulib. Greetings, Martin von Gagern

Re: git-changelog package?

2010-05-25 Thread Bruno Haible
Hi Simon, > Good idea, and, yes! OK, with your and Jim's consent, I've requested the creation of the project on Savannah. Name: 'git-changelog'. We should ask for it to become a GNU project later. > I would have offered git2cl as a GNU project > already unless it contained code from cvs2cl. Th