Re: [RFC] sethostname handling patch series

2011-11-30 Thread Ben Walton
Excerpts from Bruno Haible's message of Wed Nov 30 05:29:14 -0500 2011: Hi Bruno, > Your patches look pretty good. In parallel to the tweaking of the > last details, it will be useful to assign the copyright for the > change to the FSF. This is needed because Gnulib is central to many > GNU packa

Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-zero-length

2011-11-30 Thread Karl Berry
1) The gcc manual doesn't list all warning flags. 2) The gcc --help=warnings doesn't list all warning flags, although it is a different subset than 1). How about reporting bugs about these things to gcc? 3) Several of the warnings mentioned by gcc --help=warnings does not

Re: unistd.h and getopt.h

2011-11-30 Thread Simon Josefsson
Bruno Haible writes: > Thanks for the analysis. To summarize: > You have 2 gnulib-tool invocations in the scope of a single configure.ac file. > - One gnulib-tool invocation asks for 'unistd'. > - A second gnulib-tool invocation asks for 'unistd' and 'getopt'. > The latter causes the m4 macro

Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-zero-length

2011-11-30 Thread Simon Josefsson
Eric Blake writes: > On 11/30/2011 03:20 AM, Simon Josefsson wrote: >> Eric Blake writes: >> >>> On 11/29/2011 02:46 PM, Eric Blake wrote: > Unless there are objections (portability?) Aargh. I just reread C99. F (and f) for float, and L (or l) for long double are requir

Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-zero-length

2011-11-30 Thread Eric Blake
On 11/30/2011 03:20 AM, Simon Josefsson wrote: > Eric Blake writes: > >> On 11/29/2011 02:46 PM, Eric Blake wrote: Unless there are objections (portability?) >>> >>> Aargh. I just reread C99. >>> >>> F (and f) for float, and L (or l) for long double are required, but D >>> (or d) for double

Re: [RFC] sethostname handling patch series

2011-11-30 Thread Eric Blake
On 11/30/2011 03:29 AM, Bruno Haible wrote: > Hello Ben, > > Your patches look pretty good. In parallel to the tweaking of the last > details, it will be useful to assign the copyright for the change to the > FSF. This is needed because Gnulib is central to many GNU packages. > > To go ahead with

Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-zero-length

2011-11-30 Thread Simon Josefsson
Jim Meyering writes: > Paul Eggert wrote: >> On 11/30/11 02:25, Jim Meyering wrote: >>> how about automating the extraction of the list of >>> warnings from gcc sources or from some web page >> >> Or perhaps extract it from the gcc executable >> itself? Then you'd get all the warnings that the >

Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-zero-length

2011-11-30 Thread Jim Meyering
Simon Josefsson wrote: > Jim Meyering writes: > >> Instead, how about automating the extraction of the list of >> warnings from gcc sources or from some web page? Maybe you've >> already done something like that? >> Then we could add a rule to gnulib's Makefile that would ensure >> our list is up

Re: libidn 1.23

2011-11-30 Thread Simon Josefsson
Bruno Haible writes: > Simon Josefsson wrote: >> This also came up for Libidn, it is using the latest gnulib. >> >> > * mingw with gcc >> > >> > Fails already in the gnulib tests: >> > >> > FAIL: test-binary-io.sh >> >> I have not seen this test fail before. > > I'm seeing this test failure onl

Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-zero-length

2011-11-30 Thread Jim Meyering
Paul Eggert wrote: > On 11/30/11 02:25, Jim Meyering wrote: >> how about automating the extraction of the list of >> warnings from gcc sources or from some web page > > Or perhaps extract it from the gcc executable > itself? Then you'd get all the warnings that the > current GCC supports. Hah! I

Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-zero-length

2011-11-30 Thread Simon Josefsson
Jim Meyering writes: > Instead, how about automating the extraction of the list of > warnings from gcc sources or from some web page? Maybe you've > already done something like that? > Then we could add a rule to gnulib's Makefile that would ensure > our list is up to date and run it periodicall

Re: [PATCH 3/3] Integrate the sethostname module into unistd

2011-11-30 Thread Bruno Haible
Ben Walton wrote: > --- a/lib/unistd.in.h > +++ b/lib/unistd.in.h > @@ -683,6 +683,30 @@ _GL_WARN_ON_USE (getgroups, "getgroups is unportable - " > # endif > #endif > > +#if @GNULIB_SETHOSTNAME@ > +/* Set the host name of the machine. > + The host name may or may not be fully qualified. > + >

Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-zero-length

2011-11-30 Thread Simon Josefsson
Jim Meyering writes: > Simon Josefsson wrote: > >> Eric Blake writes: >> >>> On 11/29/2011 02:46 PM, Eric Blake wrote: > Unless there are objections (portability?) Aargh. I just reread C99. F (and f) for float, and L (or l) for long double are required, but D (or d)

Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-zero-length

2011-11-30 Thread Simon Josefsson
Paul Eggert writes: > On 11/30/11 02:10, Simon Josefsson wrote: >> the philosophy behind the manywarnings module is >> to enable all possible kind of warnings that you can get from gcc > > Hmm, OK, but in that case, shouldn't it be called "allwarnings" > rather than "manywarnings"? I got the imp

Re: [PATCH 2/3] Add a new sethostname module

2011-11-30 Thread Bruno Haible
Ben Walton wrote: > --- a/doc/glibc-functions/sethostname.texi > +++ b/doc/glibc-functions/sethostname.texi > @@ -2,10 +2,15 @@ > @subsection @code{sethostname} > @findex sethostname > > -Gnulib module: --- > +Gnulib module: sethostname Good. > Portability problems fixed by Gnulib: > @itemi

Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-zero-length

2011-11-30 Thread Paul Eggert
On 11/30/11 02:25, Jim Meyering wrote: > how about automating the extraction of the list of > warnings from gcc sources or from some web page Or perhaps extract it from the gcc executable itself? Then you'd get all the warnings that the current GCC supports.

Re: [PATCH 1/3] Split the HOST_NAME_MAX detection into separate m4 macro

2011-11-30 Thread Bruno Haible
Ben Walton wrote: > --- a/m4/gethostname.m4 > +++ b/m4/gethostname.m4 > @@ -1,4 +1,4 @@ > -# gethostname.m4 serial 12 > +# gethostname.m4 serial 13 > dnl Copyright (C) 2002, 2008-2011 Free Software Foundation, Inc. > dnl This file is free software; the Free Software Foundation > dnl gives unlimi

Re: [RFC] sethostname handling patch series

2011-11-30 Thread Bruno Haible
Hello Ben, Your patches look pretty good. In parallel to the tweaking of the last details, it will be useful to assign the copyright for the change to the FSF. This is needed because Gnulib is central to many GNU packages. To go ahead with this, please fill in the form in the file gnulib/doc/Copy

Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-zero-length

2011-11-30 Thread Jim Meyering
Jim Meyering wrote: > Simon Josefsson wrote: > >> Eric Blake writes: >> >>> On 11/29/2011 02:46 PM, Eric Blake wrote: > Unless there are objections (portability?) Aargh. I just reread C99. F (and f) for float, and L (or l) for long double are required, but D (or d) f

Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-zero-length

2011-11-30 Thread Jim Meyering
Simon Josefsson wrote: > Eric Blake writes: > >> On 11/29/2011 02:46 PM, Eric Blake wrote: Unless there are objections (portability?) >>> >>> Aargh. I just reread C99. >>> >>> F (and f) for float, and L (or l) for long double are required, but D >>> (or d) for double is a GNU extension. >>>

Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-zero-length

2011-11-30 Thread Simon Josefsson
Eric Blake writes: > On 11/29/2011 02:46 PM, Eric Blake wrote: >>> Unless there are objections (portability?) >> >> Aargh. I just reread C99. >> >> F (and f) for float, and L (or l) for long double are required, but D >> (or d) for double is a GNU extension. >> >> Since we can't silence the w

Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-zero-length

2011-11-30 Thread Jim Meyering
Simon Josefsson wrote: > Paul Eggert writes: > >> On 11/29/11 09:35, Jim Meyering wrote: >>> + gl_WARN_ADD([-Wno-unsuffixed-float-constants]) >> >> How about if we remove -Wunsuffixed-float-constants from >> manywarnings.m4? In practice it typically causes more >> trouble than it cures (the abo

Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-zero-length

2011-11-30 Thread Paul Eggert
On 11/30/11 02:10, Simon Josefsson wrote: > the philosophy behind the manywarnings module is > to enable all possible kind of warnings that you can get from gcc Hmm, OK, but in that case, shouldn't it be called "allwarnings" rather than "manywarnings"? I got the impression from its name that it d

Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-zero-length

2011-11-30 Thread Simon Josefsson
Paul Eggert writes: > On 11/29/11 09:35, Jim Meyering wrote: >> + gl_WARN_ADD([-Wno-unsuffixed-float-constants]) > > How about if we remove -Wunsuffixed-float-constants from > manywarnings.m4? In practice it typically causes more > trouble than it cures (the above-quoted gzip patch is > one exa

Re: #define FOO rpl_FOO in config.h

2011-11-30 Thread John W. Eaton
On 29-Nov-2011, Eric Blake wrote: | On 11/29/2011 01:01 AM, John W. Eaton wrote: | > While trying to cross compile Octave for MinGW, I hit the following | > errors: | > | > In file included from /home/jwe/src/octave/liboctave/oct-time.h:26:0, | >from /home/jwe/src/octave/lib