quotearg test (was: Re: locale_charset() on MacOS X)

2012-01-28 Thread Bruno Haible
Hi Eric, > - POSIX [1] does not specify the character encoding of the "C" locale. > It could be US-ASCII or any extension of it, such as ISO-8859-1 or > UTF-8. > ... > Let's fix the testsuites. Here's a proposed patch for the testsuite failure currently seen on MacOS X 10.5: test-quo

Re: [PATCH] strtoimax: eliminate need for stdint.h, inttypes.h checks

2012-01-28 Thread Paul Eggert
On 01/28/2012 02:59 PM, Bruno Haible wrote: > Up to now, we have always minimized the code size, > even if it costs some .m4 macros to run at configure time. That's usually fine, and it has the nice properties that you list, but it's not the only objective -- there are also the goals of increasing

Re: [PATCH] strtoimax: eliminate need for stdint.h, inttypes.h checks

2012-01-28 Thread Bruno Haible
Hi Paul, > This reduces the prerequisites for a recently-introduced strtoimax test. > I guess this might cause strtoimax to be replaced when not > strictly necessary on older hosts, but this shouldn't introduce > any bugs and it should make Emacs 'configure' faster on typical > modern hosts. This

Re: test-init.sh failure on AIX 7.1

2012-01-28 Thread Bruno Haible
Hi Jim, Thanks for the quick review. > > -if diff_out_=`exec 2>/dev/null; diff -u "$0" "$0" < /dev/null`; then > > +if diff_out_=`exec 2>/dev/null; diff -u "$0" "$0" < /dev/null` \ > > + && diff -u Makefile "$0" 2>/dev/null | grep '^.#!' >/dev/null; then > > Why use "." rather than a literal "

[PATCH] strtoimax: eliminate need for stdint.h, inttypes.h checks

2012-01-28 Thread Paul Eggert
* m4/strtoimax.m4 (gl_FUNC_STRTOIMAX): Don't use gl_AC_HEADER_STDINT_H or gl_AC_HEADER_INTTYPES_H. This reduces the prerequisites for a recently-introduced strtoimax test. I guess this might cause strtoimax to be replaced when not strictly necessary on older hosts, but this shouldn't introduce any

Re: test-init.sh failure on AIX 7.1

2012-01-28 Thread Jim Meyering
Bruno Haible wrote: > The recently added test-init.sh test fails on AIX 7.1: > > --- exp 2012-01-28 18:51:15.0 + > +++ out 2012-01-28 18:51:15.0 + > @@ -1,3 +1,3 @@ > --- empty > +++ in > - +xyz > + + xyz > FAIL: test-init.sh ... Hi Bruno, Thanks for the ana

test-init.sh failure on AIX 7.1

2012-01-28 Thread Bruno Haible
Hi Jim, The recently added test-init.sh test fails on AIX 7.1: --- exp 2012-01-28 18:51:15.0 + +++ out 2012-01-28 18:51:15.0 + @@ -1,3 +1,3 @@ --- empty +++ in - +xyz + + xyz FAIL: test-init.sh The reason is that these commands $ touch empty $ echo xyz > in $ diff -u

Re: [libvirt] [PATCH libvirt 6/6] Cast timeval.tv_sec long to localtime expected type time_t

2012-01-28 Thread Bruno Haible
> > Should gnulib redefine this struct similarly to other incompatible types? > > Yes, this will make sense. As far as I can see, it's a manageable task: > Only the replacements of , , select(), > gettimeofday(), getsockopt(), setsockopt() will need work. This patch implements it. Tested on mingw

Re: [PATCH gnulib 2/4] accept4, fcntl, w32sock: Avoid warnings on x86_64 mingw64.

2012-01-28 Thread Bruno Haible
Marc-André Lureau wrote: > 2012-01-24 Marc-André Lureau > > + accept4, fcntl, w32sock: Avoid warnings on x86_64 mingw64. > + * lib/accept4.c (accept4): _open_osfhandle() expect a > + intptr_t. > + * lib/fcntl.c (dupfd): Likewise. > + * lib/w32sock.h (SOCKET_TO_FD): Likewis

fcntl and sockets on mingw

2012-01-28 Thread Bruno Haible
In a gnulib testdir for the modules accept accept4 fcntl socket I'm seeing this compilation error on mingw: gcc-3 -mno-cygwin -g -O2 -L/usr/local/mingw/lib -o test-fcntl.exe test-fcntl.o libtests.a ../gllib/libgnu.a libtests.a ../gllib/libgnu.a(fcntl.o): In function `dupfd': /home/bruno/mul

Re: [PATCH gnulib 4/4] RFC stat: x86_64 mingw64 #define stat as _stat64.

2012-01-28 Thread Bruno Haible
Marc-André Lureau wrote: > --- a/lib/tempname.c > +++ b/lib/tempname.c > @@ -61,7 +61,7 @@ > #if _LIBC > # define struct_stat64 struct stat64 > #else > -# define struct_stat64 struct stat > +# define struct_stat64 orig_struct_stat > # define __gen_tempname gen_tempname > # define __getpid getp

Re: [PATCH gnulib 3/4] select, poll, isatty: Avoid warnings on x86_64 mingw64.

2012-01-28 Thread Bruno Haible
Marc-André Lureau wrote: > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,14 @@ > +2012-01-25 Marc-André Lureau > + > + select, poll, isatty: Avoid warnings on x86_64 mingw64. > + * lib/select.c (IsConsoleHandle): Use intptr_t to convert handle > + pointer to an integer. Fix warnings

Re: Patches to README-release

2012-01-28 Thread Jim Meyering
Gary V. Vaughan wrote: > Hi Jim, > > On 28 Jan 2012, at 16:28, Jim Meyering wrote: >> Gary V. Vaughan wrote: >>> I'm wondering what purpose AC_PREREQ (etc) really >>> serves if you're not using them to encode the versions of the >>> autotools that are >>> required to bootstrap a package in the way

Re: Patches to README-release

2012-01-28 Thread Gary V. Vaughan
Hi Jim, On 28 Jan 2012, at 16:28, Jim Meyering wrote: > Gary V. Vaughan wrote: >> I'm wondering what purpose AC_PREREQ (etc) really >> serves if you're not using them to encode the versions of the autotools that >> are >> required to bootstrap a package in the way expected by the maintainers. >

Re: Patches to README-release

2012-01-28 Thread Jim Meyering
Gary V. Vaughan wrote: > On 28 Jan 2012, at 15:27, Jim Meyering wrote: >> Gary V. Vaughan wrote: >>> Hi Jim, >>> >>> On 28 ม.ค. 2012, at 1:21, Jim Meyering wrote: >>> >>>Reuben Thomas wrote: >>> >>>Ping? The patches still apply cleanly to HEAD. >>> >>>On 22 December 2011 19:54,

Re: Patches to README-release

2012-01-28 Thread Jim Meyering
Gary V. Vaughan wrote: > Hi Jim, > > On 28 Jan 2012, at 15:27, Jim Meyering wrote: >> Gary V. Vaughan wrote: >>> Hi Jim, >>> >>> On 28 ม.ค. 2012, at 1:21, Jim Meyering wrote: >>> >>>Reuben Thomas wrote: >>> >>>Ping? The patches still apply cleanly to HEAD. >>> >>>On 22 Decembe

Re: Patches to README-release

2012-01-28 Thread Gary V. Vaughan
Hi Jim, On 28 Jan 2012, at 15:27, Jim Meyering wrote: > Gary V. Vaughan wrote: >> Hi Jim, >> >> On 28 ม.ค. 2012, at 1:21, Jim Meyering wrote: >> >>Reuben Thomas wrote: >> >>Ping? The patches still apply cleanly to HEAD. >> >>On 22 December 2011 19:54, Reuben Thomas wrote:

[PATCH] maint.mk: use more readable (yet functionally equivalent) quoting

2012-01-28 Thread Jim Meyering
FYI, >From e55b2563934c2d4b9c20c0d678a922e871aa25f8 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sat, 28 Jan 2012 10:16:25 +0100 Subject: [PATCH] maint.mk: use more readable (yet functionally equivalent) quoting It is common to quote a single quote in a single quoted string like this: '..

Re: Patches to README-release

2012-01-28 Thread Jim Meyering
Gary V. Vaughan wrote: > Hi Jim, > > On 28 ม.ค. 2012, at 1:21, Jim Meyering wrote: > > Reuben Thomas wrote: > > Ping? The patches still apply cleanly to HEAD. > > On 22 December 2011 19:54, Reuben Thomas wrote: > > -* Ensure that the desired versions of autoconf,