[gnulib] compilation warning

2012-01-30 Thread Chuanchang Jia
Hi all, I'm compiling libvirt project, and I met the following compilation warning when run 'make check', I saw our codes haven't done any check for return value of 'read', 'write' and 'pipe' operations in test-poll.c. IMHO, we should check related return value, although it's just a test case.

Re: [PATCH gnulib 4/4] RFC stat: x86_64 mingw64 #define stat as _stat64.

2012-01-30 Thread Marc-André Lureau
Hi Bruno, On Mon, Jan 30, 2012 at 1:02 AM, Bruno Haible br...@clisp.org wrote: Thanks. Can you please try this patch? I tested this patch, it works with mingw64 both i686 and x86_64, thanks! -- Marc-André Lureau

Re: quotearg test

2012-01-30 Thread Eric Blake
On 01/28/2012 08:32 PM, Bruno Haible wrote: Hi Eric, - POSIX [1] does not specify the character encoding of the C locale. It could be US-ASCII or any extension of it, such as ISO-8859-1 or UTF-8. ... Let's fix the testsuites. Here's a proposed patch for the testsuite failure

Re: gitlog-to-changelog and extra blurbs

2012-01-30 Thread Werner Koch
Hi, I just released the first GnuPG version without a ChangeLog. I used a slightly modified gitlog-to-changelog version and would like to see that feature in gnulib, proper. Shalom-Salam, Werner p.s. My company has a CA for ANY; thus the other address in the patch. From

Re: quotearg test

2012-01-30 Thread Bruno Haible
Hi Eric, 2012-01-28 Bruno Haible br...@clisp.org quotearg: Fix test failure on MacOS X 10.5. * tests/test-quotearg-simple.c: Include localcharset.h. (main): If the locale encoding is not ASCII, bypass the tests of locale_quoting_style and clocale_quoting_style.

test failures on OpenBSD 5.0

2012-01-30 Thread Bruno Haible
On OpenBSD 5.0/SPARC64 I'm seeing these test failures: - test-fma2.h:93: assertion failed Abort trap (core dumped) FAIL: test-fmal2 - test-mkdirat.c:93: assertion failed Abort

Re: [PATCH gnulib 4/4] RFC stat: x86_64 mingw64 #define stat as _stat64.

2012-01-30 Thread Bruno Haible
Marc-André Lureau wrote: I tested this patch, it works with mingw64 both i686 and x86_64, thanks! Good, thanks. I'm committing it: 2012-01-29 Bruno Haible br...@clisp.org sys_stat: Fix support for mingw64 and MSVC. * lib/sys_stat.in.h (stat) [AIX]: Don't redefine 'stat' if

test results on AIX 7.1

2012-01-30 Thread Bruno Haible
On AIX 7.1, there are also a couple of test failures: test-fclose.c:75: assertion failed /bin/sh: 12320772 IOT/Abort trap(coredump) FAIL: test-fclose test-fsync.c:73: assertion failed /bin/sh: 12320950 IOT/Abort trap(coredump) FAIL: test-fsync test-mkfifo.h:52: assertion failed /bin/sh: 7012504

base64 decoding more tolerant to chars

2012-01-30 Thread Nikos Mavrogiannopoulos
Hello, This patch makes the base64 decoding tolerant on carriage returns, spaces and tabs. It is quite common to find PEM encoded files (base64 with new lines) containing such characters and having a tolerant decoder is a plus. regards, Nikos From c56e7ecd745c7e49bbf17bd907c7d305009b19d9 Mon Sep

Re: base64 decoding more tolerant to chars

2012-01-30 Thread Jim Meyering
Nikos Mavrogiannopoulos wrote: This patch makes the base64 decoding tolerant on carriage returns, spaces and tabs. It is quite common to find PEM encoded files (base64 with new lines) containing such characters and having a tolerant decoder is a plus. Hi Nikos, Have you considered

Re: [gnulib] compilation warning

2012-01-30 Thread Bruno Haible
Hi, Chuanchang Jia wrote: I'm compiling libvirt project, and I met the following compilation warning when run 'make check', I saw our codes haven't done any check for return value of 'read', 'write' and 'pipe' operations in test-poll.c. IMHO, we should check related return value, although

doc tweak

2012-01-30 Thread Bruno Haible
Two gcc warnings in the unit tests pointed me to function declarations incompatible to POSIX in the Solaris 11 2011-11 header files. 2012-01-29 Bruno Haible br...@clisp.org doc about getlogin_r, setstate. * doc/posix-functions/getlogin_r.texi: List the incompatible

Re: base64 decoding more tolerant to chars

2012-01-30 Thread Nikos Mavrogiannopoulos
On 01/30/2012 10:29 PM, Jim Meyering wrote: Hi Nikos, Have you considered pre-filtering the data you pass to the base64-decoding function? We considered what you're proposing when adding the --ignore-garbage option to the command-line base64 program: Hello, Could also be done, but since

pclose typo

2012-01-30 Thread Bruno Haible
An obvious copypaste bug. 2012-01-29 Bruno Haible br...@clisp.org pclose: Fix typo. * lib/stdio.in.h (pclose): Fix typo in warning message. --- lib/stdio.in.h.orig Tue Jan 31 03:01:13 2012 +++ lib/stdio.in.h Tue Jan 31 02:56:19 2012 @@ -779,7 +779,7 @@ #elif defined

Re: [gnulib] compilation warning

2012-01-30 Thread Chuanchang Jia
2012/1/31 Bruno Haible br...@clisp.org Hi, Chuanchang Jia wrote: I'm compiling libvirt project, and I met the following compilation warning when run 'make check', I saw our codes haven't done any check for return value of 'read', 'write' and 'pipe' operations in test-poll.c. IMHO,