Re: large integer truncation in regex module

2012-03-25 Thread Jim Meyering
Gianluigi Tiesi wrote: > On 26/03/2012 7.33, Jim Meyering wrote: >> Gianluigi Tiesi wrote: >>> On 25/03/2012 6.58, Paul Eggert wrote: On 03/24/2012 09:28 PM, Gianluigi Tiesi wrote: > While compiling regex module one android I've discovered a problem > that on other 32bit compiler is o

Re: large integer truncation in regex module

2012-03-25 Thread Gianluigi Tiesi
On 26/03/2012 7.33, Jim Meyering wrote: Gianluigi Tiesi wrote: On 25/03/2012 6.58, Paul Eggert wrote: On 03/24/2012 09:28 PM, Gianluigi Tiesi wrote: While compiling regex module one android I've discovered a problem that on other 32bit compiler is only a warning ... it's correct, but I think

Re: large integer truncation in regex module

2012-03-25 Thread Jim Meyering
Gianluigi Tiesi wrote: > On 25/03/2012 6.58, Paul Eggert wrote: >> On 03/24/2012 09:28 PM, Gianluigi Tiesi wrote: >>> While compiling regex module one android I've discovered a problem >>> that on other 32bit compiler is only a warning >>> >>> ... >>> it's correct, but I think an ifdef may be used

abort() in regex.c

2012-03-25 Thread Vladimir 'φ-coder/phcoder' Serbinenko
Hello, all. In GRUB everything runs in the same environment and so abort() can only be mapped to complete bootloader termination. It's unreasonable to do such an action in case of regexp error. Can we do something like following: === modified file 'grub-core/gnulib/regcomp.c' --- grub-core/gnulib/r

[PATCH] Add const qualifier for charset_name in init_dfa

2012-03-25 Thread Vladimir 'φ-coder/phcoder' Serbinenko
In GRUB charset is hardwired to UTF-8 and we return just a pointer to "UTF-8" in nl_langinfo (CODESET); I propose adding const qualifier since this function already handles codeset_name as a pointer to const string. === modified file 'grub-core/gnulib/regcomp.c' --- grub-core/gnulib/regcomp.c2

new module 'localeconv'

2012-03-25 Thread Bruno Haible
And here's the localeconv() override that is necessary when 'struct lconv' is overridden. 2012-03-25 Bruno Haible New module 'localeconv'. * lib/locale.in.h (localeconv): New declaration. * lib/localeconv.c: New file. * m4/localeconv.m4: New file. * m4/

Re: android bionc has dummy lconv

2012-03-25 Thread Bruno Haible
> Portability problems not fixed by Gnulib: > @itemize > +@item > +The @code{struct lconv} type does not contain the members > +@code{int_p_cs_precedes}, @code{int_p_sign_posn}, @code{int_p_sep_by_space}, > +@code{int_n_cs_precedes}, @code{int_n_sign_posn}, @code{int_n_sep_by_space} > +on some pl

Re: android bionc has dummy lconv

2012-03-25 Thread Bruno Haible
> Portability problems not fixed by Gnulib: > @itemize > +@item > +The @code{struct lconv} type does not contain the members > +@code{int_p_cs_precedes}, @code{int_p_sign_posn}, @code{int_p_sep_by_space}, > +@code{int_n_cs_precedes}, @code{int_n_sign_posn}, @code{int_n_sep_by_space} > +on some pl

Re: android bionc has dummy lconv

2012-03-25 Thread Bruno Haible
Gianluigi Tiesi wrote: > sorry (sent the first email by mistake) > > #if 1 /* MISSING FROM BIONIC - DEFINED TO MAKE libstdc++-v3 happy */ > struct lconv { }; > struct lconv *localeconv(void); > #endif /* MISSING */ > ... > android bionic hasn't locale support by design) Thanks for the info. > th

Re: large integer truncation in regex module

2012-03-25 Thread Gianluigi Tiesi
On 25/03/2012 6.58, Paul Eggert wrote: On 03/24/2012 09:28 PM, Gianluigi Tiesi wrote: While compiling regex module one android I've discovered a problem that on other 32bit compiler is only a warning ... it's correct, but I think an ifdef may be used instead since BITSET_WORD_BITS is a define